From: Sam Ravnborg <sam@ravnborg.org> To: Harigovindan P <harigovi@codeaurora.org> Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, sean@poorly.run, seanpaul@chromium.org Subject: Re: [PATCHv3 1/2] dt-bindings: display: add visionox rm69299 panel variant Date: Sun, 9 Feb 2020 09:31:38 +0100 [thread overview] Message-ID: <20200209083138.GC5321@ravnborg.org> (raw) In-Reply-To: <1580907990-32108-2-git-send-email-harigovi@codeaurora.org> Hi Harigovindan On Wed, Feb 05, 2020 at 06:36:29PM +0530, Harigovindan P wrote: > Add bindings for visionox rm69299 panel. > > Signed-off-by: Harigovindan P <harigovi@codeaurora.org> > --- > > Changes in v1: > - Added a compatible string to support sc7180 panel version. > Changes in v2: > - Removed unwanted properties from description. > - Creating source files without execute permissions(Rob Herring). > Changes in v3: > - Changing txt file into yaml Thanks for changing to DT Schema. > > .../bindings/display/visionox,rm69299.yaml | 109 +++++++++++++++++++++ > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/visionox,rm69299.yaml > > diff --git a/Documentation/devicetree/bindings/display/visionox,rm69299.yaml b/Documentation/devicetree/bindings/display/visionox,rm69299.yaml > new file mode 100644 > index 0000000..bfcd46d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/visionox,rm69299.yaml This is a binding for a panel - and thus belongs in the panel/ directory. > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: GPL-2.0-only The preferred license for new bindings are (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/visionox,rm69299.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Visionox model RM69299 Panels Device Tree Bindings > + > +maintainers: > + - Harigovindan P <harigovi@codeaurora.org> > + - Kalyan Thota <kalyan_t@codeaurora.org> > + - Vishnuvardhan Prodduturi <vproddut@codeaurora.org> > + > +description: > + This binding is for display panels using a Visionox RM692999 panel. > + Use: allOf: - $ref: panel-common.yaml# Then you have access to all properties described there. > +patternProperties: > + "^(panel|panel-dsi)@[0-9]$": > + type: object > + description: > + A node containing the panel or bridge description as documented in > + Documentation/devicetree/bindings/display/mipi-dsi-bus.txt The panel shall not document the parent node. See how other panels do it. In general - start with the compatible. This will also simplify your list of required properties. > + properties: > + compatible: > + const: visionox,rm69299-1080p-display > + > + reg: > + maxItems: 1 > + > + vdda-supply: > + description: > + Phandle of the regulator that provides the vdda supply voltage. > + > + vdd3p3-supply: > + description: > + Phandle of the regulator that provides the vdd3p3 supply voltage. > + > + pinctrl-names: > + items: > + - const: default > + - const: suspend > + > + pinctrl-0: > + items: > + - const: Display default pin > + - const: Display default pin pinctrl are not needed for the panel. They belong to the display driver. > + > + ports: > + type: object > + description: > + A node containing DSI input & output port nodes with endpoint > + definitions as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + Documentation/devicetree/bindings/graph.txt > + properties: > + port@0: > + type: object > + description: > + DSI input port node. > + A port: true should do the trick here. > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 Not required. > + > +required: > + - "#address-cells" > + - "#size-cells" > + - compatible > + - reg > + - vdda-supply > + - vdd3p3-supply > + - pinctrl-names > + - pinctrl-0 > + - pinctrl-1 > + - reset-gpios reset-gpios are not documented in the above. Add reset-gpios: true Please give it a spin more. And preferably give it a "make dt_binding_check" whirl. If you cannot get this part working I can do so for you in next reviision. Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org> To: Harigovindan P <harigovi@codeaurora.org> Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, sean@poorly.run Subject: Re: [PATCHv3 1/2] dt-bindings: display: add visionox rm69299 panel variant Date: Sun, 9 Feb 2020 09:31:38 +0100 [thread overview] Message-ID: <20200209083138.GC5321@ravnborg.org> (raw) In-Reply-To: <1580907990-32108-2-git-send-email-harigovi@codeaurora.org> Hi Harigovindan On Wed, Feb 05, 2020 at 06:36:29PM +0530, Harigovindan P wrote: > Add bindings for visionox rm69299 panel. > > Signed-off-by: Harigovindan P <harigovi@codeaurora.org> > --- > > Changes in v1: > - Added a compatible string to support sc7180 panel version. > Changes in v2: > - Removed unwanted properties from description. > - Creating source files without execute permissions(Rob Herring). > Changes in v3: > - Changing txt file into yaml Thanks for changing to DT Schema. > > .../bindings/display/visionox,rm69299.yaml | 109 +++++++++++++++++++++ > 1 file changed, 109 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/visionox,rm69299.yaml > > diff --git a/Documentation/devicetree/bindings/display/visionox,rm69299.yaml b/Documentation/devicetree/bindings/display/visionox,rm69299.yaml > new file mode 100644 > index 0000000..bfcd46d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/visionox,rm69299.yaml This is a binding for a panel - and thus belongs in the panel/ directory. > @@ -0,0 +1,109 @@ > +# SPDX-License-Identifier: GPL-2.0-only The preferred license for new bindings are (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/visionox,rm69299.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Visionox model RM69299 Panels Device Tree Bindings > + > +maintainers: > + - Harigovindan P <harigovi@codeaurora.org> > + - Kalyan Thota <kalyan_t@codeaurora.org> > + - Vishnuvardhan Prodduturi <vproddut@codeaurora.org> > + > +description: > + This binding is for display panels using a Visionox RM692999 panel. > + Use: allOf: - $ref: panel-common.yaml# Then you have access to all properties described there. > +patternProperties: > + "^(panel|panel-dsi)@[0-9]$": > + type: object > + description: > + A node containing the panel or bridge description as documented in > + Documentation/devicetree/bindings/display/mipi-dsi-bus.txt The panel shall not document the parent node. See how other panels do it. In general - start with the compatible. This will also simplify your list of required properties. > + properties: > + compatible: > + const: visionox,rm69299-1080p-display > + > + reg: > + maxItems: 1 > + > + vdda-supply: > + description: > + Phandle of the regulator that provides the vdda supply voltage. > + > + vdd3p3-supply: > + description: > + Phandle of the regulator that provides the vdd3p3 supply voltage. > + > + pinctrl-names: > + items: > + - const: default > + - const: suspend > + > + pinctrl-0: > + items: > + - const: Display default pin > + - const: Display default pin pinctrl are not needed for the panel. They belong to the display driver. > + > + ports: > + type: object > + description: > + A node containing DSI input & output port nodes with endpoint > + definitions as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + Documentation/devicetree/bindings/graph.txt > + properties: > + port@0: > + type: object > + description: > + DSI input port node. > + A port: true should do the trick here. > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 Not required. > + > +required: > + - "#address-cells" > + - "#size-cells" > + - compatible > + - reg > + - vdda-supply > + - vdd3p3-supply > + - pinctrl-names > + - pinctrl-0 > + - pinctrl-1 > + - reset-gpios reset-gpios are not documented in the above. Add reset-gpios: true Please give it a spin more. And preferably give it a "make dt_binding_check" whirl. If you cannot get this part working I can do so for you in next reviision. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-09 8:31 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-05 13:06 [PATCHv3 0/2] Add support for rm69299 Visionox panel driver and add devicetree bindings for visionox panel Harigovindan P 2020-02-05 13:06 ` Harigovindan P 2020-02-05 13:06 ` [PATCHv3 1/2] dt-bindings: display: add visionox rm69299 panel variant Harigovindan P 2020-02-05 13:06 ` Harigovindan P 2020-02-05 16:40 ` Rob Herring 2020-02-05 16:40 ` Rob Herring 2020-02-09 8:31 ` Sam Ravnborg [this message] 2020-02-09 8:31 ` Sam Ravnborg 2020-02-05 13:06 ` [PATCHv3 2/2] drm/panel: add support for rm69299 visionox panel driver Harigovindan P 2020-02-05 13:06 ` Harigovindan P 2020-02-25 5:38 ` Bjorn Andersson 2020-02-25 5:38 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200209083138.GC5321@ravnborg.org \ --to=sam@ravnborg.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=harigovi@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=sean@poorly.run \ --cc=seanpaul@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.