Re: [PATCH 5/5] ARM: dts: sun7i: Add Linutronix Testbox v2 board

From: Maxime Ripard <maxime@cerno.tech>
To: bage@linutronix.de
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Benedikt Spranger <b.spranger@linutronix.de>
Subject: Re: [PATCH 5/5] ARM: dts: sun7i: Add Linutronix Testbox v2 board
Date: Mon, 10 Feb 2020 08:56:28 +0100	[thread overview]
Message-ID: <20200210075628.2oaa4xnvkwoxkpr6@gilmour.lan> (raw)
In-Reply-To: <20200206113328.7296-6-bage@linutronix.de>

[-- Attachment #1: Type: text/plain, Size: 2396 bytes --]

On Thu, Feb 06, 2020 at 12:33:27PM +0100, bage@linutronix.de wrote:
> From: Bastian Germann <bage@linutronix.de>
>
> The Testbox board is an open hardware enhancement for the Lamobo R1 router
> board.  The Testbox board is used in the CI-RT project to manage devices
> under test (https://ci-rt.linutronix.de).
>
> The hardware project is located at https://github.com/ci-rt/testbox-shield
>
> The Testbox v2 expands the Lamobo R1 router board with
> - a power supply,
> - a CAN bus PHY,
> - a power control,
> - a relay,
> - a I2C EEPROM,
> - a secure key storage (ATECC608a) and
> - two RS232 compliant serial ports.
>
> Co-developed-by: Benedikt Spranger <b.spranger@linutronix.de>
> Signed-off-by: Benedikt Spranger <b.spranger@linutronix.de>
> Signed-off-by: Bastian Germann <bage@linutronix.de>
> ---
>  arch/arm/boot/dts/Makefile                    |  1 +
>  arch/arm/boot/dts/sun7i-a20-lx-testbox-v2.dts | 65 +++++++++++++++++++
>  2 files changed, 66 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun7i-a20-lx-testbox-v2.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 08011dc8c7a6..383541842695 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1069,6 +1069,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
>  	sun7i-a20-i12-tvbox.dtb \
>  	sun7i-a20-icnova-swac.dtb \
>  	sun7i-a20-lamobo-r1.dtb \
> +	sun7i-a20-lx-testbox-v2.dtb \
>  	sun7i-a20-m3.dtb \
>  	sun7i-a20-mk808c.dtb \
>  	sun7i-a20-olimex-som-evb.dtb \
> diff --git a/arch/arm/boot/dts/sun7i-a20-lx-testbox-v2.dts b/arch/arm/boot/dts/sun7i-a20-lx-testbox-v2.dts
> new file mode 100644
> index 000000000000..3b91fb026a92
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun7i-a20-lx-testbox-v2.dts
> @@ -0,0 +1,65 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

Using a double license would be great, otherwise other projects
licensed under something else than the GPL might not be able to use
it.

> +/*
> + * Copyright 2020 Linutronix GmbH
> + * Author: Benedikt Spranger <b.spranger@linutronix.de>
> + */
> +
> +/dts-v1/;
> +#include "sun7i-a20-lamobo-r1-common.dtsi"
> +
> +/ {
> +	model = "Lamobo R1";
> +	compatible = "lx,testbox-v2", "lamobo,lamobo-r1", "allwinner,sun7i-a20";
> +
> +	leds {
> +		compatible = "gpio-leds";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&led_pins_lamobo_r1>;

You don't need the pinctrl nodes at all for GPIOs

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]