Re: [PATCH 5/5] ARM: dts: sun7i: Add Linutronix Testbox v2 board

[Maxime Ripard <maxime@cerno.tech>]

[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]

On Wed, Feb 12, 2020 at 12:20:01PM +0100, Benedikt Spranger wrote:
> On Mon, 10 Feb 2020 08:56:28 +0100
> Maxime Ripard <maxime@cerno.tech> wrote:
>
> > > +// SPDX-License-Identifier: GPL-2.0-or-later
> >
> > Using a double license would be great, otherwise other projects
> > licensed under something else than the GPL might not be able to use
> > it.
>
> I don't get it, why GPL v2 is not adequate here...

*BSD for example can't include a file under the GPL. It's not that the
 GPL is not adequate, it's that the GPL + MIT is better, since more
 people would be able to use it.

But then, if you don't care, that's not something that will prevent
the patch from going in either, just something that you should
consider.

> > > +	leds {
> > > +		compatible = "gpio-leds";
> > > +		pinctrl-names = "default";
> > > +		pinctrl-0 = <&led_pins_lamobo_r1>;
> >
> > You don't need the pinctrl nodes at all for GPIOs
>
> I did not agree on that:
>
> The pincontrol configuration depend on the bootloader if you omit the
> configuration here. That may sufficient in most cases, but can cause
> unexpected behaviour after updating the bootloader or using kexec.

What configuration do you want to have enforced?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]