From: Greg KH <gregkh@linuxfoundation.org>
To: Wu Hao <hao.wu@intel.com>
Cc: mdf@kernel.org, will@kernel.org, mark.rutland@arm.com,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, atull@kernel.org, yilun.xu@intel.com,
Luwei Kang <luwei.kang@intel.com>
Subject: Re: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support
Date: Mon, 10 Feb 2020 12:56:18 -0800 [thread overview]
Message-ID: <20200210205618.GA1347752@kroah.com> (raw)
In-Reply-To: <1581306469-22629-3-git-send-email-hao.wu@intel.com>
On Mon, Feb 10, 2020 at 11:47:49AM +0800, Wu Hao wrote:
> +What: /sys/bus/event_source/devices/fmeX/format
> +Date: February 2020
> +KernelVersion: 5.7
> +Contact: Wu Hao <hao.wu@intel.com>
> +Description: Read-only. Attribute group to describe the magic bits
> + that go into perf_event_attr.config for a particular pmu.
> + (See ABI/testing/sysfs-bus-event_source-devices-format).
> +
> + Each attribute under this group defines a bit range of the
> + perf_event_attr.config. All supported attributes are listed
> + below.
> +
> + event = "config:0-11" - event ID
> + evtype = "config:12-15" - event type
> + portid = "config:16-23" - event source
> +
> + For example,
> +
> + fab_mmio_read = "event=0x06,evtype=0x02,portid=0xff"
Are perf sysfs files always this bad "multiple values per file"? Or is
that unique to this driver? If not unique, do you have specific
examples in the kernel that currently do this today?
> +static struct attribute *fme_perf_events_attrs_empty[] = {
> + NULL,
Huh?
> +};
> +
> +static struct attribute_group fme_perf_events_group = {
> + .name = "events",
> + .attrs = fme_perf_events_attrs_empty,
You create an empty directory? Why? What goes in here?
very odd...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Wu Hao <hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: mdf-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
will-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
yilun.xu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Luwei Kang <luwei.kang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v7 2/2] fpga: dfl: fme: add performance reporting support
Date: Mon, 10 Feb 2020 12:56:18 -0800 [thread overview]
Message-ID: <20200210205618.GA1347752@kroah.com> (raw)
In-Reply-To: <1581306469-22629-3-git-send-email-hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Mon, Feb 10, 2020 at 11:47:49AM +0800, Wu Hao wrote:
> +What: /sys/bus/event_source/devices/fmeX/format
> +Date: February 2020
> +KernelVersion: 5.7
> +Contact: Wu Hao <hao.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> +Description: Read-only. Attribute group to describe the magic bits
> + that go into perf_event_attr.config for a particular pmu.
> + (See ABI/testing/sysfs-bus-event_source-devices-format).
> +
> + Each attribute under this group defines a bit range of the
> + perf_event_attr.config. All supported attributes are listed
> + below.
> +
> + event = "config:0-11" - event ID
> + evtype = "config:12-15" - event type
> + portid = "config:16-23" - event source
> +
> + For example,
> +
> + fab_mmio_read = "event=0x06,evtype=0x02,portid=0xff"
Are perf sysfs files always this bad "multiple values per file"? Or is
that unique to this driver? If not unique, do you have specific
examples in the kernel that currently do this today?
> +static struct attribute *fme_perf_events_attrs_empty[] = {
> + NULL,
Huh?
> +};
> +
> +static struct attribute_group fme_perf_events_group = {
> + .name = "events",
> + .attrs = fme_perf_events_attrs_empty,
You create an empty directory? Why? What goes in here?
very odd...
greg k-h
next prev parent reply other threads:[~2020-02-10 20:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 3:47 [PATCH v7 0/2] add performance reporting support to FPGA DFL drivers Wu Hao
2020-02-10 3:47 ` Wu Hao
2020-02-10 3:47 ` [PATCH v7 1/2] Documentation: fpga: dfl: add description for performance reporting support Wu Hao
2020-02-10 3:47 ` Wu Hao
2020-02-10 3:47 ` [PATCH v7 2/2] fpga: dfl: fme: add " Wu Hao
2020-02-10 3:47 ` Wu Hao
2020-02-10 16:34 ` Will Deacon
2020-02-10 16:34 ` Will Deacon
2020-02-12 3:19 ` Wu Hao
2020-02-12 3:19 ` Wu Hao
2020-02-12 5:30 ` Greg KH
2020-02-12 10:02 ` Wu Hao
2020-02-12 10:02 ` Wu Hao
2020-02-12 13:20 ` Greg KH
2020-02-13 2:51 ` Wu Hao
2020-02-13 2:51 ` Wu Hao
2020-02-10 20:56 ` Greg KH [this message]
2020-02-10 20:56 ` Greg KH
2020-02-12 2:39 ` Wu Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210205618.GA1347752@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=atull@kernel.org \
--cc=hao.wu@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=will@kernel.org \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.