All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: linux-fsdevel@vger.kernel.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org,
	linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
	ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org
Subject: [PATCH v5 02/13] mm: Ignore return value of ->readpages
Date: Mon, 10 Feb 2020 17:03:37 -0800	[thread overview]
Message-ID: <20200211010348.6872-3-willy@infradead.org> (raw)
In-Reply-To: <20200211010348.6872-1-willy@infradead.org>

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

We used to assign the return value to a variable, which we then ignored.
Remove the pretence of caring.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 mm/readahead.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/mm/readahead.c b/mm/readahead.c
index 6bf73ef33b7e..fc77d13af556 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -113,17 +113,16 @@ int read_cache_pages(struct address_space *mapping, struct list_head *pages,
 
 EXPORT_SYMBOL(read_cache_pages);
 
-static int read_pages(struct address_space *mapping, struct file *filp,
+static void read_pages(struct address_space *mapping, struct file *filp,
 		struct list_head *pages, unsigned int nr_pages, gfp_t gfp)
 {
 	struct blk_plug plug;
 	unsigned page_idx;
-	int ret;
 
 	blk_start_plug(&plug);
 
 	if (mapping->a_ops->readpages) {
-		ret = mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
+		mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
 		/* Clean up the remaining pages */
 		put_pages_list(pages);
 		goto out;
@@ -136,12 +135,9 @@ static int read_pages(struct address_space *mapping, struct file *filp,
 			mapping->a_ops->readpage(filp, page);
 		put_page(page);
 	}
-	ret = 0;
 
 out:
 	blk_finish_plug(&plug);
-
-	return ret;
 }
 
 /*
-- 
2.25.0


WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: linux-fsdevel@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Matthew Wilcox \(Oracle\)" <willy@infradead.org>,
	linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
	linux-mm@kvack.org, ocfs2-devel@oss.oracle.com,
	linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org,
	linux-btrfs@vger.kernel.org
Subject: [f2fs-dev] [PATCH v5 02/13] mm: Ignore return value of ->readpages
Date: Mon, 10 Feb 2020 17:03:37 -0800	[thread overview]
Message-ID: <20200211010348.6872-3-willy@infradead.org> (raw)
In-Reply-To: <20200211010348.6872-1-willy@infradead.org>

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

We used to assign the return value to a variable, which we then ignored.
Remove the pretence of caring.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 mm/readahead.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/mm/readahead.c b/mm/readahead.c
index 6bf73ef33b7e..fc77d13af556 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -113,17 +113,16 @@ int read_cache_pages(struct address_space *mapping, struct list_head *pages,
 
 EXPORT_SYMBOL(read_cache_pages);
 
-static int read_pages(struct address_space *mapping, struct file *filp,
+static void read_pages(struct address_space *mapping, struct file *filp,
 		struct list_head *pages, unsigned int nr_pages, gfp_t gfp)
 {
 	struct blk_plug plug;
 	unsigned page_idx;
-	int ret;
 
 	blk_start_plug(&plug);
 
 	if (mapping->a_ops->readpages) {
-		ret = mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
+		mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
 		/* Clean up the remaining pages */
 		put_pages_list(pages);
 		goto out;
@@ -136,12 +135,9 @@ static int read_pages(struct address_space *mapping, struct file *filp,
 			mapping->a_ops->readpage(filp, page);
 		put_page(page);
 	}
-	ret = 0;
 
 out:
 	blk_finish_plug(&plug);
-
-	return ret;
 }
 
 /*
-- 
2.25.0



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: linux-fsdevel@vger.kernel.org
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Matthew Wilcox \(Oracle\)" <willy@infradead.org>,
	linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
	linux-mm@kvack.org, ocfs2-devel@oss.oracle.com,
	linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org,
	linux-btrfs@vger.kernel.org
Subject: [PATCH v5 02/13] mm: Ignore return value of ->readpages
Date: Mon, 10 Feb 2020 17:03:37 -0800	[thread overview]
Message-ID: <20200211010348.6872-3-willy@infradead.org> (raw)
In-Reply-To: <20200211010348.6872-1-willy@infradead.org>

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

We used to assign the return value to a variable, which we then ignored.
Remove the pretence of caring.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 mm/readahead.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/mm/readahead.c b/mm/readahead.c
index 6bf73ef33b7e..fc77d13af556 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -113,17 +113,16 @@ int read_cache_pages(struct address_space *mapping, struct list_head *pages,
 
 EXPORT_SYMBOL(read_cache_pages);
 
-static int read_pages(struct address_space *mapping, struct file *filp,
+static void read_pages(struct address_space *mapping, struct file *filp,
 		struct list_head *pages, unsigned int nr_pages, gfp_t gfp)
 {
 	struct blk_plug plug;
 	unsigned page_idx;
-	int ret;
 
 	blk_start_plug(&plug);
 
 	if (mapping->a_ops->readpages) {
-		ret = mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
+		mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
 		/* Clean up the remaining pages */
 		put_pages_list(pages);
 		goto out;
@@ -136,12 +135,9 @@ static int read_pages(struct address_space *mapping, struct file *filp,
 			mapping->a_ops->readpage(filp, page);
 		put_page(page);
 	}
-	ret = 0;
 
 out:
 	blk_finish_plug(&plug);
-
-	return ret;
 }
 
 /*
-- 
2.25.0


WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v5 02/13] mm: Ignore return value of ->readpages
Date: Mon, 10 Feb 2020 17:03:37 -0800	[thread overview]
Message-ID: <20200211010348.6872-3-willy@infradead.org> (raw)
In-Reply-To: <20200211010348.6872-1-willy@infradead.org>

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

We used to assign the return value to a variable, which we then ignored.
Remove the pretence of caring.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 mm/readahead.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/mm/readahead.c b/mm/readahead.c
index 6bf73ef33b7e..fc77d13af556 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -113,17 +113,16 @@ int read_cache_pages(struct address_space *mapping, struct list_head *pages,
 
 EXPORT_SYMBOL(read_cache_pages);
 
-static int read_pages(struct address_space *mapping, struct file *filp,
+static void read_pages(struct address_space *mapping, struct file *filp,
 		struct list_head *pages, unsigned int nr_pages, gfp_t gfp)
 {
 	struct blk_plug plug;
 	unsigned page_idx;
-	int ret;
 
 	blk_start_plug(&plug);
 
 	if (mapping->a_ops->readpages) {
-		ret = mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
+		mapping->a_ops->readpages(filp, mapping, pages, nr_pages);
 		/* Clean up the remaining pages */
 		put_pages_list(pages);
 		goto out;
@@ -136,12 +135,9 @@ static int read_pages(struct address_space *mapping, struct file *filp,
 			mapping->a_ops->readpage(filp, page);
 		put_page(page);
 	}
-	ret = 0;
 
 out:
 	blk_finish_plug(&plug);
-
-	return ret;
 }
 
 /*
-- 
2.25.0




  parent reply	other threads:[~2020-02-11  1:05 UTC|newest]

Thread overview: 140+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11  1:03 [PATCH v5 00/13] Change readahead API Matthew Wilcox
2020-02-11  1:03 ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03 ` Matthew Wilcox
2020-02-11  1:03 ` [f2fs-dev] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 01/13] mm: Fix the return type of __do_page_cache_readahead Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-11  8:19   ` Johannes Thumshirn
2020-02-11  8:19     ` [Cluster-devel] " Johannes Thumshirn
2020-02-11  8:19     ` Johannes Thumshirn
2020-02-11  8:19     ` [f2fs-dev] " Johannes Thumshirn
2020-02-11  8:19     ` Johannes Thumshirn
2020-02-11 12:34     ` Matthew Wilcox
2020-02-11 12:34       ` [Cluster-devel] " Matthew Wilcox
2020-02-11 12:34       ` Matthew Wilcox
2020-02-11 12:34       ` [f2fs-dev] " Matthew Wilcox
2020-02-11 12:34       ` Matthew Wilcox
2020-02-12 18:13   ` Christoph Hellwig
2020-02-12 18:13     ` [Cluster-devel] " Christoph Hellwig
2020-02-12 18:13     ` Christoph Hellwig
2020-02-12 18:13     ` [f2fs-dev] " Christoph Hellwig
2020-02-12 18:13     ` [Ocfs2-devel] " Christoph Hellwig
2020-02-14  3:19   ` John Hubbard
2020-02-14  3:19     ` [Cluster-devel] " John Hubbard
2020-02-14  3:19     ` John Hubbard
2020-02-14  3:19     ` [f2fs-dev] " John Hubbard
2020-02-14  3:19     ` [Ocfs2-devel] " John Hubbard
2020-02-14  4:21     ` Matthew Wilcox
2020-02-14  4:21       ` [Cluster-devel] " Matthew Wilcox
2020-02-14  4:21       ` Matthew Wilcox
2020-02-14  4:21       ` [f2fs-dev] " Matthew Wilcox
2020-02-14  4:21       ` [Ocfs2-devel] " Matthew Wilcox
2020-02-14  4:33       ` John Hubbard
2020-02-14  4:33         ` [Cluster-devel] " John Hubbard
2020-02-14  4:33         ` John Hubbard
2020-02-14  4:33         ` [f2fs-dev] " John Hubbard
2020-02-14  4:33         ` [Ocfs2-devel] " John Hubbard
2020-02-14 19:50   ` Matthew Wilcox
2020-02-14 19:50     ` [Cluster-devel] " Matthew Wilcox
2020-02-14 19:50     ` Matthew Wilcox
2020-02-14 19:50     ` [f2fs-dev] " Matthew Wilcox
2020-02-14 19:50     ` [Ocfs2-devel] " Matthew Wilcox
2020-02-11  1:03 ` Matthew Wilcox [this message]
2020-02-11  1:03   ` [Cluster-devel] [PATCH v5 02/13] mm: Ignore return value of ->readpages Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-12 18:13   ` Christoph Hellwig
2020-02-12 18:13     ` [Cluster-devel] " Christoph Hellwig
2020-02-12 18:13     ` Christoph Hellwig
2020-02-12 18:13     ` [f2fs-dev] " Christoph Hellwig
2020-02-12 18:13     ` [Ocfs2-devel] " Christoph Hellwig
2020-02-11  1:03 ` [PATCH v5 03/13] mm: Put readahead pages in cache earlier Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-14  3:36   ` John Hubbard
2020-02-14  3:36     ` [Cluster-devel] " John Hubbard
2020-02-14  3:36     ` John Hubbard
2020-02-14  3:36     ` [f2fs-dev] " John Hubbard
2020-02-14  3:36     ` [Ocfs2-devel] " John Hubbard
2020-02-15  1:15     ` Matthew Wilcox
2020-02-15  1:15       ` [Cluster-devel] " Matthew Wilcox
2020-02-15  1:15       ` Matthew Wilcox
2020-02-15  1:15       ` [f2fs-dev] " Matthew Wilcox
2020-02-15  1:15       ` [Ocfs2-devel] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 04/13] mm: Add readahead address space operation Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-11  4:52   ` Dave Chinner
2020-02-11  4:52     ` [Cluster-devel] " Dave Chinner
2020-02-11  4:52     ` Dave Chinner
2020-02-11  4:52     ` [f2fs-dev] " Dave Chinner
2020-02-11  4:52     ` [Ocfs2-devel] " Dave Chinner
2020-02-11 12:54     ` Matthew Wilcox
2020-02-11 12:54       ` [Cluster-devel] " Matthew Wilcox
2020-02-11 12:54       ` Matthew Wilcox
2020-02-11 12:54       ` [f2fs-dev] " Matthew Wilcox
2020-02-11 20:08       ` Dave Chinner
2020-02-11 20:08         ` [Cluster-devel] " Dave Chinner
2020-02-11 20:08         ` Dave Chinner
2020-02-11 20:08         ` [f2fs-dev] " Dave Chinner
2020-02-11 20:08         ` [Ocfs2-devel] " Dave Chinner
2020-02-12 18:18   ` Christoph Hellwig
2020-02-12 18:18     ` [Cluster-devel] " Christoph Hellwig
2020-02-12 18:18     ` Christoph Hellwig
2020-02-12 18:18     ` [f2fs-dev] " Christoph Hellwig
2020-02-12 18:18     ` [Ocfs2-devel] " Christoph Hellwig
2020-02-14  5:36   ` John Hubbard
2020-02-14  5:36     ` [Cluster-devel] " John Hubbard
2020-02-14  5:36     ` John Hubbard
2020-02-14  5:36     ` [f2fs-dev] " John Hubbard
2020-02-14  5:36     ` [Ocfs2-devel] " John Hubbard
2020-02-15  1:15     ` Matthew Wilcox
2020-02-15  1:15       ` [Cluster-devel] " Matthew Wilcox
2020-02-15  1:15       ` Matthew Wilcox
2020-02-15  1:15       ` [f2fs-dev] " Matthew Wilcox
2020-02-15  1:15       ` [Ocfs2-devel] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 05/13] mm: Add page_cache_readahead_limit Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 06/13] fs: Convert mpage_readpages to mpage_readahead Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-13 22:09   ` Junxiao Bi
2020-02-13 22:09     ` [Cluster-devel] " Junxiao Bi
2020-02-13 22:09     ` Junxiao Bi
2020-02-13 22:09     ` [f2fs-dev] " Junxiao Bi
2020-02-13 22:09     ` [Ocfs2-devel] " Junxiao Bi
2020-02-11  1:03 ` [PATCH v5 07/13] btrfs: Convert from readpages to readahead Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 08/13] erofs: Convert uncompressed files " Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 09/13] erofs: Convert compressed " Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 10/13] ext4: Convert " Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 11/13] f2fs: " Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 12/13] fuse: " Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox
2020-02-11  1:03 ` [PATCH v5 13/13] iomap: " Matthew Wilcox
2020-02-11  1:03   ` [Cluster-devel] " Matthew Wilcox
2020-02-11  1:03   ` Matthew Wilcox
2020-02-11  1:03   ` [f2fs-dev] " Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211010348.6872-3-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=cluster-devel@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.