All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Hirte <johannes.hirte@datenkhaos.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Doug Gilbert" <dgilbert@interlog.com>,
	"Kai Mäkisara" <Kai.Makisara@kolumbus.fi>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Dongli Zhang" <dongli.zhang@oracle.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Bart Van Assche" <bvanassche@acm.org>,
	"Hannes Reinecke" <hare@suse.com>,
	"Damien Le Moal" <damien.lemoal@wdc.com>,
	"John Garry" <john.garry@huawei.com>,
	"Martin Wilck" <mwilck@suse.com>,
	"Heiko Carstens" <heiko.carstens@de.ibm.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	"Iustin Pop" <iustin@k1024.org>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	virtualization@lists.linux-foundation.org,
	linux-block <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	"Linux FS-devel Mailing List" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v3 13/22] compat_ioctl: scsi: move ioctl handling into drivers
Date: Thu, 13 Feb 2020 07:53:21 +0100	[thread overview]
Message-ID: <20200213065321.GA8696@latitude> (raw)
In-Reply-To: <CAK8P3a0oPpMC8367sEs+9Ae=wFH30BHAq+aRDbWLyeVLuNOnEw@mail.gmail.com>

On 2020 Feb 12, Arnd Bergmann wrote:
> On Wed, Feb 12, 2020 at 10:15 PM Johannes Hirte
> <johannes.hirte@datenkhaos.de> wrote:
> >
> > On 2020 Jan 02, Arnd Bergmann wrote:
> 
> >
> > Error in getting drive hardware properties
> > Error in getting drive reading properties
> > Error in getting drive writing properties
> > __________________________________
> >
> > Disc mode is listed as: CD-DA
> > ++ WARN: error in ioctl CDROMREADTOCHDR: Bad address
> >
> > cd-info: Can't get first track number. I give up.
> 
> Right, there was also a report about breaking the Fedora installer,
> see https://bugzilla.redhat.com/show_bug.cgi?id=1801353
> 
> There is a preliminary patch that should fix this, I'll post a
> version with more references tomorrow:
> https://www.happyassassin.net/temp/0001-Replace-.ioctl-with-.compat_ioctl-in-three-appropria.patch

Yes, I can confirm that the patch fix it.

-- 
Regards,
  Johannes Hirte


WARNING: multiple messages have this Message-ID (diff)
From: Johannes Hirte <johannes.hirte@datenkhaos.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Jens Axboe" <axboe@kernel.dk>,
	"Doug Gilbert" <dgilbert@interlog.com>,
	"Kai Mäkisara" <Kai.Makisara@kolumbus.fi>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Dongli Zhang" <dongli.zhang@oracle.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Bart Van Assche" <bvanassche@acm.org>,
	"Hannes Reinecke" <hare@suse.com>,
	"Damien Le Moal" <damien.lemoal@wdc.com>,
	"John Garry" <john.garry@huawei.com>,
	"Martin Wilck" <mwilck@suse.com>,
	"Heiko Carstens" <heiko.carstens@de.ibm.com>,
	"Gustavo A. R. Silva" <gustavo@embedded>
Subject: Re: [PATCH v3 13/22] compat_ioctl: scsi: move ioctl handling into drivers
Date: Thu, 13 Feb 2020 07:53:21 +0100	[thread overview]
Message-ID: <20200213065321.GA8696@latitude> (raw)
In-Reply-To: <CAK8P3a0oPpMC8367sEs+9Ae=wFH30BHAq+aRDbWLyeVLuNOnEw@mail.gmail.com>

On 2020 Feb 12, Arnd Bergmann wrote:
> On Wed, Feb 12, 2020 at 10:15 PM Johannes Hirte
> <johannes.hirte@datenkhaos.de> wrote:
> >
> > On 2020 Jan 02, Arnd Bergmann wrote:
> 
> >
> > Error in getting drive hardware properties
> > Error in getting drive reading properties
> > Error in getting drive writing properties
> > __________________________________
> >
> > Disc mode is listed as: CD-DA
> > ++ WARN: error in ioctl CDROMREADTOCHDR: Bad address
> >
> > cd-info: Can't get first track number. I give up.
> 
> Right, there was also a report about breaking the Fedora installer,
> see https://bugzilla.redhat.com/show_bug.cgi?id=1801353
> 
> There is a preliminary patch that should fix this, I'll post a
> version with more references tomorrow:
> https://www.happyassassin.net/temp/0001-Replace-.ioctl-with-.compat_ioctl-in-three-appropria.patch

Yes, I can confirm that the patch fix it.

-- 
Regards,
  Johannes Hirte

  reply	other threads:[~2020-02-13  6:53 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02 14:55 [GIT PULL v3 00/27] block, scsi: final compat_ioctl cleanup Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 01/22] compat: ARM64: always include asm-generic/compat.h Arnd Bergmann
2020-01-02 14:55   ` Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 02/22] compat: provide compat_ptr() on all architectures Arnd Bergmann
2020-01-02 14:55   ` Arnd Bergmann
2020-01-02 14:55   ` Arnd Bergmann
2020-01-06 17:40   ` Will Deacon
2020-01-06 17:40     ` Will Deacon
2020-01-06 17:40     ` Will Deacon
2020-01-06 17:59   ` H. Peter Anvin
2020-01-06 17:59     ` H. Peter Anvin
2020-01-06 17:59     ` H. Peter Anvin
2020-01-07  2:05   ` Michael Ellerman
2020-01-07  2:05     ` Michael Ellerman
2020-01-07  2:05     ` Michael Ellerman
2020-01-07  2:05     ` Michael Ellerman
2020-01-07  8:08     ` Arnd Bergmann
2020-01-07  8:08       ` Arnd Bergmann
2020-01-07  8:08       ` Arnd Bergmann
2020-01-07  8:19       ` H. Peter Anvin
2020-01-07  8:19         ` H. Peter Anvin
2020-01-07  8:19         ` H. Peter Anvin
2020-01-07  8:40         ` Arnd Bergmann
2020-01-07 17:51   ` Heiko Carstens
2020-01-07 17:51     ` Heiko Carstens
2020-01-07 17:51     ` Heiko Carstens
2020-01-02 14:55 ` [PATCH v3 03/22] compat: scsi: sg: fix v3 compat read/write interface Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 04/22] compat_ioctl: block: add blkdev_compat_ptr_ioctl Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 05/22] compat_ioctl: ubd, aoe: use blkdev_compat_ptr_ioctl Arnd Bergmann
2020-01-02 14:55   ` Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 06/22] compat_ioctl: move CDROM_SEND_PACKET handling into scsi Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 07/22] compat_ioctl: move CDROMREADADIO to cdrom.c Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 08/22] compat_ioctl: cdrom: handle CDROM_LAST_WRITTEN Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 09/22] compat_ioctl: block: handle cdrom compat ioctl in non-cdrom drivers Arnd Bergmann
2020-01-02 14:55   ` [Xen-devel] " Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 10/22] compat_ioctl: add scsi_compat_ioctl Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 11/22] compat_ioctl: bsg: add handler Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 12/22] compat_ioctl: ide: floppy: " Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 13/22] compat_ioctl: scsi: move ioctl handling into drivers Arnd Bergmann
2020-01-02 16:33   ` Stefan Hajnoczi
2020-01-02 16:33   ` Stefan Hajnoczi
2020-02-12 21:14   ` Johannes Hirte
2020-02-12 21:14     ` Johannes Hirte
2020-02-12 21:49     ` Arnd Bergmann
2020-02-12 21:49       ` Arnd Bergmann
2020-02-13  6:53       ` Johannes Hirte [this message]
2020-02-13  6:53         ` Johannes Hirte
2020-01-02 14:55 ` Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 14/22] compat_ioctl: move sys_compat_ioctl() to ioctl.c Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 15/22] compat_ioctl: simplify the implementation Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 16/22] compat_ioctl: move cdrom commands into cdrom.c Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 17/22] compat_ioctl: scsi: handle HDIO commands from drivers Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 18/22] compat_ioctl: move HDIO ioctl handling into drivers/ide Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 19/22] compat_ioctl: block: move blkdev_compat_ioctl() into ioctl.c Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 20/22] compat_ioctl: block: simplify compat_blkpg_ioctl() Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 21/22] compat_ioctl: simplify up block/ioctl.c Arnd Bergmann
2020-01-02 14:55 ` [PATCH v3 22/22] Documentation: document ioctl interfaces better Arnd Bergmann
2020-01-02 20:22 ` [GIT PULL v3 00/27] block, scsi: final compat_ioctl cleanup Arnd Bergmann
2020-01-03  0:22 ` Ben Hutchings
2020-01-03  8:56   ` Arnd Bergmann
2020-01-03  3:02 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213065321.GA8696@latitude \
    --to=johannes.hirte@datenkhaos.de \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@wdc.com \
    --cc=darrick.wong@oracle.com \
    --cc=dgilbert@interlog.com \
    --cc=dongli.zhang@oracle.com \
    --cc=gustavo@embeddedor.com \
    --cc=hare@suse.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=ira.weiny@intel.com \
    --cc=iustin@k1024.org \
    --cc=jasowang@redhat.com \
    --cc=jejb@linux.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mst@redhat.com \
    --cc=mwilck@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.