From: kbuild test robot <lkp@intel.com> To: yu kuai <yukuai3@huawei.com> Cc: kbuild-all@lists.01.org, axboe@kernel.dk, ming.lei@redhat.com, yukuai3@huawei.com, yi.zhang@huawei.com, zhangxiaoxu5@huawei.com, luoshijie1@huawei.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: rename 'q->debugfs_dir' in blk_unregister_queue() Date: Thu, 13 Feb 2020 12:38:02 +0800 [thread overview] Message-ID: <202002131252.CCCKxfBv%lkp@intel.com> (raw) In-Reply-To: <20200211035137.19454-1-yukuai3@huawei.com> [-- Attachment #1: Type: text/plain, Size: 3201 bytes --] Hi yu, Thank you for the patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on v5.6-rc1 next-20200212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/yu-kuai/block-rename-q-debugfs_dir-in-blk_unregister_queue/20200213-091022 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: um-x86_64_defconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-4) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=um SUBARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All errors (new ones prefixed by >>): block/blk-sysfs.c: In function 'blk_prepare_release_queue': >> block/blk-sysfs.c:1030:22: error: 'struct request_queue' has no member named 'debugfs_dir' if (IS_ERR_OR_NULL(q->debugfs_dir)) ^~ block/blk-sysfs.c:1031:11: error: 'struct request_queue' has no member named 'debugfs_dir' return q->debugfs_dir; ^~ >> block/blk-sysfs.c:1035:24: error: 'blk_debugfs_root' undeclared (first use in this function); did you mean 'blk_mq_debugfs_attr'? new = debugfs_rename(blk_debugfs_root, q->debugfs_dir, ^~~~~~~~~~~~~~~~ blk_mq_debugfs_attr block/blk-sysfs.c:1035:24: note: each undeclared identifier is reported only once for each function it appears in block/blk-sysfs.c:1035:43: error: 'struct request_queue' has no member named 'debugfs_dir' new = debugfs_rename(blk_debugfs_root, q->debugfs_dir, ^~ block/blk-sysfs.c: In function 'blk_unregister_queue': block/blk-sysfs.c:1070:3: error: 'struct request_queue' has no member named 'debugfs_dir' q->debugfs_dir = blk_prepare_release_queue(q); ^~ vim +1030 block/blk-sysfs.c 1014 1015 /* 1016 * blk_prepare_release_queue - rename q->debugfs_dir 1017 * @q: request_queue of which the dir to be renamed belong to. 1018 * 1019 * Because the final release of request_queue is in a workqueue, the 1020 * cleanup might not been finished yet while the same device start to 1021 * create. It's not correct if q->debugfs_dir still exist while trying 1022 * to create a new one. 1023 */ 1024 static struct dentry *blk_prepare_release_queue(struct request_queue *q) 1025 { 1026 struct dentry *new = NULL; 1027 char name[DNAME_INLINE_LEN]; 1028 int i = 0; 1029 > 1030 if (IS_ERR_OR_NULL(q->debugfs_dir)) 1031 return q->debugfs_dir; 1032 1033 while (new == NULL) { 1034 sprintf(name, "ready_to_remove_%d", i++); > 1035 new = debugfs_rename(blk_debugfs_root, q->debugfs_dir, 1036 blk_debugfs_root, name); 1037 } 1038 1039 return new; 1040 } 1041 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 8477 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH] block: rename 'q->debugfs_dir' in blk_unregister_queue() Date: Thu, 13 Feb 2020 12:38:02 +0800 [thread overview] Message-ID: <202002131252.CCCKxfBv%lkp@intel.com> (raw) In-Reply-To: <20200211035137.19454-1-yukuai3@huawei.com> [-- Attachment #1: Type: text/plain, Size: 3280 bytes --] Hi yu, Thank you for the patch! Yet something to improve: [auto build test ERROR on block/for-next] [also build test ERROR on v5.6-rc1 next-20200212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/yu-kuai/block-rename-q-debugfs_dir-in-blk_unregister_queue/20200213-091022 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: um-x86_64_defconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-4) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=um SUBARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@intel.com> All errors (new ones prefixed by >>): block/blk-sysfs.c: In function 'blk_prepare_release_queue': >> block/blk-sysfs.c:1030:22: error: 'struct request_queue' has no member named 'debugfs_dir' if (IS_ERR_OR_NULL(q->debugfs_dir)) ^~ block/blk-sysfs.c:1031:11: error: 'struct request_queue' has no member named 'debugfs_dir' return q->debugfs_dir; ^~ >> block/blk-sysfs.c:1035:24: error: 'blk_debugfs_root' undeclared (first use in this function); did you mean 'blk_mq_debugfs_attr'? new = debugfs_rename(blk_debugfs_root, q->debugfs_dir, ^~~~~~~~~~~~~~~~ blk_mq_debugfs_attr block/blk-sysfs.c:1035:24: note: each undeclared identifier is reported only once for each function it appears in block/blk-sysfs.c:1035:43: error: 'struct request_queue' has no member named 'debugfs_dir' new = debugfs_rename(blk_debugfs_root, q->debugfs_dir, ^~ block/blk-sysfs.c: In function 'blk_unregister_queue': block/blk-sysfs.c:1070:3: error: 'struct request_queue' has no member named 'debugfs_dir' q->debugfs_dir = blk_prepare_release_queue(q); ^~ vim +1030 block/blk-sysfs.c 1014 1015 /* 1016 * blk_prepare_release_queue - rename q->debugfs_dir 1017 * @q: request_queue of which the dir to be renamed belong to. 1018 * 1019 * Because the final release of request_queue is in a workqueue, the 1020 * cleanup might not been finished yet while the same device start to 1021 * create. It's not correct if q->debugfs_dir still exist while trying 1022 * to create a new one. 1023 */ 1024 static struct dentry *blk_prepare_release_queue(struct request_queue *q) 1025 { 1026 struct dentry *new = NULL; 1027 char name[DNAME_INLINE_LEN]; 1028 int i = 0; 1029 > 1030 if (IS_ERR_OR_NULL(q->debugfs_dir)) 1031 return q->debugfs_dir; 1032 1033 while (new == NULL) { 1034 sprintf(name, "ready_to_remove_%d", i++); > 1035 new = debugfs_rename(blk_debugfs_root, q->debugfs_dir, 1036 blk_debugfs_root, name); 1037 } 1038 1039 return new; 1040 } 1041 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 8477 bytes --]
next prev parent reply other threads:[~2020-02-13 4:38 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-11 3:51 [PATCH] block: rename 'q->debugfs_dir' in blk_unregister_queue() yu kuai 2020-02-12 3:27 ` Bart Van Assche 2020-02-12 4:20 ` yukuai (C) 2020-02-13 4:38 ` kbuild test robot [this message] 2020-02-13 4:38 ` kbuild test robot 2020-02-13 11:39 ` kbuild test robot 2020-02-13 11:39 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202002131252.CCCKxfBv%lkp@intel.com \ --to=lkp@intel.com \ --cc=axboe@kernel.dk \ --cc=kbuild-all@lists.01.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luoshijie1@huawei.com \ --cc=ming.lei@redhat.com \ --cc=yi.zhang@huawei.com \ --cc=yukuai3@huawei.com \ --cc=zhangxiaoxu5@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.