All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 00/11] mmc: sdhci: code clean-up and fix cache coherency problem
Date: Fri, 14 Feb 2020 16:40:16 +0900	[thread overview]
Message-ID: <20200214074027.19824-1-yamada.masahiro@socionext.com> (raw)

My main motivation of this series is the last patch
"mmc: sdhci: fix missing cache invalidation after reading by DMA".

Currently, read data are occasionally corrupted due to the
missing cache invalidation.

To fix it nicely (adds dma_unmap_single(), which follows the
Linux coding style), I did some cleaups first.

Patch 01-04 tidies up the DMA helpers.

Patch 05-10 are code clean-ups.

Patch 11 fixes the bug.


Masahiro Yamada (11):
  dma-mapping: fix the prototype of dma_map_single()
  dma-mapping: fix the prototype of dma_unmap_single()
  dma-mapping: move dma_map_(un)single() to <linux/dma-mapping.h>
  dma-mapping: add <asm/dma-mapping.h> for all architectures
  mmc: sdhci: put the aligned buffer pointer to struct sdhci_host
  mmc: sdhci: reduce code duplication for aligned buffer
  mmc: sdhci: use lower_32_bit2() and upper_32_bits() for setting
    adma_addr
  mmc: sdhci: remove unneeded casts
  mmc: add mmc_get_dma_dir() helper
  mmc: sdhci: use dma_map_single() instead of flush_cache() before DMA
  mmc: sdhci: fix missing cache invalidation after reading by DMA

 arch/arc/include/asm/dma-mapping.h        |  1 +
 arch/arm/include/asm/dma-mapping.h        | 29 +------
 arch/m68k/include/asm/dma-mapping.h       |  1 +
 arch/microblaze/include/asm/dma-mapping.h |  1 +
 arch/mips/include/asm/dma-mapping.h       |  1 +
 arch/nds32/include/asm/dma-mapping.h      | 27 +------
 arch/nios2/include/asm/dma-mapping.h      | 25 +-----
 arch/powerpc/include/asm/dma-mapping.h    |  1 +
 arch/riscv/include/asm/dma-mapping.h      | 29 +------
 arch/sandbox/include/asm/dma-mapping.h    |  1 +
 arch/sh/include/asm/dma-mapping.h         |  1 +
 arch/x86/include/asm/dma-mapping.h        | 29 +------
 arch/xtensa/include/asm/dma-mapping.h     |  1 +
 drivers/dma/ti/k3-udma.c                  |  2 +-
 drivers/mmc/sdhci.c                       | 96 +++++++++++------------
 drivers/mmc/tmio-common.c                 |  5 +-
 drivers/mtd/nand/raw/denali.c             |  5 +-
 drivers/net/altera_tse.c                  |  2 +-
 drivers/net/ftmac110.c                    |  2 +-
 drivers/net/macb.c                        |  4 +-
 drivers/soc/ti/k3-navss-ringacc.c         |  2 +-
 drivers/ufs/ufs.c                         |  2 +-
 drivers/usb/cdns3/gadget.c                |  2 +-
 drivers/usb/dwc3/core.c                   |  8 +-
 drivers/usb/dwc3/gadget.c                 |  2 +-
 drivers/usb/gadget/udc/udc-core.c         |  4 +-
 include/linux/dma-mapping.h               | 63 +++++++++++++++
 include/mmc.h                             |  6 ++
 include/sdhci.h                           |  3 +
 29 files changed, 150 insertions(+), 205 deletions(-)
 create mode 100644 arch/arc/include/asm/dma-mapping.h
 create mode 100644 arch/m68k/include/asm/dma-mapping.h
 create mode 100644 arch/microblaze/include/asm/dma-mapping.h
 create mode 100644 arch/mips/include/asm/dma-mapping.h
 create mode 100644 arch/powerpc/include/asm/dma-mapping.h
 create mode 100644 arch/sandbox/include/asm/dma-mapping.h
 create mode 100644 arch/sh/include/asm/dma-mapping.h
 create mode 100644 arch/xtensa/include/asm/dma-mapping.h
 create mode 100644 include/linux/dma-mapping.h

-- 
2.17.1

             reply	other threads:[~2020-02-14  7:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  7:40 Masahiro Yamada [this message]
2020-02-14  7:40 ` [PATCH v3 01/11] dma-mapping: fix the prototype of dma_map_single() Masahiro Yamada
2020-02-14  7:40 ` [PATCH v3 02/11] dma-mapping: fix the prototype of dma_unmap_single() Masahiro Yamada
2020-02-14  7:40 ` [PATCH v3 03/11] dma-mapping: move dma_map_(un)single() to <linux/dma-mapping.h> Masahiro Yamada
2020-02-14  7:40 ` [PATCH v3 04/11] dma-mapping: add <asm/dma-mapping.h> for all architectures Masahiro Yamada
2020-02-14  7:40 ` [PATCH v3 05/11] mmc: sdhci: put the aligned buffer pointer to struct sdhci_host Masahiro Yamada
2020-02-18 11:19   ` Jaehoon Chung
2020-02-14  7:40 ` [PATCH v3 06/11] mmc: sdhci: reduce code duplication for aligned buffer Masahiro Yamada
2020-02-18 11:19   ` Jaehoon Chung
2020-02-14  7:40 ` [PATCH v3 07/11] mmc: sdhci: use lower_32_bit2() and upper_32_bits() for setting adma_addr Masahiro Yamada
2020-02-18 11:19   ` Jaehoon Chung
2020-02-14  7:40 ` [PATCH v3 08/11] mmc: sdhci: remove unneeded casts Masahiro Yamada
2020-02-18 11:20   ` Jaehoon Chung
2020-02-14  7:40 ` [PATCH v3 09/11] mmc: add mmc_get_dma_dir() helper Masahiro Yamada
2020-02-18 11:20   ` Jaehoon Chung
2020-02-14  7:40 ` [PATCH v3 10/11] mmc: sdhci: use dma_map_single() instead of flush_cache() before DMA Masahiro Yamada
2020-02-14  7:40 ` [PATCH v3 11/11] mmc: sdhci: fix missing cache invalidation after reading by DMA Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214074027.19824-1-yamada.masahiro@socionext.com \
    --to=yamada.masahiro@socionext.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.