From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [PATCH v3 08/11] mmc: sdhci: remove unneeded casts
Date: Tue, 18 Feb 2020 20:20:14 +0900 [thread overview]
Message-ID: <51fbc41c-e818-bb99-bb27-cb505d0ea575@samsung.com> (raw)
In-Reply-To: <20200214074027.19824-9-yamada.masahiro@socionext.com>
On 2/14/20 4:40 PM, Masahiro Yamada wrote:
> host->mmc is already (struct mmc *).
>
> memalign() returns an opaque pointer, so there is no need for casting.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> drivers/mmc/sdhci.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
> index fefe81016eb1..ee54d78a28f2 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -522,7 +522,7 @@ static void sdhci_set_power(struct sdhci_host *host, unsigned short power)
>
> void sdhci_set_uhs_timing(struct sdhci_host *host)
> {
> - struct mmc *mmc = (struct mmc *)host->mmc;
> + struct mmc *mmc = host->mmc;
> u32 reg;
>
> reg = sdhci_readw(host, SDHCI_HOST_CONTROL2);
> @@ -735,8 +735,7 @@ int sdhci_setup_cfg(struct mmc_config *cfg, struct sdhci_host *host,
> __func__);
> return -EINVAL;
> }
> - host->adma_desc_table = (struct sdhci_adma_desc *)
> - memalign(ARCH_DMA_MINALIGN, ADMA_TABLE_SZ);
> + host->adma_desc_table = memalign(ARCH_DMA_MINALIGN, ADMA_TABLE_SZ);
>
> host->adma_addr = (dma_addr_t)host->adma_desc_table;
> #ifdef CONFIG_DMA_ADDR_T_64BIT
>
next prev parent reply other threads:[~2020-02-18 11:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 7:40 [PATCH v3 00/11] mmc: sdhci: code clean-up and fix cache coherency problem Masahiro Yamada
2020-02-14 7:40 ` [PATCH v3 01/11] dma-mapping: fix the prototype of dma_map_single() Masahiro Yamada
2020-02-14 7:40 ` [PATCH v3 02/11] dma-mapping: fix the prototype of dma_unmap_single() Masahiro Yamada
2020-02-14 7:40 ` [PATCH v3 03/11] dma-mapping: move dma_map_(un)single() to <linux/dma-mapping.h> Masahiro Yamada
2020-02-14 7:40 ` [PATCH v3 04/11] dma-mapping: add <asm/dma-mapping.h> for all architectures Masahiro Yamada
2020-02-14 7:40 ` [PATCH v3 05/11] mmc: sdhci: put the aligned buffer pointer to struct sdhci_host Masahiro Yamada
2020-02-18 11:19 ` Jaehoon Chung
2020-02-14 7:40 ` [PATCH v3 06/11] mmc: sdhci: reduce code duplication for aligned buffer Masahiro Yamada
2020-02-18 11:19 ` Jaehoon Chung
2020-02-14 7:40 ` [PATCH v3 07/11] mmc: sdhci: use lower_32_bit2() and upper_32_bits() for setting adma_addr Masahiro Yamada
2020-02-18 11:19 ` Jaehoon Chung
2020-02-14 7:40 ` [PATCH v3 08/11] mmc: sdhci: remove unneeded casts Masahiro Yamada
2020-02-18 11:20 ` Jaehoon Chung [this message]
2020-02-14 7:40 ` [PATCH v3 09/11] mmc: add mmc_get_dma_dir() helper Masahiro Yamada
2020-02-18 11:20 ` Jaehoon Chung
2020-02-14 7:40 ` [PATCH v3 10/11] mmc: sdhci: use dma_map_single() instead of flush_cache() before DMA Masahiro Yamada
2020-02-14 7:40 ` [PATCH v3 11/11] mmc: sdhci: fix missing cache invalidation after reading by DMA Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51fbc41c-e818-bb99-bb27-cb505d0ea575@samsung.com \
--to=jh80.chung@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.