All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -net] skbuff: remove stale bit mask comments
@ 2020-02-15 21:41 Randy Dunlap
  2020-02-17  3:50 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-02-15 21:41 UTC (permalink / raw)
  To: netdev, David Miller

From: Randy Dunlap <rdunlap@infradead.org>

Remove stale comments since this flag is no longer a bit mask
but is a bit field.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 net/core/skbuff.c |    2 --
 1 file changed, 2 deletions(-)

--- lnx-56-rc1.orig/net/core/skbuff.c
+++ lnx-56-rc1/net/core/skbuff.c
@@ -467,7 +467,6 @@ struct sk_buff *__netdev_alloc_skb(struc
 		return NULL;
 	}
 
-	/* use OR instead of assignment to avoid clearing of bits in mask */
 	if (pfmemalloc)
 		skb->pfmemalloc = 1;
 	skb->head_frag = 1;
@@ -527,7 +526,6 @@ struct sk_buff *__napi_alloc_skb(struct
 		return NULL;
 	}
 
-	/* use OR instead of assignment to avoid clearing of bits in mask */
 	if (nc->page.pfmemalloc)
 		skb->pfmemalloc = 1;
 	skb->head_frag = 1;



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -net] skbuff: remove stale bit mask comments
  2020-02-15 21:41 [PATCH -net] skbuff: remove stale bit mask comments Randy Dunlap
@ 2020-02-17  3:50 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-02-17  3:50 UTC (permalink / raw)
  To: rdunlap; +Cc: netdev

From: Randy Dunlap <rdunlap@infradead.org>
Date: Sat, 15 Feb 2020 13:41:12 -0800

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Remove stale comments since this flag is no longer a bit mask
> but is a bit field.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-17  3:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-15 21:41 [PATCH -net] skbuff: remove stale bit mask comments Randy Dunlap
2020-02-17  3:50 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.