All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: phy: allow bcm84881 to be a module
@ 2020-02-17 16:03 Russell King
  2020-02-17 16:03 ` Florian Fainelli
  2020-02-17 23:17 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Russell King @ 2020-02-17 16:03 UTC (permalink / raw)
  To: Andrew Lunn, Florian Fainelli, Heiner Kallweit; +Cc: David S. Miller, netdev

Now that the phylib module loading issue has been resolved, we can
allow this PHY driver to be built as a module.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---

This is a result of:

7d49a32a66d2 ("net: phy: ensure that phy IDs are correctly typed")
d2ed49cf6c13 ("mod_devicetable: fix PHY module format")

merged during the last cycle. Given that the bcm84881 driver is so
new, I'm not sure whether it's really important enough for -rc and
backporting to 5.5-stable or just queue it in net-next. My feeling
is that it's fairly low priority, and not important enough to
justify backporting to 5.5-stable unless someone really wants this
PHY driver to be modular. Therefore, I'm opting for net-next for
this posting.

 drivers/net/phy/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 9dabe03a668c..edb1cb8a228e 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -326,8 +326,8 @@ config BROADCOM_PHY
 	  BCM5481, BCM54810 and BCM5482 PHYs.
 
 config BCM84881_PHY
-	bool "Broadcom BCM84881 PHY"
-	depends on PHYLIB=y
+	tristate "Broadcom BCM84881 PHY"
+	depends on PHYLIB
 	---help---
 	  Support the Broadcom BCM84881 PHY.
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: phy: allow bcm84881 to be a module
  2020-02-17 16:03 [PATCH net-next] net: phy: allow bcm84881 to be a module Russell King
@ 2020-02-17 16:03 ` Florian Fainelli
  2020-02-17 23:17 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-02-17 16:03 UTC (permalink / raw)
  To: Russell King, Andrew Lunn, Heiner Kallweit; +Cc: David S. Miller, netdev



On 2/17/2020 8:03 AM, Russell King wrote:
> Now that the phylib module loading issue has been resolved, we can
> allow this PHY driver to be built as a module.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: phy: allow bcm84881 to be a module
  2020-02-17 16:03 [PATCH net-next] net: phy: allow bcm84881 to be a module Russell King
  2020-02-17 16:03 ` Florian Fainelli
@ 2020-02-17 23:17 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-02-17 23:17 UTC (permalink / raw)
  To: rmk+kernel; +Cc: andrew, f.fainelli, hkallweit1, netdev

From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Mon, 17 Feb 2020 16:03:11 +0000

> Now that the phylib module loading issue has been resolved, we can
> allow this PHY driver to be built as a module.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-17 23:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 16:03 [PATCH net-next] net: phy: allow bcm84881 to be a module Russell King
2020-02-17 16:03 ` Florian Fainelli
2020-02-17 23:17 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.