All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] selftests: forwarding: vxlan_bridge_1d: use more proper tos value
@ 2020-02-17  3:43 Hangbin Liu
  2020-02-18  6:41 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Hangbin Liu @ 2020-02-17  3:43 UTC (permalink / raw)
  To: netdev; +Cc: Petr Machata, David Miller, Hangbin Liu

0x11 and 0x12 set the ECN bits based on RFC2474, it would be better to avoid
that. 0x14 and 0x18 would be better and works as well.

Reported-by: Petr Machata <petrm@mellanox.com>
Fixes: 4e867c9a50ff ("selftests: forwarding: vxlan_bridge_1d: fix tos value")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh b/tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh
index 353613fc1947..ce6bea9675c0 100755
--- a/tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh
+++ b/tools/testing/selftests/net/forwarding/vxlan_bridge_1d.sh
@@ -516,9 +516,9 @@ test_tos()
 	RET=0
 
 	tc filter add dev v1 egress pref 77 prot ip \
-		flower ip_tos 0x11 action pass
-	vxlan_ping_test $h1 192.0.2.3 "-Q 0x11" v1 egress 77 10
-	vxlan_ping_test $h1 192.0.2.3 "-Q 0x12" v1 egress 77 0
+		flower ip_tos 0x14 action pass
+	vxlan_ping_test $h1 192.0.2.3 "-Q 0x14" v1 egress 77 10
+	vxlan_ping_test $h1 192.0.2.3 "-Q 0x18" v1 egress 77 0
 	tc filter del dev v1 egress pref 77 prot ip
 
 	log_test "VXLAN: envelope TOS inheritance"
-- 
2.19.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] selftests: forwarding: vxlan_bridge_1d: use more proper tos value
  2020-02-17  3:43 [PATCH net] selftests: forwarding: vxlan_bridge_1d: use more proper tos value Hangbin Liu
@ 2020-02-18  6:41 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-02-18  6:41 UTC (permalink / raw)
  To: liuhangbin; +Cc: netdev, petrm

From: Hangbin Liu <liuhangbin@gmail.com>
Date: Mon, 17 Feb 2020 11:43:15 +0800

> 0x11 and 0x12 set the ECN bits based on RFC2474, it would be better to avoid
> that. 0x14 and 0x18 would be better and works as well.
> 
> Reported-by: Petr Machata <petrm@mellanox.com>
> Fixes: 4e867c9a50ff ("selftests: forwarding: vxlan_bridge_1d: fix tos value")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Applied, thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-18  6:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17  3:43 [PATCH net] selftests: forwarding: vxlan_bridge_1d: use more proper tos value Hangbin Liu
2020-02-18  6:41 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.