From: Joerg Roedel <joro@8bytes.org> To: Lu Baolu <baolu.lu@linux.intel.com>, David Woodhouse <dwmw2@infradead.org> Cc: Joerg Roedel <joro@8bytes.org>, jroedel@suse.de, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/5] iommu/vt-d: Fix kdump boot with VT-d enabled Date: Mon, 17 Feb 2020 20:38:53 +0100 [thread overview] Message-ID: <20200217193858.26990-1-joro@8bytes.org> (raw) Hi, booting into a crashdump kernel with Intel IOMMU enabled and configured into passthrough mode does not succeed with the current kernel. The reason is that the check for identity mappings happen before the check for deferred device attachments. That results in wrong results returned from iommu_need_mapping() and subsequently in a wrong domain-type used in __intel_map_single(). A stripped oops is in the commit-message of patch 3. The patch-set fixes the issue and does a few code cleanups along the way. I have not yet researched the stable and fixes tags, but when the patches are fine I will add the tags before applying the patches. Please review. Thanks, Joerg Joerg Roedel (5): iommu/vt-d: Add attach_deferred() helper iommu/vt-d: Move deferred device attachment into helper function iommu/vt-d: Do deferred attachment in iommu_need_mapping() iommu/vt-d: Remove deferred_attach_domain() iommu/vt-d: Simplify check in identity_mapping() drivers/iommu/intel-iommu.c | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org> To: Lu Baolu <baolu.lu@linux.intel.com>, David Woodhouse <dwmw2@infradead.org> Cc: jroedel@suse.de, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/5] iommu/vt-d: Fix kdump boot with VT-d enabled Date: Mon, 17 Feb 2020 20:38:53 +0100 [thread overview] Message-ID: <20200217193858.26990-1-joro@8bytes.org> (raw) Hi, booting into a crashdump kernel with Intel IOMMU enabled and configured into passthrough mode does not succeed with the current kernel. The reason is that the check for identity mappings happen before the check for deferred device attachments. That results in wrong results returned from iommu_need_mapping() and subsequently in a wrong domain-type used in __intel_map_single(). A stripped oops is in the commit-message of patch 3. The patch-set fixes the issue and does a few code cleanups along the way. I have not yet researched the stable and fixes tags, but when the patches are fine I will add the tags before applying the patches. Please review. Thanks, Joerg Joerg Roedel (5): iommu/vt-d: Add attach_deferred() helper iommu/vt-d: Move deferred device attachment into helper function iommu/vt-d: Do deferred attachment in iommu_need_mapping() iommu/vt-d: Remove deferred_attach_domain() iommu/vt-d: Simplify check in identity_mapping() drivers/iommu/intel-iommu.c | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) -- 2.17.1 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next reply other threads:[~2020-02-17 19:39 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-17 19:38 Joerg Roedel [this message] 2020-02-17 19:38 ` [PATCH 0/5] iommu/vt-d: Fix kdump boot with VT-d enabled Joerg Roedel 2020-02-17 19:38 ` [PATCH 1/5] iommu/vt-d: Add attach_deferred() helper Joerg Roedel 2020-02-17 19:38 ` Joerg Roedel 2020-02-17 19:50 ` Jerry Snitselaar 2020-02-17 19:50 ` Jerry Snitselaar 2020-02-18 17:14 ` Christoph Hellwig 2020-02-18 17:14 ` Christoph Hellwig 2020-02-19 9:29 ` Joerg Roedel 2020-02-19 9:29 ` Joerg Roedel 2020-02-17 19:38 ` [PATCH 2/5] iommu/vt-d: Move deferred device attachment into helper function Joerg Roedel 2020-02-17 19:38 ` Joerg Roedel 2020-02-17 19:50 ` Jerry Snitselaar 2020-02-17 19:50 ` Jerry Snitselaar 2020-02-18 17:16 ` Christoph Hellwig 2020-02-18 17:16 ` Christoph Hellwig 2020-02-17 19:38 ` [PATCH 3/5] iommu/vt-d: Do deferred attachment in iommu_need_mapping() Joerg Roedel 2020-02-17 19:38 ` Joerg Roedel 2020-02-17 19:51 ` Jerry Snitselaar 2020-02-17 19:51 ` Jerry Snitselaar 2020-02-18 2:38 ` Lu Baolu 2020-02-18 2:38 ` Lu Baolu 2020-02-18 9:28 ` [PATCH 3/5 v2] " Joerg Roedel 2020-02-18 9:28 ` Joerg Roedel 2020-02-18 11:54 ` Lu Baolu 2020-02-18 11:54 ` Lu Baolu 2020-02-18 16:22 ` Joerg Roedel 2020-02-18 16:22 ` Joerg Roedel 2020-02-18 15:53 ` Jerry Snitselaar 2020-02-18 15:53 ` Jerry Snitselaar 2020-02-17 19:38 ` [PATCH 4/5] iommu/vt-d: Remove deferred_attach_domain() Joerg Roedel 2020-02-17 19:38 ` Joerg Roedel 2020-02-17 19:51 ` Jerry Snitselaar 2020-02-17 19:51 ` Jerry Snitselaar 2020-02-17 19:38 ` [PATCH 5/5] iommu/vt-d: Simplify check in identity_mapping() Joerg Roedel 2020-02-17 19:38 ` Joerg Roedel 2020-02-17 19:54 ` Jerry Snitselaar 2020-02-17 19:54 ` Jerry Snitselaar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200217193858.26990-1-joro@8bytes.org \ --to=joro@8bytes.org \ --cc=baolu.lu@linux.intel.com \ --cc=dwmw2@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jroedel@suse.de \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.