All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Tony Lindgren <tony@atomide.com>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com,
	mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz,
	agx@sigxcpu.org, daniel.thompson@linaro.org,
	jingoohan1@gmail.com, dri-devel@lists.freedesktop.org,
	tomi.valkeinen@ti.com, jjhiblot@ti.com
Subject: Re: LED backlight on Droid 4 and others
Date: Tue, 18 Feb 2020 13:52:19 +0000	[thread overview]
Message-ID: <20200218135219.GC3494@dell> (raw)
In-Reply-To: <20200212201638.GB20085@amd>

On Wed, 12 Feb 2020, Pavel Machek wrote:

> Hi!
> 
> > > > It would be good to get LED backlight to work in clean way for 5.6
> > > > kernel.
> > ...
> > > > [If you have an idea what else is needed, it would be welcome; it
> > > > works for me in development tree but not in tree I'd like to
> > > > upstream.]
> > > > 
> > > > Lee, would you be willing to take "backlight: add led-backlight
> > > > driver"? Would it help if I got "leds: Add managed API to get a LED
> > > > from a device driver" and "leds: Add of_led_get() and led_put()" into
> > > > for_next tree of the LED subsystem?
> > > 
> > > It looks like you have an open question from Tony on v10.
> > > 
> > > Is that patch orthogonal, or are there depend{ants,encies}?
> > 
> > Uhh looks like we messed up a bit with integration. Now droid4
> > LCD backlight can no longer be enabled at all manually in v5.6-rc1
> > without the "add led-backlight driver" patch.. Should we just
> > merge it to fix it rather than start scrambling with other
> > temporary hacks?
> 
> We should just merge the "add led-backlight driver". Everything should
> be ready for it. I'm sorry if I broke something working, I was not
> aware it worked at all.
> 
> Unfortunately, this is backlight code, not LED, so I can't just merge it.

Please go ahead.  Apply my Acked-by and merge away ASAP.

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: daniel.thompson@linaro.org, mpartap@gmx.net,
	Tony Lindgren <tony@atomide.com>,
	jingoohan1@gmail.com, merlijn@wizzup.org,
	martin_rysavy@centrum.cz,
	kernel list <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, sre@kernel.org,
	nekit1000@gmail.com, tomi.valkeinen@ti.com, jjhiblot@ti.com,
	linux-omap@vger.kernel.org, agx@sigxcpu.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: LED backlight on Droid 4 and others
Date: Tue, 18 Feb 2020 13:52:19 +0000	[thread overview]
Message-ID: <20200218135219.GC3494@dell> (raw)
In-Reply-To: <20200212201638.GB20085@amd>

On Wed, 12 Feb 2020, Pavel Machek wrote:

> Hi!
> 
> > > > It would be good to get LED backlight to work in clean way for 5.6
> > > > kernel.
> > ...
> > > > [If you have an idea what else is needed, it would be welcome; it
> > > > works for me in development tree but not in tree I'd like to
> > > > upstream.]
> > > > 
> > > > Lee, would you be willing to take "backlight: add led-backlight
> > > > driver"? Would it help if I got "leds: Add managed API to get a LED
> > > > from a device driver" and "leds: Add of_led_get() and led_put()" into
> > > > for_next tree of the LED subsystem?
> > > 
> > > It looks like you have an open question from Tony on v10.
> > > 
> > > Is that patch orthogonal, or are there depend{ants,encies}?
> > 
> > Uhh looks like we messed up a bit with integration. Now droid4
> > LCD backlight can no longer be enabled at all manually in v5.6-rc1
> > without the "add led-backlight driver" patch.. Should we just
> > merge it to fix it rather than start scrambling with other
> > temporary hacks?
> 
> We should just merge the "add led-backlight driver". Everything should
> be ready for it. I'm sorry if I broke something working, I was not
> aware it worked at all.
> 
> Unfortunately, this is backlight code, not LED, so I can't just merge it.

Please go ahead.  Apply my Acked-by and merge away ASAP.

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: daniel.thompson@linaro.org, mpartap@gmx.net,
	Tony Lindgren <tony@atomide.com>,
	jingoohan1@gmail.com, merlijn@wizzup.org,
	martin_rysavy@centrum.cz,
	kernel list <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, sre@kernel.org,
	nekit1000@gmail.com, tomi.valkeinen@ti.com, jjhiblot@ti.com,
	linux-omap@vger.kernel.org, agx@sigxcpu.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: LED backlight on Droid 4 and others
Date: Tue, 18 Feb 2020 13:52:19 +0000	[thread overview]
Message-ID: <20200218135219.GC3494@dell> (raw)
In-Reply-To: <20200212201638.GB20085@amd>

On Wed, 12 Feb 2020, Pavel Machek wrote:

> Hi!
> 
> > > > It would be good to get LED backlight to work in clean way for 5.6
> > > > kernel.
> > ...
> > > > [If you have an idea what else is needed, it would be welcome; it
> > > > works for me in development tree but not in tree I'd like to
> > > > upstream.]
> > > > 
> > > > Lee, would you be willing to take "backlight: add led-backlight
> > > > driver"? Would it help if I got "leds: Add managed API to get a LED
> > > > from a device driver" and "leds: Add of_led_get() and led_put()" into
> > > > for_next tree of the LED subsystem?
> > > 
> > > It looks like you have an open question from Tony on v10.
> > > 
> > > Is that patch orthogonal, or are there depend{ants,encies}?
> > 
> > Uhh looks like we messed up a bit with integration. Now droid4
> > LCD backlight can no longer be enabled at all manually in v5.6-rc1
> > without the "add led-backlight driver" patch.. Should we just
> > merge it to fix it rather than start scrambling with other
> > temporary hacks?
> 
> We should just merge the "add led-backlight driver". Everything should
> be ready for it. I'm sorry if I broke something working, I was not
> aware it worked at all.
> 
> Unfortunately, this is backlight code, not LED, so I can't just merge it.

Please go ahead.  Apply my Acked-by and merge away ASAP.

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-02-18 13:51 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-05 18:32 LED backlight on Droid 4 and others Pavel Machek
2020-01-05 18:32 ` Pavel Machek
2020-01-05 18:32 ` Pavel Machek
2020-01-05 18:32 ` Pavel Machek
2020-01-05 20:24 ` Tony Lindgren
2020-01-05 20:24   ` Tony Lindgren
2020-01-05 20:24   ` Tony Lindgren
2020-01-05 22:18   ` Pavel Machek
2020-01-05 22:18     ` Pavel Machek
2020-01-05 22:18     ` Pavel Machek
2020-01-05 23:55   ` Pavel Machek
2020-01-05 23:55     ` Pavel Machek
2020-01-05 23:55     ` Pavel Machek
2020-01-06  8:45 ` Lee Jones
2020-01-06  8:45   ` Lee Jones
2020-01-06  8:45   ` Lee Jones
2020-02-11 17:29   ` Tony Lindgren
2020-02-11 17:29     ` Tony Lindgren
2020-02-12 20:16     ` Pavel Machek
2020-02-12 20:16       ` Pavel Machek
2020-02-12 20:16       ` Pavel Machek
2020-02-12 20:16       ` Pavel Machek
2020-02-18 13:52       ` Lee Jones [this message]
2020-02-18 13:52         ` Lee Jones
2020-02-18 13:52         ` Lee Jones
2020-02-18 14:14         ` Tony Lindgren
2020-02-18 14:14           ` Tony Lindgren
2020-02-18 14:14           ` Tony Lindgren
2020-02-18 23:10           ` Pavel Machek
2020-02-18 23:10             ` Pavel Machek
2020-02-18 23:10             ` Pavel Machek
2020-02-19  7:47             ` Lee Jones
2020-02-19  7:47               ` Lee Jones
2020-02-19  7:47               ` Lee Jones
2020-02-19 16:19               ` Tony Lindgren
2020-02-19 16:19                 ` Tony Lindgren
2020-02-19 16:19                 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218135219.GC3494@dell \
    --to=lee.jones@linaro.org \
    --cc=agx@sigxcpu.org \
    --cc=daniel.thompson@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=jjhiblot@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=martin_rysavy@centrum.cz \
    --cc=merlijn@wizzup.org \
    --cc=mpartap@gmx.net \
    --cc=nekit1000@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.