From: Vivek Goyal <vgoyal@redhat.com> To: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, hch@infradead.org, dan.j.williams@intel.com Cc: dm-devel@redhat.com Subject: [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len Date: Tue, 18 Feb 2020 16:48:35 -0500 [thread overview] Message-ID: <20200218214841.10076-3-vgoyal@redhat.com> (raw) In-Reply-To: <20200218214841.10076-1-vgoyal@redhat.com> Currently pmem_clear_poison() expects offset and len to be sector aligned. Atleast that seems to be the assumption with which code has been written. It is called only from pmem_do_bvec() which is called only from pmem_rw_page() and pmem_make_request() which will only passe sector aligned offset and len. Soon we want use this function from dax_zero_page_range() code path which can try to zero arbitrary range of memory with-in a page. So update this function to assume that offset and length can be arbitrary and do the necessary alignments as needed. nvdimm_clear_poison() seems to assume offset and len to be aligned to clear_err_unit boundary. But this is currently internal detail and is not exported for others to use. So for now, continue to align offset and length to SECTOR_SIZE boundary. Improving it further and to align it to clear_err_unit boundary is a TODO item for future. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> --- drivers/nvdimm/pmem.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 075b11682192..e72959203253 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -74,14 +74,28 @@ static blk_status_t pmem_clear_poison(struct pmem_device *pmem, sector_t sector; long cleared; blk_status_t rc = BLK_STS_OK; + phys_addr_t start_aligned, end_aligned; + unsigned int len_aligned; - sector = (offset - pmem->data_offset) / 512; + /* + * Callers can pass arbitrary offset and len. But nvdimm_clear_poison() + * expects memory offset and length to meet certain alignment + * restrction (clear_err_unit). Currently nvdimm does not export + * required alignment. So align offset and length to sector boundary + * before passing it to nvdimm_clear_poison(). + */ + start_aligned = ALIGN(offset, SECTOR_SIZE); + end_aligned = ALIGN_DOWN((offset + len), SECTOR_SIZE) - 1; + len_aligned = end_aligned - start_aligned + 1; + + sector = (start_aligned - pmem->data_offset) / 512; - cleared = nvdimm_clear_poison(dev, pmem->phys_addr + offset, len); - if (cleared < len) + cleared = nvdimm_clear_poison(dev, pmem->phys_addr + start_aligned, + len_aligned); + if (cleared < len_aligned) rc = BLK_STS_IOERR; if (cleared > 0 && cleared / 512) { - hwpoison_clear(pmem, pmem->phys_addr + offset, cleared); + hwpoison_clear(pmem, pmem->phys_addr + start_aligned, cleared); cleared /= 512; dev_dbg(dev, "%#llx clear %ld sector%s\n", (unsigned long long) sector, cleared, -- 2.20.1 _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com> To: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, hch@infradead.org, dan.j.williams@intel.com Cc: dm-devel@redhat.com, vishal.l.verma@intel.com, vgoyal@redhat.com Subject: [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len Date: Tue, 18 Feb 2020 16:48:35 -0500 [thread overview] Message-ID: <20200218214841.10076-3-vgoyal@redhat.com> (raw) In-Reply-To: <20200218214841.10076-1-vgoyal@redhat.com> Currently pmem_clear_poison() expects offset and len to be sector aligned. Atleast that seems to be the assumption with which code has been written. It is called only from pmem_do_bvec() which is called only from pmem_rw_page() and pmem_make_request() which will only passe sector aligned offset and len. Soon we want use this function from dax_zero_page_range() code path which can try to zero arbitrary range of memory with-in a page. So update this function to assume that offset and length can be arbitrary and do the necessary alignments as needed. nvdimm_clear_poison() seems to assume offset and len to be aligned to clear_err_unit boundary. But this is currently internal detail and is not exported for others to use. So for now, continue to align offset and length to SECTOR_SIZE boundary. Improving it further and to align it to clear_err_unit boundary is a TODO item for future. Signed-off-by: Vivek Goyal <vgoyal@redhat.com> --- drivers/nvdimm/pmem.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 075b11682192..e72959203253 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -74,14 +74,28 @@ static blk_status_t pmem_clear_poison(struct pmem_device *pmem, sector_t sector; long cleared; blk_status_t rc = BLK_STS_OK; + phys_addr_t start_aligned, end_aligned; + unsigned int len_aligned; - sector = (offset - pmem->data_offset) / 512; + /* + * Callers can pass arbitrary offset and len. But nvdimm_clear_poison() + * expects memory offset and length to meet certain alignment + * restrction (clear_err_unit). Currently nvdimm does not export + * required alignment. So align offset and length to sector boundary + * before passing it to nvdimm_clear_poison(). + */ + start_aligned = ALIGN(offset, SECTOR_SIZE); + end_aligned = ALIGN_DOWN((offset + len), SECTOR_SIZE) - 1; + len_aligned = end_aligned - start_aligned + 1; + + sector = (start_aligned - pmem->data_offset) / 512; - cleared = nvdimm_clear_poison(dev, pmem->phys_addr + offset, len); - if (cleared < len) + cleared = nvdimm_clear_poison(dev, pmem->phys_addr + start_aligned, + len_aligned); + if (cleared < len_aligned) rc = BLK_STS_IOERR; if (cleared > 0 && cleared / 512) { - hwpoison_clear(pmem, pmem->phys_addr + offset, cleared); + hwpoison_clear(pmem, pmem->phys_addr + start_aligned, cleared); cleared /= 512; dev_dbg(dev, "%#llx clear %ld sector%s\n", (unsigned long long) sector, cleared, -- 2.20.1
next prev parent reply other threads:[~2020-02-18 21:49 UTC|newest] Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-18 21:48 [PATCH v5 0/8] dax/pmem: Provide a dax operation to zero range of memory Vivek Goyal 2020-02-18 21:48 ` Vivek Goyal 2020-02-18 21:48 ` [PATCH v5 1/8] pmem: Add functions for reading/writing page to/from pmem Vivek Goyal 2020-02-18 21:48 ` Vivek Goyal 2020-02-18 21:48 ` Vivek Goyal [this message] 2020-02-18 21:48 ` [PATCH v5 2/8] drivers/pmem: Allow pmem_clear_poison() to accept arbitrary offset and len Vivek Goyal 2020-02-20 16:17 ` Christoph Hellwig 2020-02-20 16:17 ` Christoph Hellwig 2020-02-20 21:35 ` Jeff Moyer 2020-02-20 21:35 ` Jeff Moyer 2020-02-20 21:57 ` Vivek Goyal 2020-02-20 21:57 ` Vivek Goyal 2020-02-21 18:32 ` Jeff Moyer 2020-02-21 18:32 ` Jeff Moyer 2020-02-21 20:17 ` Vivek Goyal 2020-02-21 20:17 ` Vivek Goyal 2020-02-21 21:00 ` Dan Williams 2020-02-21 21:00 ` Dan Williams 2020-02-21 21:24 ` Vivek Goyal 2020-02-21 21:24 ` Vivek Goyal 2020-02-21 21:30 ` Dan Williams 2020-02-21 21:30 ` Dan Williams 2020-02-21 21:33 ` Jeff Moyer 2020-02-21 21:33 ` Jeff Moyer 2020-02-23 23:03 ` Dave Chinner 2020-02-23 23:03 ` Dave Chinner 2020-02-24 0:40 ` Dan Williams 2020-02-24 0:40 ` Dan Williams 2020-02-24 13:50 ` Jeff Moyer 2020-02-24 13:50 ` Jeff Moyer 2020-02-24 20:48 ` Dan Williams 2020-02-24 20:48 ` Dan Williams 2020-02-24 21:53 ` Jeff Moyer 2020-02-24 21:53 ` Jeff Moyer 2020-02-25 0:26 ` Dan Williams 2020-02-25 0:26 ` Dan Williams 2020-02-25 20:32 ` Jeff Moyer 2020-02-25 20:32 ` Jeff Moyer 2020-02-25 21:52 ` Dan Williams 2020-02-25 21:52 ` Dan Williams 2020-02-25 23:26 ` Jane Chu 2020-02-25 23:26 ` Jane Chu 2020-02-24 15:38 ` Vivek Goyal 2020-02-24 15:38 ` Vivek Goyal 2020-02-27 3:02 ` Dave Chinner 2020-02-27 3:02 ` Dave Chinner 2020-02-27 4:19 ` Dan Williams 2020-02-27 4:19 ` Dan Williams 2020-02-28 1:30 ` Dave Chinner 2020-02-28 1:30 ` Dave Chinner 2020-02-28 3:28 ` Dan Williams 2020-02-28 3:28 ` Dan Williams 2020-02-28 14:05 ` Christoph Hellwig 2020-02-28 14:05 ` Christoph Hellwig 2020-02-28 16:26 ` Dan Williams 2020-02-28 16:26 ` Dan Williams 2020-02-24 20:13 ` Vivek Goyal 2020-02-24 20:13 ` Vivek Goyal 2020-02-24 20:52 ` Dan Williams 2020-02-24 20:52 ` Dan Williams 2020-02-24 21:15 ` Vivek Goyal 2020-02-24 21:15 ` Vivek Goyal 2020-02-24 21:32 ` Dan Williams 2020-02-24 21:32 ` Dan Williams 2020-02-25 13:36 ` Vivek Goyal 2020-02-25 13:36 ` Vivek Goyal 2020-02-25 16:25 ` Dan Williams 2020-02-25 16:25 ` Dan Williams 2020-02-25 20:08 ` Vivek Goyal 2020-02-25 20:08 ` Vivek Goyal 2020-02-25 22:49 ` Dan Williams 2020-02-25 22:49 ` Dan Williams 2020-02-26 13:51 ` Vivek Goyal 2020-02-26 13:51 ` Vivek Goyal 2020-02-26 16:57 ` Vivek Goyal 2020-02-26 16:57 ` Vivek Goyal 2020-02-27 3:11 ` Dave Chinner 2020-02-27 3:11 ` Dave Chinner 2020-02-27 15:25 ` Vivek Goyal 2020-02-27 15:25 ` Vivek Goyal 2020-02-28 1:50 ` Dave Chinner 2020-02-28 1:50 ` Dave Chinner 2020-02-18 21:48 ` [PATCH v5 3/8] pmem: Enable pmem_do_write() to deal with arbitrary ranges Vivek Goyal 2020-02-18 21:48 ` Vivek Goyal 2020-02-20 16:17 ` Christoph Hellwig 2020-02-20 16:17 ` Christoph Hellwig 2020-02-18 21:48 ` [PATCH v5 4/8] dax, pmem: Add a dax operation zero_page_range Vivek Goyal 2020-02-18 21:48 ` Vivek Goyal 2020-03-31 19:38 ` Dan Williams 2020-03-31 19:38 ` Dan Williams 2020-04-01 13:15 ` Vivek Goyal 2020-04-01 13:15 ` Vivek Goyal 2020-04-01 16:14 ` Vivek Goyal 2020-04-01 16:14 ` Vivek Goyal 2020-02-18 21:48 ` [PATCH v5 5/8] s390,dcssblk,dax: Add dax zero_page_range operation to dcssblk driver Vivek Goyal 2020-02-18 21:48 ` Vivek Goyal 2020-02-18 21:48 ` [PATCH v5 6/8] dm,dax: Add dax zero_page_range operation Vivek Goyal 2020-02-18 21:48 ` Vivek Goyal 2020-02-18 21:48 ` [PATCH v5 7/8] dax,iomap: Start using dax native zero_page_range() Vivek Goyal 2020-02-18 21:48 ` Vivek Goyal 2020-02-18 21:48 ` [PATCH v5 8/8] dax,iomap: Add helper dax_iomap_zero() to zero a range Vivek Goyal 2020-02-18 21:48 ` Vivek Goyal 2020-04-25 11:31 ` [PATCH v5 8/8] dax, iomap: " neolift9
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200218214841.10076-3-vgoyal@redhat.com \ --to=vgoyal@redhat.com \ --cc=dan.j.williams@intel.com \ --cc=dm-devel@redhat.com \ --cc=hch@infradead.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.