From: Murphy Zhou <jencce.kernel@gmail.com> To: Jeff Moyer <jmoyer@redhat.com> Cc: linux-nvdimm <linux-nvdimm@lists.01.org>, Jia He <justin.he@arm.com>, Linux MM <linux-mm@kvack.org>, "Shutemov, Kirill" <kirill.shutemov@intel.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] mm: get rid of WARN if failed to cow user pages Date: Wed, 19 Feb 2020 09:58:19 +0800 [thread overview] Message-ID: <20200219015819.otdnknxpyo52txy7@xzhoux.usersys.redhat.com> (raw) In-Reply-To: <x49imk3bo1h.fsf@segfault.boston.devel.redhat.com> On Tue, Feb 18, 2020 at 04:09:30PM -0500, Jeff Moyer wrote: > Dan Williams <dan.j.williams@intel.com> writes: > > > [ drop Ross, add Kirill, linux-mm, and lkml ] > > > > On Tue, Dec 24, 2019 at 9:42 PM Murphy Zhou <jencce.kernel@gmail.com> wrote: > >> > >> By running xfstests with fsdax enabled, generic/437 always hits this > >> warning[1] since this commit: > >> > >> commit 83d116c53058d505ddef051e90ab27f57015b025 > >> Author: Jia He <justin.he@arm.com> > >> Date: Fri Oct 11 22:09:39 2019 +0800 > >> > >> mm: fix double page fault on arm64 if PTE_AF is cleared > >> > >> Looking at the test program[2] generic/437 uses, it's pretty easy > >> to hit this warning. Remove this WARN as it seems not necessary. > > > > This is not sufficient justification. Does this same test fail without > > DAX? If not, why not? At a minimum you need to explain why this is not > > indicating a problem. > > I ran into this, too, and Kirill has posted a patch[1] to fix the issue. > Note that it's a potential data corrupter, so just removing the warning > is NOT the right approach. :) Agree :) Thanks! > > -Jeff > > [1] https://lore.kernel.org/linux-mm/20200218154151.13349-1-kirill.shutemov@linux.intel.com/T/#u > _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Murphy Zhou <jencce.kernel@gmail.com> To: Jeff Moyer <jmoyer@redhat.com> Cc: Dan Williams <dan.j.williams@intel.com>, Murphy Zhou <jencce.kernel@gmail.com>, linux-nvdimm <linux-nvdimm@lists.01.org>, Jia He <justin.he@arm.com>, Linux MM <linux-mm@kvack.org>, "Shutemov, Kirill" <kirill.shutemov@intel.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] mm: get rid of WARN if failed to cow user pages Date: Wed, 19 Feb 2020 09:58:19 +0800 [thread overview] Message-ID: <20200219015819.otdnknxpyo52txy7@xzhoux.usersys.redhat.com> (raw) In-Reply-To: <x49imk3bo1h.fsf@segfault.boston.devel.redhat.com> On Tue, Feb 18, 2020 at 04:09:30PM -0500, Jeff Moyer wrote: > Dan Williams <dan.j.williams@intel.com> writes: > > > [ drop Ross, add Kirill, linux-mm, and lkml ] > > > > On Tue, Dec 24, 2019 at 9:42 PM Murphy Zhou <jencce.kernel@gmail.com> wrote: > >> > >> By running xfstests with fsdax enabled, generic/437 always hits this > >> warning[1] since this commit: > >> > >> commit 83d116c53058d505ddef051e90ab27f57015b025 > >> Author: Jia He <justin.he@arm.com> > >> Date: Fri Oct 11 22:09:39 2019 +0800 > >> > >> mm: fix double page fault on arm64 if PTE_AF is cleared > >> > >> Looking at the test program[2] generic/437 uses, it's pretty easy > >> to hit this warning. Remove this WARN as it seems not necessary. > > > > This is not sufficient justification. Does this same test fail without > > DAX? If not, why not? At a minimum you need to explain why this is not > > indicating a problem. > > I ran into this, too, and Kirill has posted a patch[1] to fix the issue. > Note that it's a potential data corrupter, so just removing the warning > is NOT the right approach. :) Agree :) Thanks! > > -Jeff > > [1] https://lore.kernel.org/linux-mm/20200218154151.13349-1-kirill.shutemov@linux.intel.com/T/#u >
next prev parent reply other threads:[~2020-02-19 1:58 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-25 5:42 [PATCH] mm: get rid of WARN if failed to cow user pages Murphy Zhou 2019-12-25 8:17 ` Justin He 2019-12-26 10:53 ` Murphy Zhou 2020-01-15 4:48 ` Murphy Zhou 2020-01-15 6:02 ` Dan Williams 2020-01-15 6:02 ` Dan Williams 2020-01-15 6:02 ` Dan Williams 2020-02-18 21:09 ` Jeff Moyer 2020-02-18 21:09 ` Jeff Moyer 2020-02-18 21:09 ` Jeff Moyer 2020-02-19 1:58 ` Murphy Zhou [this message] 2020-02-19 1:58 ` Murphy Zhou
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200219015819.otdnknxpyo52txy7@xzhoux.usersys.redhat.com \ --to=jencce.kernel@gmail.com \ --cc=jmoyer@redhat.com \ --cc=justin.he@arm.com \ --cc=kirill.shutemov@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nvdimm@lists.01.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.