All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx7-colibri: Fix frequency for sd/mmc
@ 2020-02-19 11:57 ` Oleksandr Suvorov
  0 siblings, 0 replies; 4+ messages in thread
From: Oleksandr Suvorov @ 2020-02-19 11:57 UTC (permalink / raw)
  To: devicetree
  Cc: Marcel Ziswiler, Igor Opanyuk, Philippe Schenker,
	Oleksandr Suvorov, Fabio Estevam, Mark Rutland, NXP Linux Team,
	Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
	Stefan Agner, linux-arm-kernel, linux-kernel

SD/MMC on Colibri iMX7S/D modules successfully support
200Mhz frequency in HS200 mode.

Removing the unnecessary max-frequency limit significantly
increases the performance:

== before fix ====
root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
/dev/mmcblk0:
 Timing buffered disk reads: 252 MB in  3.02 seconds =  83.54 MB/sec
==================

=== after fix ====
root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
/dev/mmcblk0:
 Timing buffered disk reads: 408 MB in  3.00 seconds = 135.94 MB/sec
==================

Fixes: f928a4a377e4 ("ARM: dts: imx7: add Toradex Colibri iMX7D
                      1GB (eMMC) support")
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---

 arch/arm/boot/dts/imx7-colibri.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index d05be3f0e2a7..04717cf69db0 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -336,7 +336,6 @@ &usdhc3 {
 	assigned-clock-rates = <400000000>;
 	bus-width = <8>;
 	fsl,tuning-step = <2>;
-	max-frequency = <100000000>;
 	vmmc-supply = <&reg_module_3v3>;
 	vqmmc-supply = <&reg_DCDC3>;
 	non-removable;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx7-colibri: Fix frequency for sd/mmc
@ 2020-02-19 11:57 ` Oleksandr Suvorov
  0 siblings, 0 replies; 4+ messages in thread
From: Oleksandr Suvorov @ 2020-02-19 11:57 UTC (permalink / raw)
  To: devicetree
  Cc: Mark Rutland, Marcel Ziswiler, Shawn Guo, Sascha Hauer,
	linux-kernel, Stefan Agner, Oleksandr Suvorov, Philippe Schenker,
	Igor Opanyuk, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel

SD/MMC on Colibri iMX7S/D modules successfully support
200Mhz frequency in HS200 mode.

Removing the unnecessary max-frequency limit significantly
increases the performance:

== before fix ====
root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
/dev/mmcblk0:
 Timing buffered disk reads: 252 MB in  3.02 seconds =  83.54 MB/sec
==================

=== after fix ====
root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
/dev/mmcblk0:
 Timing buffered disk reads: 408 MB in  3.00 seconds = 135.94 MB/sec
==================

Fixes: f928a4a377e4 ("ARM: dts: imx7: add Toradex Colibri iMX7D
                      1GB (eMMC) support")
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---

 arch/arm/boot/dts/imx7-colibri.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colibri.dtsi
index d05be3f0e2a7..04717cf69db0 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -336,7 +336,6 @@ &usdhc3 {
 	assigned-clock-rates = <400000000>;
 	bus-width = <8>;
 	fsl,tuning-step = <2>;
-	max-frequency = <100000000>;
 	vmmc-supply = <&reg_module_3v3>;
 	vqmmc-supply = <&reg_DCDC3>;
 	non-removable;
-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx7-colibri: Fix frequency for sd/mmc
  2020-02-19 11:57 ` Oleksandr Suvorov
@ 2020-02-19 12:48   ` Fabio Estevam
  -1 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2020-02-19 12:48 UTC (permalink / raw)
  To: Oleksandr Suvorov
  Cc: devicetree, Marcel Ziswiler, Igor Opanyuk, Philippe Schenker,
	Mark Rutland, NXP Linux Team, Pengutronix Kernel Team,
	Rob Herring, Sascha Hauer, Shawn Guo, Stefan Agner,
	linux-arm-kernel, linux-kernel

Hi Oleksandr,

On Wed, Feb 19, 2020 at 8:57 AM Oleksandr Suvorov
<oleksandr.suvorov@toradex.com> wrote:
>
> SD/MMC on Colibri iMX7S/D modules successfully support
> 200Mhz frequency in HS200 mode.

s/Mhz/MHz

>
> Removing the unnecessary max-frequency limit significantly
> increases the performance:
>
> == before fix ====
> root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
> /dev/mmcblk0:
>  Timing buffered disk reads: 252 MB in  3.02 seconds =  83.54 MB/sec
> ==================
>
> === after fix ====
> root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
> /dev/mmcblk0:
>  Timing buffered disk reads: 408 MB in  3.00 seconds = 135.94 MB/sec
> ==================

Nice improvement :-)

>
> Fixes: f928a4a377e4 ("ARM: dts: imx7: add Toradex Colibri iMX7D
>                       1GB (eMMC) support")

Please keep the Fixes tag in a single line.

Reviewed-by: Fabio Estevam <festevam@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx7-colibri: Fix frequency for sd/mmc
@ 2020-02-19 12:48   ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2020-02-19 12:48 UTC (permalink / raw)
  To: Oleksandr Suvorov
  Cc: Mark Rutland, devicetree, Marcel Ziswiler, Sascha Hauer,
	linux-kernel, Stefan Agner, Philippe Schenker, Igor Opanyuk,
	Rob Herring, NXP Linux Team, Pengutronix Kernel Team, Shawn Guo,
	linux-arm-kernel

Hi Oleksandr,

On Wed, Feb 19, 2020 at 8:57 AM Oleksandr Suvorov
<oleksandr.suvorov@toradex.com> wrote:
>
> SD/MMC on Colibri iMX7S/D modules successfully support
> 200Mhz frequency in HS200 mode.

s/Mhz/MHz

>
> Removing the unnecessary max-frequency limit significantly
> increases the performance:
>
> == before fix ====
> root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
> /dev/mmcblk0:
>  Timing buffered disk reads: 252 MB in  3.02 seconds =  83.54 MB/sec
> ==================
>
> === after fix ====
> root@colibri-imx7-emmc:~# hdparm -t /dev/mmcblk0
> /dev/mmcblk0:
>  Timing buffered disk reads: 408 MB in  3.00 seconds = 135.94 MB/sec
> ==================

Nice improvement :-)

>
> Fixes: f928a4a377e4 ("ARM: dts: imx7: add Toradex Colibri iMX7D
>                       1GB (eMMC) support")

Please keep the Fixes tag in a single line.

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-19 12:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 11:57 [PATCH] ARM: dts: imx7-colibri: Fix frequency for sd/mmc Oleksandr Suvorov
2020-02-19 11:57 ` Oleksandr Suvorov
2020-02-19 12:48 ` Fabio Estevam
2020-02-19 12:48   ` Fabio Estevam

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.