* [PATCH v2] net: disable BRIDGE_NETFILTER by default
@ 2020-02-19 21:40 rkir
2020-02-20 13:11 ` Florian Westphal
2020-02-20 23:02 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: rkir @ 2020-02-19 21:40 UTC (permalink / raw)
To: davem, kuba; +Cc: rammuthiah, adelva, lfy, netdev, Roman Kiryanov
From: Roman Kiryanov <rkir@google.com>
The description says 'If unsure, say N.' but
the module is built as M by default (once
the dependencies are satisfied).
When the module is selected (Y or M), it enables
NETFILTER_FAMILY_BRIDGE and SKB_EXTENSIONS
which alter kernel internal structures.
We (Android Studio Emulator) currently do not
use this module and think this it is more consistent
to have it disabled by default as opposite to
disabling it explicitly to prevent enabling
NETFILTER_FAMILY_BRIDGE and SKB_EXTENSIONS.
Signed-off-by: Roman Kiryanov <rkir@google.com>
---
Changes in v2:
- added cc:netdev@vger.kernel.org
net/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/Kconfig b/net/Kconfig
index b0937a700f01..2eeb0e55f7c9 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -189,7 +189,6 @@ config BRIDGE_NETFILTER
depends on NETFILTER_ADVANCED
select NETFILTER_FAMILY_BRIDGE
select SKB_EXTENSIONS
- default m
---help---
Enabling this option will let arptables resp. iptables see bridged
ARP resp. IP traffic. If you want a bridging firewall, you probably
--
2.25.0.265.gbab2e86ba0-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: disable BRIDGE_NETFILTER by default
2020-02-19 21:40 [PATCH v2] net: disable BRIDGE_NETFILTER by default rkir
@ 2020-02-20 13:11 ` Florian Westphal
2020-02-20 23:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Westphal @ 2020-02-20 13:11 UTC (permalink / raw)
To: rkir; +Cc: davem, kuba, rammuthiah, adelva, lfy, netdev
rkir@google.com <rkir@google.com> wrote:
> From: Roman Kiryanov <rkir@google.com>
>
> The description says 'If unsure, say N.' but
> the module is built as M by default (once
> the dependencies are satisfied).
Acked-by: Florian Westphal <fw@strlen.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: disable BRIDGE_NETFILTER by default
2020-02-19 21:40 [PATCH v2] net: disable BRIDGE_NETFILTER by default rkir
2020-02-20 13:11 ` Florian Westphal
@ 2020-02-20 23:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-02-20 23:02 UTC (permalink / raw)
To: rkir; +Cc: kuba, rammuthiah, adelva, lfy, netdev
From: rkir@google.com
Date: Wed, 19 Feb 2020 13:40:06 -0800
> From: Roman Kiryanov <rkir@google.com>
>
> The description says 'If unsure, say N.' but
> the module is built as M by default (once
> the dependencies are satisfied).
>
> When the module is selected (Y or M), it enables
> NETFILTER_FAMILY_BRIDGE and SKB_EXTENSIONS
> which alter kernel internal structures.
>
> We (Android Studio Emulator) currently do not
> use this module and think this it is more consistent
> to have it disabled by default as opposite to
> disabling it explicitly to prevent enabling
> NETFILTER_FAMILY_BRIDGE and SKB_EXTENSIONS.
>
> Signed-off-by: Roman Kiryanov <rkir@google.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-20 23:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-19 21:40 [PATCH v2] net: disable BRIDGE_NETFILTER by default rkir
2020-02-20 13:11 ` Florian Westphal
2020-02-20 23:02 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.