* [chrome-os:chromeos-5.4 4361/4738] drivers//virtio/virtio_balloon.c:960:1: error: label 'out_del_vqs' defined but not used
@ 2020-02-20 0:47 kbuild test robot
0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2020-02-20 0:47 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 10231 bytes --]
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: 7c56c69a839fbe73179ea9ef288f8b29ff706e4e
commit: 5be390d0e5b204bd935a430ac11c8bf1734c8fcc [4361/4738] CHROMIUM: Merge 'v5.4.19' into chromeos-5.4
config: x86_64-randconfig-d001-20200220 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
git checkout 5be390d0e5b204bd935a430ac11c8bf1734c8fcc
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers//virtio/virtio_balloon.c: In function 'virtballoon_probe':
>> drivers//virtio/virtio_balloon.c:960:1: error: label 'out_del_vqs' defined but not used [-Werror=unused-label]
out_del_vqs:
^~~~~~~~~~~
cc1: all warnings being treated as errors
vim +/out_del_vqs +960 drivers//virtio/virtio_balloon.c
71994620bb25a8 Wei Wang 2018-08-16 860
be91c33dd15eff Amit Shah 2011-12-22 861 static int virtballoon_probe(struct virtio_device *vdev)
be91c33dd15eff Amit Shah 2011-12-22 862 {
be91c33dd15eff Amit Shah 2011-12-22 863 struct virtio_balloon *vb;
2e991629bcf55a Wei Wang 2018-08-27 864 __u32 poison_val;
be91c33dd15eff Amit Shah 2011-12-22 865 int err;
be91c33dd15eff Amit Shah 2011-12-22 866
2d9becc1e0c6f8 Michael S. Tsirkin 2015-01-12 867 if (!vdev->config->get) {
2d9becc1e0c6f8 Michael S. Tsirkin 2015-01-12 868 dev_err(&vdev->dev, "%s failure: config access disabled\n",
2d9becc1e0c6f8 Michael S. Tsirkin 2015-01-12 869 __func__);
2d9becc1e0c6f8 Michael S. Tsirkin 2015-01-12 870 return -EINVAL;
2d9becc1e0c6f8 Michael S. Tsirkin 2015-01-12 871 }
2d9becc1e0c6f8 Michael S. Tsirkin 2015-01-12 872
c51d8fca0ce368 Wei Wang 2018-08-16 873 vdev->priv = vb = kzalloc(sizeof(*vb), GFP_KERNEL);
be91c33dd15eff Amit Shah 2011-12-22 874 if (!vb) {
be91c33dd15eff Amit Shah 2011-12-22 875 err = -ENOMEM;
be91c33dd15eff Amit Shah 2011-12-22 876 goto out;
be91c33dd15eff Amit Shah 2011-12-22 877 }
be91c33dd15eff Amit Shah 2011-12-22 878
fd0e21c31e1e63 Petr Mladek 2016-01-25 879 INIT_WORK(&vb->update_balloon_stats_work, update_balloon_stats_func);
fd0e21c31e1e63 Petr Mladek 2016-01-25 880 INIT_WORK(&vb->update_balloon_size_work, update_balloon_size_func);
fad7b7b27b6a16 Petr Mladek 2016-01-25 881 spin_lock_init(&vb->stop_update_lock);
e22504296d4f64 Rafael Aquini 2012-12-11 882 mutex_init(&vb->balloon_lock);
9c378abc5c0c6f Michael S. Tsirkin 2012-07-02 883 init_waitqueue_head(&vb->acked);
be91c33dd15eff Amit Shah 2011-12-22 884 vb->vdev = vdev;
be91c33dd15eff Amit Shah 2011-12-22 885
9d1ba8056474a2 Konstantin Khlebnikov 2014-10-09 886 balloon_devinfo_init(&vb->vb_dev_info);
e22504296d4f64 Rafael Aquini 2012-12-11 887
be91c33dd15eff Amit Shah 2011-12-22 888 err = init_vqs(vb);
be91c33dd15eff Amit Shah 2011-12-22 889 if (err)
9d1ba8056474a2 Konstantin Khlebnikov 2014-10-09 890 goto out_free_vb;
6b35e40767c6c1 Rusty Russell 2008-02-04 891
b1123ea6d3b3da Minchan Kim 2016-07-26 892 #ifdef CONFIG_BALLOON_COMPACTION
b1123ea6d3b3da Minchan Kim 2016-07-26 893 balloon_mnt = kern_mount(&balloon_fs);
b1123ea6d3b3da Minchan Kim 2016-07-26 894 if (IS_ERR(balloon_mnt)) {
b1123ea6d3b3da Minchan Kim 2016-07-26 895 err = PTR_ERR(balloon_mnt);
b1123ea6d3b3da Minchan Kim 2016-07-26 896 goto out_del_vqs;
b1123ea6d3b3da Minchan Kim 2016-07-26 897 }
b1123ea6d3b3da Minchan Kim 2016-07-26 898
b1123ea6d3b3da Minchan Kim 2016-07-26 899 vb->vb_dev_info.migratepage = virtballoon_migratepage;
b1123ea6d3b3da Minchan Kim 2016-07-26 900 vb->vb_dev_info.inode = alloc_anon_inode(balloon_mnt->mnt_sb);
b1123ea6d3b3da Minchan Kim 2016-07-26 901 if (IS_ERR(vb->vb_dev_info.inode)) {
b1123ea6d3b3da Minchan Kim 2016-07-26 902 err = PTR_ERR(vb->vb_dev_info.inode);
c6d07f6e50e47d David Hildenbrand 2020-02-05 903 goto out_kern_unmount;
b1123ea6d3b3da Minchan Kim 2016-07-26 904 }
b1123ea6d3b3da Minchan Kim 2016-07-26 905 vb->vb_dev_info.inode->i_mapping->a_ops = &balloon_aops;
b1123ea6d3b3da Minchan Kim 2016-07-26 906 #endif
86a559787e6f5c Wei Wang 2018-08-27 907 if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT)) {
86a559787e6f5c Wei Wang 2018-08-27 908 /*
86a559787e6f5c Wei Wang 2018-08-27 909 * There is always one entry reserved for cmd id, so the ring
86a559787e6f5c Wei Wang 2018-08-27 910 * size needs to be at least two to report free page hints.
86a559787e6f5c Wei Wang 2018-08-27 911 */
86a559787e6f5c Wei Wang 2018-08-27 912 if (virtqueue_get_vring_size(vb->free_page_vq) < 2) {
86a559787e6f5c Wei Wang 2018-08-27 913 err = -ENOSPC;
c6d07f6e50e47d David Hildenbrand 2020-02-05 914 goto out_iput;
86a559787e6f5c Wei Wang 2018-08-27 915 }
86a559787e6f5c Wei Wang 2018-08-27 916 vb->balloon_wq = alloc_workqueue("balloon-wq",
86a559787e6f5c Wei Wang 2018-08-27 917 WQ_FREEZABLE | WQ_CPU_INTENSIVE, 0);
86a559787e6f5c Wei Wang 2018-08-27 918 if (!vb->balloon_wq) {
86a559787e6f5c Wei Wang 2018-08-27 919 err = -ENOMEM;
c6d07f6e50e47d David Hildenbrand 2020-02-05 920 goto out_iput;
86a559787e6f5c Wei Wang 2018-08-27 921 }
86a559787e6f5c Wei Wang 2018-08-27 922 INIT_WORK(&vb->report_free_page_work, report_free_page_func);
bf4dc0b2beebfd Wei Wang 2019-01-07 923 vb->cmd_id_received_cache = VIRTIO_BALLOON_CMD_ID_STOP;
86a559787e6f5c Wei Wang 2018-08-27 924 vb->cmd_id_active = cpu_to_virtio32(vb->vdev,
86a559787e6f5c Wei Wang 2018-08-27 925 VIRTIO_BALLOON_CMD_ID_STOP);
86a559787e6f5c Wei Wang 2018-08-27 926 vb->cmd_id_stop = cpu_to_virtio32(vb->vdev,
86a559787e6f5c Wei Wang 2018-08-27 927 VIRTIO_BALLOON_CMD_ID_STOP);
86a559787e6f5c Wei Wang 2018-08-27 928 spin_lock_init(&vb->free_page_list_lock);
86a559787e6f5c Wei Wang 2018-08-27 929 INIT_LIST_HEAD(&vb->free_page_list);
2e991629bcf55a Wei Wang 2018-08-27 930 if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_PAGE_POISON)) {
2e991629bcf55a Wei Wang 2018-08-27 931 memset(&poison_val, PAGE_POISON, sizeof(poison_val));
2e991629bcf55a Wei Wang 2018-08-27 932 virtio_cwrite(vb->vdev, struct virtio_balloon_config,
2e991629bcf55a Wei Wang 2018-08-27 933 poison_val, &poison_val);
2e991629bcf55a Wei Wang 2018-08-27 934 }
86a559787e6f5c Wei Wang 2018-08-27 935 }
71994620bb25a8 Wei Wang 2018-08-16 936 /*
71994620bb25a8 Wei Wang 2018-08-16 937 * We continue to use VIRTIO_BALLOON_F_DEFLATE_ON_OOM to decide if a
71994620bb25a8 Wei Wang 2018-08-16 938 * shrinker needs to be registered to relieve memory pressure.
71994620bb25a8 Wei Wang 2018-08-16 939 */
71994620bb25a8 Wei Wang 2018-08-16 940 if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_DEFLATE_ON_OOM)) {
71994620bb25a8 Wei Wang 2018-08-16 941 err = virtio_balloon_register_shrinker(vb);
71994620bb25a8 Wei Wang 2018-08-16 942 if (err)
86a559787e6f5c Wei Wang 2018-08-27 943 goto out_del_balloon_wq;
71994620bb25a8 Wei Wang 2018-08-16 944 }
88660f7fb94cda Michael S. Tsirkin 2015-03-05 945 virtio_device_ready(vdev);
88660f7fb94cda Michael S. Tsirkin 2015-03-05 946
8424af5336b340 Konstantin Neumoin 2016-09-29 947 if (towards_target(vb))
8424af5336b340 Konstantin Neumoin 2016-09-29 948 virtballoon_changed(vdev);
6b35e40767c6c1 Rusty Russell 2008-02-04 949 return 0;
6b35e40767c6c1 Rusty Russell 2008-02-04 950
86a559787e6f5c Wei Wang 2018-08-27 951 out_del_balloon_wq:
86a559787e6f5c Wei Wang 2018-08-27 952 if (virtio_has_feature(vdev, VIRTIO_BALLOON_F_FREE_PAGE_HINT))
86a559787e6f5c Wei Wang 2018-08-27 953 destroy_workqueue(vb->balloon_wq);
c6d07f6e50e47d David Hildenbrand 2020-02-05 954 out_iput:
c6d07f6e50e47d David Hildenbrand 2020-02-05 955 #ifdef CONFIG_BALLOON_COMPACTION
c6d07f6e50e47d David Hildenbrand 2020-02-05 956 iput(vb->vb_dev_info.inode);
c6d07f6e50e47d David Hildenbrand 2020-02-05 957 out_kern_unmount:
c6d07f6e50e47d David Hildenbrand 2020-02-05 958 kern_unmount(balloon_mnt);
c6d07f6e50e47d David Hildenbrand 2020-02-05 959 #endif
b1123ea6d3b3da Minchan Kim 2016-07-26 @960 out_del_vqs:
d2a7ddda9ffb1c Michael S. Tsirkin 2009-06-12 961 vdev->config->del_vqs(vdev);
6b35e40767c6c1 Rusty Russell 2008-02-04 962 out_free_vb:
6b35e40767c6c1 Rusty Russell 2008-02-04 963 kfree(vb);
6b35e40767c6c1 Rusty Russell 2008-02-04 964 out:
6b35e40767c6c1 Rusty Russell 2008-02-04 965 return err;
6b35e40767c6c1 Rusty Russell 2008-02-04 966 }
6b35e40767c6c1 Rusty Russell 2008-02-04 967
:::::: The code at line 960 was first introduced by commit
:::::: b1123ea6d3b3da25af5c8a9d843bd07ab63213f4 mm: balloon: use general non-lru movable page feature
:::::: TO: Minchan Kim <minchan@kernel.org>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39073 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-20 0:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-20 0:47 [chrome-os:chromeos-5.4 4361/4738] drivers//virtio/virtio_balloon.c:960:1: error: label 'out_del_vqs' defined but not used kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.