* [PATCH] docs: Fix empty parallelism argument
@ 2020-02-22 0:02 Kees Cook
2020-02-25 10:11 ` Jonathan Corbet
0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2020-02-22 0:02 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: Rafael J. Wysocki, linux-kernel, linux-doc
When there was no parallelism (no top-level -j arg and a pre-1.7
sphinx-build), the argument passed would be empty ("") instead of just
being missing, which would (understandably) badly confuse sphinx-build.
Fix this by removing the quotes.
Reported-by: Rafael J. Wysocki <rafael@kernel.org>
Fixes: 51e46c7a4007 ("docs, parallelism: Rearrange how jobserver reservations are made")
Signed-off-by: Kees Cook <keescook@chromium.org>
---
Documentation/sphinx/parallel-wrapper.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/sphinx/parallel-wrapper.sh b/Documentation/sphinx/parallel-wrapper.sh
index 7daf5133bdd3..e54c44ce117d 100644
--- a/Documentation/sphinx/parallel-wrapper.sh
+++ b/Documentation/sphinx/parallel-wrapper.sh
@@ -30,4 +30,4 @@ if [ -n "$parallel" ] ; then
parallel="-j$parallel"
fi
-exec "$sphinx" "$parallel" "$@"
+exec "$sphinx" $parallel "$@"
--
2.20.1
--
Kees Cook
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] docs: Fix empty parallelism argument
2020-02-22 0:02 [PATCH] docs: Fix empty parallelism argument Kees Cook
@ 2020-02-25 10:11 ` Jonathan Corbet
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2020-02-25 10:11 UTC (permalink / raw)
To: Kees Cook; +Cc: Rafael J. Wysocki, linux-kernel, linux-doc
On Fri, 21 Feb 2020 16:02:39 -0800
Kees Cook <keescook@chromium.org> wrote:
> When there was no parallelism (no top-level -j arg and a pre-1.7
> sphinx-build), the argument passed would be empty ("") instead of just
> being missing, which would (understandably) badly confuse sphinx-build.
> Fix this by removing the quotes.
>
> Reported-by: Rafael J. Wysocki <rafael@kernel.org>
> Fixes: 51e46c7a4007 ("docs, parallelism: Rearrange how jobserver reservations are made")
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied, thanks for fixing this.
jon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-25 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-22 0:02 [PATCH] docs: Fix empty parallelism argument Kees Cook
2020-02-25 10:11 ` Jonathan Corbet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.