All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] Misc AUH suggested package upgrades
@ 2020-02-21 22:45 Khem Raj
  2020-02-21 22:45 ` [PATCH 1/4] libxcrypt: Upgrade to 4.4.14 release Khem Raj
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Khem Raj @ 2020-02-21 22:45 UTC (permalink / raw)
  To: openembedded-core

My share of pending updates

Khem Raj (3):
  libxcrypt: Upgrade to 4.4.14 release
  go: Upgrade to 1.13.8 minor release
  gmp: Upgrade to 6.2.0

Upgrade Helper (1):
  ninja: upgrade 1.9.0 -> 1.10.0

 ...t_4.4.12.bb => libxcrypt-compat_4.4.14.bb} |  0
 meta/recipes-core/libxcrypt/libxcrypt.inc     |  2 +-
 ...ibxcrypt_4.4.12.bb => libxcrypt_4.4.14.bb} |  0
 meta/recipes-devtools/go/go-1.13.inc          |  7 ++-
 .../ninja/ninja/fix-musl.patch                | 46 -------------------
 .../ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} |  6 +--
 .../recipes-support/gmp/gmp-6.1.2/amd64.patch | 18 --------
 ...provided-flags-to-the-auto-detected-.patch |  0
 ...-Believe-the-cflags-from-environment.patch | 16 +++----
 .../{gmp-6.1.2 => gmp}/use-includedir.patch   |  3 ++
 .../gmp/{gmp_6.1.2.bb => gmp_6.2.0.bb}        |  5 +-
 11 files changed, 19 insertions(+), 84 deletions(-)
 rename meta/recipes-core/libxcrypt/{libxcrypt-compat_4.4.12.bb => libxcrypt-compat_4.4.14.bb} (100%)
 rename meta/recipes-core/libxcrypt/{libxcrypt_4.4.12.bb => libxcrypt_4.4.14.bb} (100%)
 delete mode 100644 meta/recipes-devtools/ninja/ninja/fix-musl.patch
 rename meta/recipes-devtools/ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} (87%)
 delete mode 100644 meta/recipes-support/gmp/gmp-6.1.2/amd64.patch
 rename meta/recipes-support/gmp/{gmp-6.1.2 => gmp}/0001-Append-the-user-provided-flags-to-the-auto-detected-.patch (100%)
 rename meta/recipes-support/gmp/{gmp-6.1.2 => gmp}/0001-confiure.ac-Believe-the-cflags-from-environment.patch (80%)
 rename meta/recipes-support/gmp/{gmp-6.1.2 => gmp}/use-includedir.patch (83%)
 rename meta/recipes-support/gmp/{gmp_6.1.2.bb => gmp_6.2.0.bb} (86%)

-- 
2.25.1



^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/4] libxcrypt: Upgrade to 4.4.14 release
  2020-02-21 22:45 [PATCH 0/4] Misc AUH suggested package upgrades Khem Raj
@ 2020-02-21 22:45 ` Khem Raj
  2020-02-21 22:45 ` [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0 Khem Raj
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 14+ messages in thread
From: Khem Raj @ 2020-02-21 22:45 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../{libxcrypt-compat_4.4.12.bb => libxcrypt-compat_4.4.14.bb}  | 0
 meta/recipes-core/libxcrypt/libxcrypt.inc                       | 2 +-
 .../libxcrypt/{libxcrypt_4.4.12.bb => libxcrypt_4.4.14.bb}      | 0
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename meta/recipes-core/libxcrypt/{libxcrypt-compat_4.4.12.bb => libxcrypt-compat_4.4.14.bb} (100%)
 rename meta/recipes-core/libxcrypt/{libxcrypt_4.4.12.bb => libxcrypt_4.4.14.bb} (100%)

diff --git a/meta/recipes-core/libxcrypt/libxcrypt-compat_4.4.12.bb b/meta/recipes-core/libxcrypt/libxcrypt-compat_4.4.14.bb
similarity index 100%
rename from meta/recipes-core/libxcrypt/libxcrypt-compat_4.4.12.bb
rename to meta/recipes-core/libxcrypt/libxcrypt-compat_4.4.14.bb
diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc b/meta/recipes-core/libxcrypt/libxcrypt.inc
index 59744c0cf8..416205cd5c 100644
--- a/meta/recipes-core/libxcrypt/libxcrypt.inc
+++ b/meta/recipes-core/libxcrypt/libxcrypt.inc
@@ -10,7 +10,7 @@ LIC_FILES_CHKSUM ?= "file://LICENSING;md5=3bb6614cf5880cbf1b9dbd9e3d145e2c \
 inherit autotools pkgconfig
 
 SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH}"
-SRCREV = "21f93470aad8634fcf39f72db0b62642c7073a0c"
+SRCREV = "5c43f7d56a31667bcdaa334bbb4edafb75672872"
 SRCBRANCH ?= "develop"
 
 PROVIDES = "virtual/crypt"
diff --git a/meta/recipes-core/libxcrypt/libxcrypt_4.4.12.bb b/meta/recipes-core/libxcrypt/libxcrypt_4.4.14.bb
similarity index 100%
rename from meta/recipes-core/libxcrypt/libxcrypt_4.4.12.bb
rename to meta/recipes-core/libxcrypt/libxcrypt_4.4.14.bb
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0
  2020-02-21 22:45 [PATCH 0/4] Misc AUH suggested package upgrades Khem Raj
  2020-02-21 22:45 ` [PATCH 1/4] libxcrypt: Upgrade to 4.4.14 release Khem Raj
@ 2020-02-21 22:45 ` Khem Raj
  2020-02-25 19:43   ` Andre McCurdy
  2020-02-21 22:45 ` [PATCH 3/4] go: Upgrade to 1.13.8 minor release Khem Raj
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Khem Raj @ 2020-02-21 22:45 UTC (permalink / raw)
  To: openembedded-core; +Cc: Upgrade Helper

From: Upgrade Helper <auh@auh.yoctoproject.org>

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 .../ninja/ninja/fix-musl.patch                | 46 -------------------
 .../ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} |  6 +--
 2 files changed, 2 insertions(+), 50 deletions(-)
 delete mode 100644 meta/recipes-devtools/ninja/ninja/fix-musl.patch
 rename meta/recipes-devtools/ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} (87%)

diff --git a/meta/recipes-devtools/ninja/ninja/fix-musl.patch b/meta/recipes-devtools/ninja/ninja/fix-musl.patch
deleted file mode 100644
index 7fd779110d..0000000000
--- a/meta/recipes-devtools/ninja/ninja/fix-musl.patch
+++ /dev/null
@@ -1,46 +0,0 @@
-From e92a915183f8bff268f74c8cd00d986301a2bbf8 Mon Sep 17 00:00:00 2001
-From: makepost <makepost@firemail.cc>
-Date: Mon, 24 Dec 2018 03:13:16 +0200
-Subject: [PATCH] Use st_mtim if st_mtime is macro, fix #1510
-
-In POSIX.1-2008, sys_stat has a st_mtim member and a st_mtime backward
-compatibility macro. Should help avoid hardcoding platform detection.
-
-Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
-
-Upstream-Status: Pending
----
- src/disk_interface.cc | 14 ++++----------
- 1 file changed, 4 insertions(+), 10 deletions(-)
-
-diff --git a/src/disk_interface.cc b/src/disk_interface.cc
-index d4c2fb0..dc297c4 100644
---- a/src/disk_interface.cc
-+++ b/src/disk_interface.cc
-@@ -202,19 +202,13 @@ TimeStamp RealDiskInterface::Stat(const string& path, string* err) const {
-   // that it doesn't exist.
-   if (st.st_mtime == 0)
-     return 1;
--#if defined(__APPLE__) && !defined(_POSIX_C_SOURCE)
-+#if defined(_AIX)
-+  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
-+#elif defined(__APPLE__)
-   return ((int64_t)st.st_mtimespec.tv_sec * 1000000000LL +
-           st.st_mtimespec.tv_nsec);
--#elif (_POSIX_C_SOURCE >= 200809L || _XOPEN_SOURCE >= 700 || defined(_BSD_SOURCE) || defined(_SVID_SOURCE) || \
--       defined(__BIONIC__) || (defined (__SVR4) && defined (__sun)) || defined(__FreeBSD__))
--  // For glibc, see "Timestamp files" in the Notes of http://www.kernel.org/doc/man-pages/online/pages/man2/stat.2.html
--  // newlib, uClibc and musl follow the kernel (or Cygwin) headers and define the right macro values above.
--  // For bsd, see https://github.com/freebsd/freebsd/blob/master/sys/sys/stat.h and similar
--  // For bionic, C and POSIX API is always enabled.
--  // For solaris, see https://docs.oracle.com/cd/E88353_01/html/E37841/stat-2.html.
-+#elif defined(st_mtime) // A macro, so we're likely on modern POSIX.
-   return (int64_t)st.st_mtim.tv_sec * 1000000000LL + st.st_mtim.tv_nsec;
--#elif defined(_AIX)
--  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
- #else
-   return (int64_t)st.st_mtime * 1000000000LL + st.st_mtimensec;
- #endif
--- 
-2.17.1
-
diff --git a/meta/recipes-devtools/ninja/ninja_1.9.0.bb b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
similarity index 87%
rename from meta/recipes-devtools/ninja/ninja_1.9.0.bb
rename to meta/recipes-devtools/ninja/ninja_1.10.0.bb
index f1236e8ac8..bdc6365052 100644
--- a/meta/recipes-devtools/ninja/ninja_1.9.0.bb
+++ b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
@@ -5,11 +5,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
 
 DEPENDS = "re2c-native ninja-native"
 
-SRCREV = "b25c08bda4949192c69cea4cee057887341a2ffc"
+SRCREV = "ed7f67040b370189d989adbd60ff8ea29957231f"
 
-SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release \
-           file://fix-musl.patch \
-"
+SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release"
 UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
 
 S = "${WORKDIR}/git"
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 3/4] go: Upgrade to 1.13.8 minor release
  2020-02-21 22:45 [PATCH 0/4] Misc AUH suggested package upgrades Khem Raj
  2020-02-21 22:45 ` [PATCH 1/4] libxcrypt: Upgrade to 4.4.14 release Khem Raj
  2020-02-21 22:45 ` [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0 Khem Raj
@ 2020-02-21 22:45 ` Khem Raj
  2020-02-21 22:45 ` [PATCH 4/4] gmp: Upgrade to 6.2.0 Khem Raj
  2020-02-21 23:02 ` ✗ patchtest: failure for Misc AUH suggested package upgrades Patchwork
  4 siblings, 0 replies; 14+ messages in thread
From: Khem Raj @ 2020-02-21 22:45 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/go/go-1.13.inc | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-devtools/go/go-1.13.inc b/meta/recipes-devtools/go/go-1.13.inc
index 39dbd742ec..7780aced89 100644
--- a/meta/recipes-devtools/go/go-1.13.inc
+++ b/meta/recipes-devtools/go/go-1.13.inc
@@ -1,7 +1,7 @@
 require go-common.inc
 
 GO_BASEVERSION = "1.13"
-GO_MINOR = ".5"
+GO_MINOR = ".8"
 PV .= "${GO_MINOR}"
 FILESEXTRAPATHS_prepend := "${FILE_DIRNAME}/go-${GO_BASEVERSION}:"
 
@@ -19,6 +19,5 @@ SRC_URI += "\
 "
 SRC_URI_append_libc-musl = " file://0009-ld-replace-glibc-dynamic-linker-with-musl.patch"
 
-SRC_URI[main.md5sum] = "ecd1729313608d3ef352ea4fd9ea42cd"
-SRC_URI[main.sha256sum] = "27d356e2a0b30d9983b60a788cf225da5f914066b37a6b4f69d457ba55a626ff"
-
+SRC_URI[main.md5sum] = "984c244563f2d2f48103e8d6db8a8308"
+SRC_URI[main.sha256sum] = "b13bf04633d4d8cf53226ebeaace8d4d2fd07ae6fa676d0844a688339debec34"
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH 4/4] gmp: Upgrade to 6.2.0
  2020-02-21 22:45 [PATCH 0/4] Misc AUH suggested package upgrades Khem Raj
                   ` (2 preceding siblings ...)
  2020-02-21 22:45 ` [PATCH 3/4] go: Upgrade to 1.13.8 minor release Khem Raj
@ 2020-02-21 22:45 ` Khem Raj
  2020-02-21 23:02 ` ✗ patchtest: failure for Misc AUH suggested package upgrades Patchwork
  4 siblings, 0 replies; 14+ messages in thread
From: Khem Raj @ 2020-02-21 22:45 UTC (permalink / raw)
  To: openembedded-core

Drop amd64 patch, the bsfq has been replaced with bsfl for count_trailing_zeros
Forward port rest of patches to 6.2.0

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-support/gmp/gmp-6.1.2/amd64.patch | 18 ------------------
 ...-provided-flags-to-the-auto-detected-.patch |  0
 ...c-Believe-the-cflags-from-environment.patch | 16 ++++++++--------
 .../{gmp-6.1.2 => gmp}/use-includedir.patch    |  3 +++
 .../gmp/{gmp_6.1.2.bb => gmp_6.2.0.bb}         |  5 ++---
 5 files changed, 13 insertions(+), 29 deletions(-)
 delete mode 100644 meta/recipes-support/gmp/gmp-6.1.2/amd64.patch
 rename meta/recipes-support/gmp/{gmp-6.1.2 => gmp}/0001-Append-the-user-provided-flags-to-the-auto-detected-.patch (100%)
 rename meta/recipes-support/gmp/{gmp-6.1.2 => gmp}/0001-confiure.ac-Believe-the-cflags-from-environment.patch (80%)
 rename meta/recipes-support/gmp/{gmp-6.1.2 => gmp}/use-includedir.patch (83%)
 rename meta/recipes-support/gmp/{gmp_6.1.2.bb => gmp_6.2.0.bb} (86%)

diff --git a/meta/recipes-support/gmp/gmp-6.1.2/amd64.patch b/meta/recipes-support/gmp/gmp-6.1.2/amd64.patch
deleted file mode 100644
index 3935589f8b..0000000000
--- a/meta/recipes-support/gmp/gmp-6.1.2/amd64.patch
+++ /dev/null
@@ -1,18 +0,0 @@
-Upstream-Status: Pending
-
-Index: gmp-6.1.2/longlong.h
-===================================================================
---- gmp-6.1.2.orig/longlong.h
-+++ gmp-6.1.2/longlong.h
-@@ -1036,8 +1036,10 @@ extern UWtype __MPN(udiv_qrnnd) (UWtype
-    count is only an int. */
- #define count_trailing_zeros(count, x)					\
-   do {									\
-+    UDItype __cbtmp;							\
-     ASSERT ((x) != 0);							\
--    __asm__ ("bsfq %1,%q0" : "=r" (count) : "rm" ((UDItype)(x)));	\
-+    __asm__ ("bsfq %1,%0" : "=r" (__cbtmp) : "rm" ((UDItype)(x)));	\
-+    (count) = __cbtmp;							\
-   } while (0)
- #endif /* __amd64__ */
- 
diff --git a/meta/recipes-support/gmp/gmp-6.1.2/0001-Append-the-user-provided-flags-to-the-auto-detected-.patch b/meta/recipes-support/gmp/gmp/0001-Append-the-user-provided-flags-to-the-auto-detected-.patch
similarity index 100%
rename from meta/recipes-support/gmp/gmp-6.1.2/0001-Append-the-user-provided-flags-to-the-auto-detected-.patch
rename to meta/recipes-support/gmp/gmp/0001-Append-the-user-provided-flags-to-the-auto-detected-.patch
diff --git a/meta/recipes-support/gmp/gmp-6.1.2/0001-confiure.ac-Believe-the-cflags-from-environment.patch b/meta/recipes-support/gmp/gmp/0001-confiure.ac-Believe-the-cflags-from-environment.patch
similarity index 80%
rename from meta/recipes-support/gmp/gmp-6.1.2/0001-confiure.ac-Believe-the-cflags-from-environment.patch
rename to meta/recipes-support/gmp/gmp/0001-confiure.ac-Believe-the-cflags-from-environment.patch
index 1e47924ccc..56564db505 100644
--- a/meta/recipes-support/gmp/gmp-6.1.2/0001-confiure.ac-Believe-the-cflags-from-environment.patch
+++ b/meta/recipes-support/gmp/gmp/0001-confiure.ac-Believe-the-cflags-from-environment.patch
@@ -18,13 +18,11 @@ Upstream-Status: Inappropriate[OE-Specific]
  configure.ac | 11 -----------
  1 file changed, 11 deletions(-)
 
-Index: gmp-6.1.2/configure.ac
-===================================================================
---- gmp-6.1.2.orig/configure.ac
-+++ gmp-6.1.2/configure.ac
-@@ -604,15 +604,6 @@ case $host in
-     any_32_testlist="sizeof-long-4"
-     any_64_testlist="sizeof-long-8"
+--- a/configure.ac
++++ b/configure.ac
+@@ -625,17 +625,6 @@ case $host in
+     any_32_testlist="sizeof-void*-4"
+     any_64_testlist="sizeof-void*-8"
  
 -    # This is needed for clang, which is not content with flags like -mfpu=neon
 -    # alone.
@@ -33,12 +31,14 @@ Index: gmp-6.1.2/configure.ac
 -        gcc_cflags_fpmode="-mfloat-abi=softfp" ;;
 -      *-*-*eabihf)
 -        gcc_cflags_fpmode="-mfloat-abi=hard" ;;
+-      *-*-mingw*)
+-        limb_64=longlong ;;
 -    esac
 -
      # FIXME: We make mandatory compiler options optional here.  We should
      # either enforce them, or organise to strip paths as the corresponding
      # options fail.
-@@ -746,8 +737,6 @@ case $host in
+@@ -780,8 +769,6 @@ case $host in
  	;;
        *)
  	path="arm"
diff --git a/meta/recipes-support/gmp/gmp-6.1.2/use-includedir.patch b/meta/recipes-support/gmp/gmp/use-includedir.patch
similarity index 83%
rename from meta/recipes-support/gmp/gmp-6.1.2/use-includedir.patch
rename to meta/recipes-support/gmp/gmp/use-includedir.patch
index 6b089cf39c..d27317cdf6 100644
--- a/meta/recipes-support/gmp/gmp-6.1.2/use-includedir.patch
+++ b/meta/recipes-support/gmp/gmp/use-includedir.patch
@@ -1,4 +1,7 @@
+exec includedir should be pointing to general yocto includdir
+
 Upstream-Status: Pending
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
 
 Index: gmp-6.1.2/Makefile.am
 ===================================================================
diff --git a/meta/recipes-support/gmp/gmp_6.1.2.bb b/meta/recipes-support/gmp/gmp_6.2.0.bb
similarity index 86%
rename from meta/recipes-support/gmp/gmp_6.1.2.bb
rename to meta/recipes-support/gmp/gmp_6.2.0.bb
index c745dbbfe7..a19c74fca8 100644
--- a/meta/recipes-support/gmp/gmp_6.1.2.bb
+++ b/meta/recipes-support/gmp/gmp_6.2.0.bb
@@ -9,13 +9,12 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
 
 REVISION = ""
 SRC_URI = "https://gmplib.org/download/${BPN}/${BP}${REVISION}.tar.bz2 \
-           file://amd64.patch \
            file://use-includedir.patch \
            file://0001-Append-the-user-provided-flags-to-the-auto-detected-.patch \
            file://0001-confiure.ac-Believe-the-cflags-from-environment.patch \
            "
-SRC_URI[md5sum] = "8ddbb26dc3bd4e2302984debba1406a5"
-SRC_URI[sha256sum] = "5275bb04f4863a13516b2f39392ac5e272f5e1bb8057b18aec1c9b79d73d8fb2"
+SRC_URI[md5sum] = "c24161e0dd44cae78cd5f67193492a21"
+SRC_URI[sha256sum] = "f51c99cb114deb21a60075ffb494c1a210eb9d7cb729ed042ddb7de9534451ea"
 
 acpaths = ""
 
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 14+ messages in thread

* ✗ patchtest: failure for Misc AUH suggested package upgrades
  2020-02-21 22:45 [PATCH 0/4] Misc AUH suggested package upgrades Khem Raj
                   ` (3 preceding siblings ...)
  2020-02-21 22:45 ` [PATCH 4/4] gmp: Upgrade to 6.2.0 Khem Raj
@ 2020-02-21 23:02 ` Patchwork
  4 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2020-02-21 23:02 UTC (permalink / raw)
  To: Khem Raj; +Cc: openembedded-core

== Series Details ==

Series: Misc AUH suggested package upgrades
Revision: 1
URL   : https://patchwork.openembedded.org/series/22856/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            [2/4] ninja: upgrade 1.9.0 -> 1.10.0
 Issue             Invalid author <auh@auh.yoctoproject.org> in commit message [test_non_auh_upgrade] 
  Suggested fix    Resend the series with a valid patch's author



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0
  2020-02-21 22:45 ` [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0 Khem Raj
@ 2020-02-25 19:43   ` Andre McCurdy
  2020-02-25 19:46     ` Alexander Kanavin
  2020-02-25 23:32     ` Khem Raj
  0 siblings, 2 replies; 14+ messages in thread
From: Andre McCurdy @ 2020-02-25 19:43 UTC (permalink / raw)
  To: Khem Raj; +Cc: Upgrade Helper, OE Core mailing list

On Fri, Feb 21, 2020 at 2:46 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> From: Upgrade Helper <auh@auh.yoctoproject.org>

Why does the author sometimes get set to "Upgrade Helper"? It doesn't
seem to happen very often (4 times in the past 6 years in oe-core).
What's special about those 4 cases?

I think it would be clearer if the author was set to whoever ran the tool.

> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  .../ninja/ninja/fix-musl.patch                | 46 -------------------
>  .../ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} |  6 +--
>  2 files changed, 2 insertions(+), 50 deletions(-)
>  delete mode 100644 meta/recipes-devtools/ninja/ninja/fix-musl.patch
>  rename meta/recipes-devtools/ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} (87%)
>
> diff --git a/meta/recipes-devtools/ninja/ninja/fix-musl.patch b/meta/recipes-devtools/ninja/ninja/fix-musl.patch
> deleted file mode 100644
> index 7fd779110d..0000000000
> --- a/meta/recipes-devtools/ninja/ninja/fix-musl.patch
> +++ /dev/null
> @@ -1,46 +0,0 @@
> -From e92a915183f8bff268f74c8cd00d986301a2bbf8 Mon Sep 17 00:00:00 2001
> -From: makepost <makepost@firemail.cc>
> -Date: Mon, 24 Dec 2018 03:13:16 +0200
> -Subject: [PATCH] Use st_mtim if st_mtime is macro, fix #1510
> -
> -In POSIX.1-2008, sys_stat has a st_mtim member and a st_mtime backward
> -compatibility macro. Should help avoid hardcoding platform detection.
> -
> -Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
> -
> -Upstream-Status: Pending
> ----
> - src/disk_interface.cc | 14 ++++----------
> - 1 file changed, 4 insertions(+), 10 deletions(-)
> -
> -diff --git a/src/disk_interface.cc b/src/disk_interface.cc
> -index d4c2fb0..dc297c4 100644
> ---- a/src/disk_interface.cc
> -+++ b/src/disk_interface.cc
> -@@ -202,19 +202,13 @@ TimeStamp RealDiskInterface::Stat(const string& path, string* err) const {
> -   // that it doesn't exist.
> -   if (st.st_mtime == 0)
> -     return 1;
> --#if defined(__APPLE__) && !defined(_POSIX_C_SOURCE)
> -+#if defined(_AIX)
> -+  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
> -+#elif defined(__APPLE__)
> -   return ((int64_t)st.st_mtimespec.tv_sec * 1000000000LL +
> -           st.st_mtimespec.tv_nsec);
> --#elif (_POSIX_C_SOURCE >= 200809L || _XOPEN_SOURCE >= 700 || defined(_BSD_SOURCE) || defined(_SVID_SOURCE) || \
> --       defined(__BIONIC__) || (defined (__SVR4) && defined (__sun)) || defined(__FreeBSD__))
> --  // For glibc, see "Timestamp files" in the Notes of http://www.kernel.org/doc/man-pages/online/pages/man2/stat.2.html
> --  // newlib, uClibc and musl follow the kernel (or Cygwin) headers and define the right macro values above.
> --  // For bsd, see https://github.com/freebsd/freebsd/blob/master/sys/sys/stat.h and similar
> --  // For bionic, C and POSIX API is always enabled.
> --  // For solaris, see https://docs.oracle.com/cd/E88353_01/html/E37841/stat-2.html.
> -+#elif defined(st_mtime) // A macro, so we're likely on modern POSIX.
> -   return (int64_t)st.st_mtim.tv_sec * 1000000000LL + st.st_mtim.tv_nsec;
> --#elif defined(_AIX)
> --  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
> - #else
> -   return (int64_t)st.st_mtime * 1000000000LL + st.st_mtimensec;
> - #endif
> ---
> -2.17.1
> -
> diff --git a/meta/recipes-devtools/ninja/ninja_1.9.0.bb b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
> similarity index 87%
> rename from meta/recipes-devtools/ninja/ninja_1.9.0.bb
> rename to meta/recipes-devtools/ninja/ninja_1.10.0.bb
> index f1236e8ac8..bdc6365052 100644
> --- a/meta/recipes-devtools/ninja/ninja_1.9.0.bb
> +++ b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
> @@ -5,11 +5,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
>
>  DEPENDS = "re2c-native ninja-native"
>
> -SRCREV = "b25c08bda4949192c69cea4cee057887341a2ffc"
> +SRCREV = "ed7f67040b370189d989adbd60ff8ea29957231f"
>
> -SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release \
> -           file://fix-musl.patch \
> -"
> +SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release"
>  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
>
>  S = "${WORKDIR}/git"
> --
> 2.25.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0
  2020-02-25 19:43   ` Andre McCurdy
@ 2020-02-25 19:46     ` Alexander Kanavin
  2020-02-25 19:56       ` Andre McCurdy
  2020-02-25 23:32     ` Khem Raj
  1 sibling, 1 reply; 14+ messages in thread
From: Alexander Kanavin @ 2020-02-25 19:46 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

[-- Attachment #1: Type: text/plain, Size: 5339 bytes --]

These are the commits produced monthly by a tool called Automated Upgrade
Helper and sent directly to recipe maintainers as listed in
maintainers.inc. When maintainers receive the patches, they're supposed to
reset the author to themselves, but sometimes it doesn't happen.

Search for 'auh' in oe-core list for monthly summaries of AUH work.

Alex

On Tue, 25 Feb 2020 at 20:43, Andre McCurdy <armccurdy@gmail.com> wrote:

> On Fri, Feb 21, 2020 at 2:46 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > From: Upgrade Helper <auh@auh.yoctoproject.org>
>
> Why does the author sometimes get set to "Upgrade Helper"? It doesn't
> seem to happen very often (4 times in the past 6 years in oe-core).
> What's special about those 4 cases?
>
> I think it would be clearer if the author was set to whoever ran the tool.
>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  .../ninja/ninja/fix-musl.patch                | 46 -------------------
> >  .../ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} |  6 +--
> >  2 files changed, 2 insertions(+), 50 deletions(-)
> >  delete mode 100644 meta/recipes-devtools/ninja/ninja/fix-musl.patch
> >  rename meta/recipes-devtools/ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb}
> (87%)
> >
> > diff --git a/meta/recipes-devtools/ninja/ninja/fix-musl.patch
> b/meta/recipes-devtools/ninja/ninja/fix-musl.patch
> > deleted file mode 100644
> > index 7fd779110d..0000000000
> > --- a/meta/recipes-devtools/ninja/ninja/fix-musl.patch
> > +++ /dev/null
> > @@ -1,46 +0,0 @@
> > -From e92a915183f8bff268f74c8cd00d986301a2bbf8 Mon Sep 17 00:00:00 2001
> > -From: makepost <makepost@firemail.cc>
> > -Date: Mon, 24 Dec 2018 03:13:16 +0200
> > -Subject: [PATCH] Use st_mtim if st_mtime is macro, fix #1510
> > -
> > -In POSIX.1-2008, sys_stat has a st_mtim member and a st_mtime backward
> > -compatibility macro. Should help avoid hardcoding platform detection.
> > -
> > -Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
> > -
> > -Upstream-Status: Pending
> > ----
> > - src/disk_interface.cc | 14 ++++----------
> > - 1 file changed, 4 insertions(+), 10 deletions(-)
> > -
> > -diff --git a/src/disk_interface.cc b/src/disk_interface.cc
> > -index d4c2fb0..dc297c4 100644
> > ---- a/src/disk_interface.cc
> > -+++ b/src/disk_interface.cc
> > -@@ -202,19 +202,13 @@ TimeStamp RealDiskInterface::Stat(const string&
> path, string* err) const {
> > -   // that it doesn't exist.
> > -   if (st.st_mtime == 0)
> > -     return 1;
> > --#if defined(__APPLE__) && !defined(_POSIX_C_SOURCE)
> > -+#if defined(_AIX)
> > -+  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
> > -+#elif defined(__APPLE__)
> > -   return ((int64_t)st.st_mtimespec.tv_sec * 1000000000LL +
> > -           st.st_mtimespec.tv_nsec);
> > --#elif (_POSIX_C_SOURCE >= 200809L || _XOPEN_SOURCE >= 700 ||
> defined(_BSD_SOURCE) || defined(_SVID_SOURCE) || \
> > --       defined(__BIONIC__) || (defined (__SVR4) && defined (__sun)) ||
> defined(__FreeBSD__))
> > --  // For glibc, see "Timestamp files" in the Notes of
> http://www.kernel.org/doc/man-pages/online/pages/man2/stat.2.html
> > --  // newlib, uClibc and musl follow the kernel (or Cygwin) headers and
> define the right macro values above.
> > --  // For bsd, see
> https://github.com/freebsd/freebsd/blob/master/sys/sys/stat.h and similar
> > --  // For bionic, C and POSIX API is always enabled.
> > --  // For solaris, see
> https://docs.oracle.com/cd/E88353_01/html/E37841/stat-2.html.
> > -+#elif defined(st_mtime) // A macro, so we're likely on modern POSIX.
> > -   return (int64_t)st.st_mtim.tv_sec * 1000000000LL +
> st.st_mtim.tv_nsec;
> > --#elif defined(_AIX)
> > --  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
> > - #else
> > -   return (int64_t)st.st_mtime * 1000000000LL + st.st_mtimensec;
> > - #endif
> > ---
> > -2.17.1
> > -
> > diff --git a/meta/recipes-devtools/ninja/ninja_1.9.0.bb
> b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
> > similarity index 87%
> > rename from meta/recipes-devtools/ninja/ninja_1.9.0.bb
> > rename to meta/recipes-devtools/ninja/ninja_1.10.0.bb
> > index f1236e8ac8..bdc6365052 100644
> > --- a/meta/recipes-devtools/ninja/ninja_1.9.0.bb
> > +++ b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
> > @@ -5,11 +5,9 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
> >
> >  DEPENDS = "re2c-native ninja-native"
> >
> > -SRCREV = "b25c08bda4949192c69cea4cee057887341a2ffc"
> > +SRCREV = "ed7f67040b370189d989adbd60ff8ea29957231f"
> >
> > -SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release \
> > -           file://fix-musl.patch \
> > -"
> > +SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release"
> >  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
> >
> >  S = "${WORKDIR}/git"
> > --
> > 2.25.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 8228 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0
  2020-02-25 19:46     ` Alexander Kanavin
@ 2020-02-25 19:56       ` Andre McCurdy
  2020-02-25 20:25         ` Alexander Kanavin
  0 siblings, 1 reply; 14+ messages in thread
From: Andre McCurdy @ 2020-02-25 19:56 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: OE Core mailing list

On Tue, Feb 25, 2020 at 11:47 AM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> These are the commits produced monthly by a tool called Automated Upgrade Helper and sent directly to recipe maintainers as listed in maintainers.inc. When maintainers receive the patches, they're supposed to reset the author to themselves, but sometimes it doesn't happen.
>
> Search for 'auh' in oe-core list for monthly summaries of AUH work.

Thanks. The maintainers sometimes forgetting to reset the author was
the part I was missing. Maybe the patch checker could be updated to
check for that?

> Alex
>
> On Tue, 25 Feb 2020 at 20:43, Andre McCurdy <armccurdy@gmail.com> wrote:
>>
>> On Fri, Feb 21, 2020 at 2:46 PM Khem Raj <raj.khem@gmail.com> wrote:
>> >
>> > From: Upgrade Helper <auh@auh.yoctoproject.org>
>>
>> Why does the author sometimes get set to "Upgrade Helper"? It doesn't
>> seem to happen very often (4 times in the past 6 years in oe-core).
>> What's special about those 4 cases?
>>
>> I think it would be clearer if the author was set to whoever ran the tool.
>>
>> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> > ---
>> >  .../ninja/ninja/fix-musl.patch                | 46 -------------------
>> >  .../ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} |  6 +--
>> >  2 files changed, 2 insertions(+), 50 deletions(-)
>> >  delete mode 100644 meta/recipes-devtools/ninja/ninja/fix-musl.patch
>> >  rename meta/recipes-devtools/ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} (87%)
>> >
>> > diff --git a/meta/recipes-devtools/ninja/ninja/fix-musl.patch b/meta/recipes-devtools/ninja/ninja/fix-musl.patch
>> > deleted file mode 100644
>> > index 7fd779110d..0000000000
>> > --- a/meta/recipes-devtools/ninja/ninja/fix-musl.patch
>> > +++ /dev/null
>> > @@ -1,46 +0,0 @@
>> > -From e92a915183f8bff268f74c8cd00d986301a2bbf8 Mon Sep 17 00:00:00 2001
>> > -From: makepost <makepost@firemail.cc>
>> > -Date: Mon, 24 Dec 2018 03:13:16 +0200
>> > -Subject: [PATCH] Use st_mtim if st_mtime is macro, fix #1510
>> > -
>> > -In POSIX.1-2008, sys_stat has a st_mtim member and a st_mtime backward
>> > -compatibility macro. Should help avoid hardcoding platform detection.
>> > -
>> > -Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
>> > -
>> > -Upstream-Status: Pending
>> > ----
>> > - src/disk_interface.cc | 14 ++++----------
>> > - 1 file changed, 4 insertions(+), 10 deletions(-)
>> > -
>> > -diff --git a/src/disk_interface.cc b/src/disk_interface.cc
>> > -index d4c2fb0..dc297c4 100644
>> > ---- a/src/disk_interface.cc
>> > -+++ b/src/disk_interface.cc
>> > -@@ -202,19 +202,13 @@ TimeStamp RealDiskInterface::Stat(const string& path, string* err) const {
>> > -   // that it doesn't exist.
>> > -   if (st.st_mtime == 0)
>> > -     return 1;
>> > --#if defined(__APPLE__) && !defined(_POSIX_C_SOURCE)
>> > -+#if defined(_AIX)
>> > -+  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
>> > -+#elif defined(__APPLE__)
>> > -   return ((int64_t)st.st_mtimespec.tv_sec * 1000000000LL +
>> > -           st.st_mtimespec.tv_nsec);
>> > --#elif (_POSIX_C_SOURCE >= 200809L || _XOPEN_SOURCE >= 700 || defined(_BSD_SOURCE) || defined(_SVID_SOURCE) || \
>> > --       defined(__BIONIC__) || (defined (__SVR4) && defined (__sun)) || defined(__FreeBSD__))
>> > --  // For glibc, see "Timestamp files" in the Notes of http://www.kernel.org/doc/man-pages/online/pages/man2/stat.2.html
>> > --  // newlib, uClibc and musl follow the kernel (or Cygwin) headers and define the right macro values above.
>> > --  // For bsd, see https://github.com/freebsd/freebsd/blob/master/sys/sys/stat.h and similar
>> > --  // For bionic, C and POSIX API is always enabled.
>> > --  // For solaris, see https://docs.oracle.com/cd/E88353_01/html/E37841/stat-2.html.
>> > -+#elif defined(st_mtime) // A macro, so we're likely on modern POSIX.
>> > -   return (int64_t)st.st_mtim.tv_sec * 1000000000LL + st.st_mtim.tv_nsec;
>> > --#elif defined(_AIX)
>> > --  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
>> > - #else
>> > -   return (int64_t)st.st_mtime * 1000000000LL + st.st_mtimensec;
>> > - #endif
>> > ---
>> > -2.17.1
>> > -
>> > diff --git a/meta/recipes-devtools/ninja/ninja_1.9.0.bb b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
>> > similarity index 87%
>> > rename from meta/recipes-devtools/ninja/ninja_1.9.0.bb
>> > rename to meta/recipes-devtools/ninja/ninja_1.10.0.bb
>> > index f1236e8ac8..bdc6365052 100644
>> > --- a/meta/recipes-devtools/ninja/ninja_1.9.0.bb
>> > +++ b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
>> > @@ -5,11 +5,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
>> >
>> >  DEPENDS = "re2c-native ninja-native"
>> >
>> > -SRCREV = "b25c08bda4949192c69cea4cee057887341a2ffc"
>> > +SRCREV = "ed7f67040b370189d989adbd60ff8ea29957231f"
>> >
>> > -SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release \
>> > -           file://fix-musl.patch \
>> > -"
>> > +SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release"
>> >  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
>> >
>> >  S = "${WORKDIR}/git"
>> > --
>> > 2.25.1
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-core mailing list
>> > Openembedded-core@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0
  2020-02-25 19:56       ` Andre McCurdy
@ 2020-02-25 20:25         ` Alexander Kanavin
  2020-02-25 20:56           ` Andre McCurdy
  0 siblings, 1 reply; 14+ messages in thread
From: Alexander Kanavin @ 2020-02-25 20:25 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

On Tue, 25 Feb 2020 at 20:57, Andre McCurdy <armccurdy@gmail.com> wrote:

> Thanks. The maintainers sometimes forgetting to reset the author was
> the part I was missing. Maybe the patch checker could be updated to
> check for that?
>

The patch checker already does this too :)

Alex

[-- Attachment #2: Type: text/html, Size: 600 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0
  2020-02-25 20:25         ` Alexander Kanavin
@ 2020-02-25 20:56           ` Andre McCurdy
  2020-02-25 21:01             ` Alexander Kanavin
  0 siblings, 1 reply; 14+ messages in thread
From: Andre McCurdy @ 2020-02-25 20:56 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: OE Core mailing list

On Tue, Feb 25, 2020 at 12:25 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> On Tue, 25 Feb 2020 at 20:57, Andre McCurdy <armccurdy@gmail.com> wrote:
>>
>> Thanks. The maintainers sometimes forgetting to reset the author was
>> the part I was missing. Maybe the patch checker could be updated to
>> check for that?
>
> The patch checker already does this too :)

So how did this commit get through?


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0
  2020-02-25 20:56           ` Andre McCurdy
@ 2020-02-25 21:01             ` Alexander Kanavin
  2020-02-25 21:13               ` Andre McCurdy
  0 siblings, 1 reply; 14+ messages in thread
From: Alexander Kanavin @ 2020-02-25 21:01 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

On Tue, 25 Feb 2020 at 21:57, Andre McCurdy <armccurdy@gmail.com> wrote:

> >> Thanks. The maintainers sometimes forgetting to reset the author was
> >> the part I was missing. Maybe the patch checker could be updated to
> >> check for that?
> >
> > The patch checker already does this too :)
>
> So how did this commit get through?
>

Patch checker sends suggestions to the mailing list and doesn't block
commits from getting into master-next, and then master.

Alex

[-- Attachment #2: Type: text/html, Size: 829 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0
  2020-02-25 21:01             ` Alexander Kanavin
@ 2020-02-25 21:13               ` Andre McCurdy
  0 siblings, 0 replies; 14+ messages in thread
From: Andre McCurdy @ 2020-02-25 21:13 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: OE Core mailing list

On Tue, Feb 25, 2020 at 1:01 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> On Tue, 25 Feb 2020 at 21:57, Andre McCurdy <armccurdy@gmail.com> wrote:
>>
>> >> Thanks. The maintainers sometimes forgetting to reset the author was
>> >> the part I was missing. Maybe the patch checker could be updated to
>> >> check for that?
>> >
>> > The patch checker already does this too :)
>>
>> So how did this commit get through?
>
> Patch checker sends suggestions to the mailing list and doesn't block commits from getting into master-next, and then master.

OK. I suppose in the end getting this right isn't a high priority so
no need to dissect any further. Thanks!


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0
  2020-02-25 19:43   ` Andre McCurdy
  2020-02-25 19:46     ` Alexander Kanavin
@ 2020-02-25 23:32     ` Khem Raj
  1 sibling, 0 replies; 14+ messages in thread
From: Khem Raj @ 2020-02-25 23:32 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: Upgrade Helper, OE Core mailing list

On Tue, Feb 25, 2020 at 11:43 AM Andre McCurdy <armccurdy@gmail.com> wrote:
>
> On Fri, Feb 21, 2020 at 2:46 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > From: Upgrade Helper <auh@auh.yoctoproject.org>
>
> Why does the author sometimes get set to "Upgrade Helper"? It doesn't
> seem to happen very often (4 times in the past 6 years in oe-core).
> What's special about those 4 cases?

well this was an oversight on my part, since the next steps in the
email did suggest

    - amend the patch and sign it off: git commit -s --reset-author --amend

I only did git am -s and then testing

but on a lighter note, it might be worth giving credit to Upgrade
Helper since it did
author the patch, perhaps will keep the AI in these machines happy.

>
> I think it would be clearer if the author was set to whoever ran the tool.
>
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  .../ninja/ninja/fix-musl.patch                | 46 -------------------
> >  .../ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} |  6 +--
> >  2 files changed, 2 insertions(+), 50 deletions(-)
> >  delete mode 100644 meta/recipes-devtools/ninja/ninja/fix-musl.patch
> >  rename meta/recipes-devtools/ninja/{ninja_1.9.0.bb => ninja_1.10.0.bb} (87%)
> >
> > diff --git a/meta/recipes-devtools/ninja/ninja/fix-musl.patch b/meta/recipes-devtools/ninja/ninja/fix-musl.patch
> > deleted file mode 100644
> > index 7fd779110d..0000000000
> > --- a/meta/recipes-devtools/ninja/ninja/fix-musl.patch
> > +++ /dev/null
> > @@ -1,46 +0,0 @@
> > -From e92a915183f8bff268f74c8cd00d986301a2bbf8 Mon Sep 17 00:00:00 2001
> > -From: makepost <makepost@firemail.cc>
> > -Date: Mon, 24 Dec 2018 03:13:16 +0200
> > -Subject: [PATCH] Use st_mtim if st_mtime is macro, fix #1510
> > -
> > -In POSIX.1-2008, sys_stat has a st_mtim member and a st_mtime backward
> > -compatibility macro. Should help avoid hardcoding platform detection.
> > -
> > -Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
> > -
> > -Upstream-Status: Pending
> > ----
> > - src/disk_interface.cc | 14 ++++----------
> > - 1 file changed, 4 insertions(+), 10 deletions(-)
> > -
> > -diff --git a/src/disk_interface.cc b/src/disk_interface.cc
> > -index d4c2fb0..dc297c4 100644
> > ---- a/src/disk_interface.cc
> > -+++ b/src/disk_interface.cc
> > -@@ -202,19 +202,13 @@ TimeStamp RealDiskInterface::Stat(const string& path, string* err) const {
> > -   // that it doesn't exist.
> > -   if (st.st_mtime == 0)
> > -     return 1;
> > --#if defined(__APPLE__) && !defined(_POSIX_C_SOURCE)
> > -+#if defined(_AIX)
> > -+  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
> > -+#elif defined(__APPLE__)
> > -   return ((int64_t)st.st_mtimespec.tv_sec * 1000000000LL +
> > -           st.st_mtimespec.tv_nsec);
> > --#elif (_POSIX_C_SOURCE >= 200809L || _XOPEN_SOURCE >= 700 || defined(_BSD_SOURCE) || defined(_SVID_SOURCE) || \
> > --       defined(__BIONIC__) || (defined (__SVR4) && defined (__sun)) || defined(__FreeBSD__))
> > --  // For glibc, see "Timestamp files" in the Notes of http://www.kernel.org/doc/man-pages/online/pages/man2/stat.2.html
> > --  // newlib, uClibc and musl follow the kernel (or Cygwin) headers and define the right macro values above.
> > --  // For bsd, see https://github.com/freebsd/freebsd/blob/master/sys/sys/stat.h and similar
> > --  // For bionic, C and POSIX API is always enabled.
> > --  // For solaris, see https://docs.oracle.com/cd/E88353_01/html/E37841/stat-2.html.
> > -+#elif defined(st_mtime) // A macro, so we're likely on modern POSIX.
> > -   return (int64_t)st.st_mtim.tv_sec * 1000000000LL + st.st_mtim.tv_nsec;
> > --#elif defined(_AIX)
> > --  return (int64_t)st.st_mtime * 1000000000LL + st.st_mtime_n;
> > - #else
> > -   return (int64_t)st.st_mtime * 1000000000LL + st.st_mtimensec;
> > - #endif
> > ---
> > -2.17.1
> > -
> > diff --git a/meta/recipes-devtools/ninja/ninja_1.9.0.bb b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
> > similarity index 87%
> > rename from meta/recipes-devtools/ninja/ninja_1.9.0.bb
> > rename to meta/recipes-devtools/ninja/ninja_1.10.0.bb
> > index f1236e8ac8..bdc6365052 100644
> > --- a/meta/recipes-devtools/ninja/ninja_1.9.0.bb
> > +++ b/meta/recipes-devtools/ninja/ninja_1.10.0.bb
> > @@ -5,11 +5,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a81586a64ad4e476c791cda7e2f2c52e"
> >
> >  DEPENDS = "re2c-native ninja-native"
> >
> > -SRCREV = "b25c08bda4949192c69cea4cee057887341a2ffc"
> > +SRCREV = "ed7f67040b370189d989adbd60ff8ea29957231f"
> >
> > -SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release \
> > -           file://fix-musl.patch \
> > -"
> > +SRC_URI = "git://github.com/ninja-build/ninja.git;branch=release"
> >  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>.*)"
> >
> >  S = "${WORKDIR}/git"
> > --
> > 2.25.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-02-25 23:33 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 22:45 [PATCH 0/4] Misc AUH suggested package upgrades Khem Raj
2020-02-21 22:45 ` [PATCH 1/4] libxcrypt: Upgrade to 4.4.14 release Khem Raj
2020-02-21 22:45 ` [PATCH 2/4] ninja: upgrade 1.9.0 -> 1.10.0 Khem Raj
2020-02-25 19:43   ` Andre McCurdy
2020-02-25 19:46     ` Alexander Kanavin
2020-02-25 19:56       ` Andre McCurdy
2020-02-25 20:25         ` Alexander Kanavin
2020-02-25 20:56           ` Andre McCurdy
2020-02-25 21:01             ` Alexander Kanavin
2020-02-25 21:13               ` Andre McCurdy
2020-02-25 23:32     ` Khem Raj
2020-02-21 22:45 ` [PATCH 3/4] go: Upgrade to 1.13.8 minor release Khem Raj
2020-02-21 22:45 ` [PATCH 4/4] gmp: Upgrade to 6.2.0 Khem Raj
2020-02-21 23:02 ` ✗ patchtest: failure for Misc AUH suggested package upgrades Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.