[PATCH] hwrng: imx-rngc: improve dependencies

[PATCH] hwrng: imx-rngc: improve dependencies

[Uwe Kleine-König]

The imx-rngc driver binds to devices that are compatible to
"fsl,imx25-rngb". Grepping through the device tree sources suggests this
only exists on i.MX25. So restrict dependencies to configs that have
this SoC enabled, but allow compile testing. For the latter additional
dependencies for clk and readl/writel are necessary.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/char/hw_random/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 8486c29d8324..17fe954fccde 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -244,7 +244,8 @@ config HW_RANDOM_MXC_RNGA
 
 config HW_RANDOM_IMX_RNGC
 	tristate "Freescale i.MX RNGC Random Number Generator"
-	depends on ARCH_MXC
+	depends on HAS_IOMEM && HAVE_CLK
+	depends on SOC_IMX25 || COMPILE_TEST
 	default HW_RANDOM
 	---help---
 	  This driver provides kernel-side support for the Random Number
-- 
2.24.0

Re: [PATCH] hwrng: imx-rngc: improve dependencies

[Horia Geanta]

On 2/5/2020 4:00 PM, Uwe Kleine-König wrote:
> The imx-rngc driver binds to devices that are compatible to
> "fsl,imx25-rngb". Grepping through the device tree sources suggests this
> only exists on i.MX25. So restrict dependencies to configs that have
The driver could also be used by some i.MX6 SoCs (SL, SLL),
that have a compatible rngb.

Actually i.MX6SL has a rngb node in the DT, but unfortunately it lacks
a compatible string.

I am planning to address this short term.

> this SoC enabled, but allow compile testing. For the latter additional
> dependencies for clk and readl/writel are necessary.
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/char/hw_random/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 8486c29d8324..17fe954fccde 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -244,7 +244,8 @@ config HW_RANDOM_MXC_RNGA
>  
>  config HW_RANDOM_IMX_RNGC
>  	tristate "Freescale i.MX RNGC Random Number Generator"
> -	depends on ARCH_MXC
> +	depends on HAS_IOMEM && HAVE_CLK
> +	depends on SOC_IMX25 || COMPILE_TEST
I guess SOC_IMX6SL and SOC_IMX6SLL will have to be added.
Does this sound good?

Thanks,
Horia

Re: [PATCH] hwrng: imx-rngc: improve dependencies

[Uwe Kleine-König]

On Wed, Feb 12, 2020 at 07:51:46PM +0000, Horia Geanta wrote:
> On 2/5/2020 4:00 PM, Uwe Kleine-König wrote:
> > The imx-rngc driver binds to devices that are compatible to
> > "fsl,imx25-rngb". Grepping through the device tree sources suggests this
> > only exists on i.MX25. So restrict dependencies to configs that have
> The driver could also be used by some i.MX6 SoCs (SL, SLL),
> that have a compatible rngb.
> 
> Actually i.MX6SL has a rngb node in the DT, but unfortunately it lacks
> a compatible string.

Also the i.MX6ULL might have a compatible device?

> I am planning to address this short term.
> 
> > this SoC enabled, but allow compile testing. For the latter additional
> > dependencies for clk and readl/writel are necessary.
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  drivers/char/hw_random/Kconfig | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> > index 8486c29d8324..17fe954fccde 100644
> > --- a/drivers/char/hw_random/Kconfig
> > +++ b/drivers/char/hw_random/Kconfig
> > @@ -244,7 +244,8 @@ config HW_RANDOM_MXC_RNGA
> >  
> >  config HW_RANDOM_IMX_RNGC
> >  	tristate "Freescale i.MX RNGC Random Number Generator"
> > -	depends on ARCH_MXC
> > +	depends on HAS_IOMEM && HAVE_CLK
> > +	depends on SOC_IMX25 || COMPILE_TEST
> I guess SOC_IMX6SL and SOC_IMX6SLL will have to be added.
> Does this sound good?

I'd say currently the patch is right and once the device trees for the
imx6 variants were expanded to include these, the list here can be
expanded.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Re: [PATCH] hwrng: imx-rngc: improve dependencies

[Herbert Xu]

On Wed, Feb 05, 2020 at 03:00:02PM +0100, Uwe Kleine-König wrote:
> The imx-rngc driver binds to devices that are compatible to
> "fsl,imx25-rngb". Grepping through the device tree sources suggests this
> only exists on i.MX25. So restrict dependencies to configs that have
> this SoC enabled, but allow compile testing. For the latter additional
> dependencies for clk and readl/writel are necessary.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/char/hw_random/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: imx-rngc: improve dependencies

[Martin Kaiser]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1927 bytes --]

Thus wrote Uwe Kleine-König (u.kleine-koenigpengutronix!de):

> On Wed, Feb 12, 2020 at 07:51:46PM +0000, Horia Geanta wrote:
> > On 2/5/2020 4:00 PM, Uwe Kleine-König wrote:
> > > The imx-rngc driver binds to devices that are compatible to
> > > "fsl,imx25-rngb". Grepping through the device tree sources suggests this
> > > only exists on i.MX25. So restrict dependencies to configs that have
> > The driver could also be used by some i.MX6 SoCs (SL, SLL),
> > that have a compatible rngb.

> > Actually i.MX6SL has a rngb node in the DT, but unfortunately it lacks
> > a compatible string.

> Also the i.MX6ULL might have a compatible device?

AFAICS imx35 chips have an rngc which is compatible to this driver as
well. I don't have any hardware to test this, though.

> > I am planning to address this short term.

> > > this SoC enabled, but allow compile testing. For the latter additional
> > > dependencies for clk and readl/writel are necessary.
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> > >  drivers/char/hw_random/Kconfig | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)

> > > diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> > > index 8486c29d8324..17fe954fccde 100644
> > > --- a/drivers/char/hw_random/Kconfig
> > > +++ b/drivers/char/hw_random/Kconfig
> > > @@ -244,7 +244,8 @@ config HW_RANDOM_MXC_RNGA

> > >  config HW_RANDOM_IMX_RNGC
> > >  	tristate "Freescale i.MX RNGC Random Number Generator"
> > > -	depends on ARCH_MXC
> > > +	depends on HAS_IOMEM && HAVE_CLK
> > > +	depends on SOC_IMX25 || COMPILE_TEST
> > I guess SOC_IMX6SL and SOC_IMX6SLL will have to be added.
> > Does this sound good?

> I'd say currently the patch is right and once the device trees for the
> imx6 variants were expanded to include these, the list here can be
> expanded.

Makes sense to me.

Reviewed-by: Martin Kaiser <martin@kaiser.cx>