* [Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps
@ 2020-02-22 10:38 Yann E. MORIN
2020-02-22 10:59 ` Thomas De Schampheleire
0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2020-02-22 10:38 UTC (permalink / raw)
To: buildroot
Commit 509db3b88a added calls to (parts of) the instrumentation steps.
However, those calls are echoed, unlike the other places where we call
them (in the package infra).
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
---
Makefile | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 9662987bb4..b61a20a354 100644
--- a/Makefile
+++ b/Makefile
@@ -807,12 +807,12 @@ endif # merged /usr
# AFTER ALL FILE-CHANGING ACTIONS:
# Update timestamps in internal file list to fix attribution of files
# to packages on subsequent builds
- $(call step_pkg_size_file_list,$(TARGET_DIR))
- $(call step_pkg_size_finalize)
- $(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
- $(call step_pkg_size_finalize,-staging)
- $(call step_pkg_size_file_list,$(HOST_DIR),-host)
- $(call step_pkg_size_finalize,-host)
+ @$(call step_pkg_size_file_list,$(TARGET_DIR))
+ @$(call step_pkg_size_finalize)
+ @$(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
+ @$(call step_pkg_size_finalize,-staging)
+ @$(call step_pkg_size_file_list,$(HOST_DIR),-host)
+ @$(call step_pkg_size_finalize,-host)
.PHONY: target-post-image
target-post-image: $(TARGETS_ROOTFS) target-finalize staging-finalize
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps
2020-02-22 10:38 [Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps Yann E. MORIN
@ 2020-02-22 10:59 ` Thomas De Schampheleire
2020-02-22 11:05 ` Yann E. MORIN
0 siblings, 1 reply; 7+ messages in thread
From: Thomas De Schampheleire @ 2020-02-22 10:59 UTC (permalink / raw)
To: buildroot
Hi Yann,
On Sat, Feb 22, 2020, 11:38 Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Commit 509db3b88a added calls to (parts of) the instrumentation steps.
> However, those calls are echoed, unlike the other places where we call
> them (in the package infra).
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> ---
> Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9662987bb4..b61a20a354 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -807,12 +807,12 @@ endif # merged /usr
> # AFTER ALL FILE-CHANGING ACTIONS:
> # Update timestamps in internal file list to fix attribution of files
> # to packages on subsequent builds
> - $(call step_pkg_size_file_list,$(TARGET_DIR))
> - $(call step_pkg_size_finalize)
> - $(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> - $(call step_pkg_size_finalize,-staging)
> - $(call step_pkg_size_file_list,$(HOST_DIR),-host)
> - $(call step_pkg_size_finalize,-host)
> + @$(call step_pkg_size_file_list,$(TARGET_DIR))
> + @$(call step_pkg_size_finalize)
> + @$(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> + @$(call step_pkg_size_finalize,-staging)
> + @$(call step_pkg_size_file_list,$(HOST_DIR),-host)
> + @$(call step_pkg_size_finalize,-host)
Perhaps this should rather be $(Q) than @?
I quite like the fact that you can see what's going on, mostly relevant
when investigating an issue...
Thanks,
Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200222/ef78015e/attachment.html>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps
2020-02-22 10:59 ` Thomas De Schampheleire
@ 2020-02-22 11:05 ` Yann E. MORIN
2020-02-22 20:17 ` Thomas De Schampheleire
0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2020-02-22 11:05 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-02-22 11:59 +0100, Thomas De Schampheleire spake thusly:
> On Sat, Feb 22, 2020, 11:38 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote:
>
> Commit 509db3b88a added calls to (parts of) the instrumentation steps.
> However, those calls are echoed, unlike the other places where we call
> them (in the package infra).
>
> Signed-off-by: Yann E. MORIN < [2]yann.morin.1998@free.fr>
> Cc: Thomas De Schampheleire < [3]patrickdepinguin@gmail.com>
> ---
> ?Makefile | 12 ++++++------
> ?1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9662987bb4..b61a20a354 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -807,12 +807,12 @@ endif # merged /usr
> ?# AFTER ALL FILE-CHANGING ACTIONS:
> ?# Update timestamps in internal file list to fix attribution of files
> ?# to packages on subsequent builds
> -? ? ? ?$(call step_pkg_size_file_list,$(TARGET_DIR))
> -? ? ? ?$(call step_pkg_size_finalize)
> -? ? ? ?$(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> -? ? ? ?$(call step_pkg_size_finalize,-staging)
> -? ? ? ?$(call step_pkg_size_file_list,$(HOST_DIR),-host)
> -? ? ? ?$(call step_pkg_size_finalize,-host)
> +? ? ? ?@$(call step_pkg_size_file_list,$(TARGET_DIR))
> +? ? ? ?@$(call step_pkg_size_finalize)
> +? ? ? ?@$(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> +? ? ? ?@$(call step_pkg_size_finalize,-staging)
> +? ? ? ?@$(call step_pkg_size_file_list,$(HOST_DIR),-host)
> +? ? ? ?@$(call step_pkg_size_finalize,-host)
>
> Perhaps this should rather be $(Q) than @?
We're using @ in all other places where we call the hooks, and this
patch is just doing the same here. If we want $(Q) here (which I think
is a good idea), we'd want to *also* change the existing calls to steps
in the package infra at the same time.
I just want to have a minimalist patch here, that aligns the very recent
changes to the long-existing code.
> I quite like the fact that you can see what's going on, mostly relevant
> when investigating an issue...
Yes, I do agree.
Care to send a patch afterwards, that changes the existing code? ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps
2020-02-22 11:05 ` Yann E. MORIN
@ 2020-02-22 20:17 ` Thomas De Schampheleire
2020-02-22 20:28 ` Yann E. MORIN
0 siblings, 1 reply; 7+ messages in thread
From: Thomas De Schampheleire @ 2020-02-22 20:17 UTC (permalink / raw)
To: buildroot
El s?b., 22 feb. 2020 a las 12:05, Yann E. MORIN
(<yann.morin.1998@free.fr>) escribi?:
>
> Thomas, All,
>
> On 2020-02-22 11:59 +0100, Thomas De Schampheleire spake thusly:
> > On Sat, Feb 22, 2020, 11:38 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote:
> >
> > Commit 509db3b88a added calls to (parts of) the instrumentation steps.
> > However, those calls are echoed, unlike the other places where we call
> > them (in the package infra).
> >
> > Signed-off-by: Yann E. MORIN < [2]yann.morin.1998@free.fr>
> > Cc: Thomas De Schampheleire < [3]patrickdepinguin@gmail.com>
> > ---
> > Makefile | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 9662987bb4..b61a20a354 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -807,12 +807,12 @@ endif # merged /usr
> > # AFTER ALL FILE-CHANGING ACTIONS:
> > # Update timestamps in internal file list to fix attribution of files
> > # to packages on subsequent builds
> > - $(call step_pkg_size_file_list,$(TARGET_DIR))
> > - $(call step_pkg_size_finalize)
> > - $(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> > - $(call step_pkg_size_finalize,-staging)
> > - $(call step_pkg_size_file_list,$(HOST_DIR),-host)
> > - $(call step_pkg_size_finalize,-host)
> > + @$(call step_pkg_size_file_list,$(TARGET_DIR))
> > + @$(call step_pkg_size_finalize)
> > + @$(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> > + @$(call step_pkg_size_finalize,-staging)
> > + @$(call step_pkg_size_file_list,$(HOST_DIR),-host)
> > + @$(call step_pkg_size_finalize,-host)
> >
> > Perhaps this should rather be $(Q) than @?
>
> We're using @ in all other places where we call the hooks, and this
> patch is just doing the same here. If we want $(Q) here (which I think
> is a good idea), we'd want to *also* change the existing calls to steps
> in the package infra at the same time.
>
> I just want to have a minimalist patch here, that aligns the very recent
> changes to the long-existing code.
>
> > I quite like the fact that you can see what's going on, mostly relevant
> > when investigating an issue...
>
> Yes, I do agree.
>
> Care to send a patch afterwards, that changes the existing code? ;-)
Sure, I can do that.
Best regards,
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps
2020-02-22 20:17 ` Thomas De Schampheleire
@ 2020-02-22 20:28 ` Yann E. MORIN
2020-02-22 21:14 ` Thomas De Schampheleire
0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2020-02-22 20:28 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-02-22 21:17 +0100, Thomas De Schampheleire spake thusly:
> El s?b., 22 feb. 2020 a las 12:05, Yann E. MORIN
> (<yann.morin.1998@free.fr>) escribi?:
> > On 2020-02-22 11:59 +0100, Thomas De Schampheleire spake thusly:
> > > On Sat, Feb 22, 2020, 11:38 Yann E. MORIN < [1]yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > > + @$(call step_pkg_size_file_list,$(TARGET_DIR))
> > > + @$(call step_pkg_size_finalize)
> > > + @$(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> > > + @$(call step_pkg_size_finalize,-staging)
> > > + @$(call step_pkg_size_file_list,$(HOST_DIR),-host)
> > > + @$(call step_pkg_size_finalize,-host)
> > >
> > > Perhaps this should rather be $(Q) than @?
[--SNIP--]
> > Care to send a patch afterwards, that changes the existing code? ;-)
> Sure, I can do that.
Is that an Acked-by or Reviewed-by from you on my patch, then? ;-)
Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps
2020-02-22 20:28 ` Yann E. MORIN
@ 2020-02-22 21:14 ` Thomas De Schampheleire
2020-02-22 21:30 ` Yann E. MORIN
0 siblings, 1 reply; 7+ messages in thread
From: Thomas De Schampheleire @ 2020-02-22 21:14 UTC (permalink / raw)
To: buildroot
On Sat, Feb 22, 2020, 21:28 Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Thomas, All,
>
> On 2020-02-22 21:17 +0100, Thomas De Schampheleire spake thusly:
> > El s?b., 22 feb. 2020 a las 12:05, Yann E. MORIN
> > (<yann.morin.1998@free.fr>) escribi?:
> > > On 2020-02-22 11:59 +0100, Thomas De Schampheleire spake thusly:
> > > > On Sat, Feb 22, 2020, 11:38 Yann E. MORIN < [1]
> yann.morin.1998 at free.fr> wrote:
> [--SNIP--]
> > > > + @$(call step_pkg_size_file_list,$(TARGET_DIR))
> > > > + @$(call step_pkg_size_finalize)
> > > > + @$(call step_pkg_size_file_list,$(STAGING_DIR),-staging)
> > > > + @$(call step_pkg_size_finalize,-staging)
> > > > + @$(call step_pkg_size_file_list,$(HOST_DIR),-host)
> > > > + @$(call step_pkg_size_finalize,-host)
> > > >
> > > > Perhaps this should rather be $(Q) than @?
> [--SNIP--]
> > > Care to send a patch afterwards, that changes the existing code? ;-)
> > Sure, I can do that.
>
> Is that an Acked-by or Reviewed-by from you on my patch, then? ;-)
>
Yep:
>
Acked-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200222/7a4f5d26/attachment.html>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps
2020-02-22 21:14 ` Thomas De Schampheleire
@ 2020-02-22 21:30 ` Yann E. MORIN
0 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2020-02-22 21:30 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-02-22 22:14 +0100, Thomas De Schampheleire spake thusly:
> Acked-by: Thomas De Schampheleire < [4]thomas.de_schampheleire@nokia.com>
Applied to master, thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-02-22 21:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-22 10:38 [Buildroot] [PATCH] infra: don't be verbose when calling the instrumentation steps Yann E. MORIN
2020-02-22 10:59 ` Thomas De Schampheleire
2020-02-22 11:05 ` Yann E. MORIN
2020-02-22 20:17 ` Thomas De Schampheleire
2020-02-22 20:28 ` Yann E. MORIN
2020-02-22 21:14 ` Thomas De Schampheleire
2020-02-22 21:30 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.