All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: musb: remove redundant assignment to variable ret
  2019-07-31 22:39 ` Colin King
  (?)
  (?)
@ 2020-02-22 13:54 ` Colin King
  -1 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2020-02-22 13:54 UTC (permalink / raw)
  To: Bin Liu, Greg Kroah-Hartman, Matthias Brugger, linux-usb,
	linux-arm-kernel, linux-mediatek
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Variable ret is being initialized with a value that is never read,
it is assigned a new value later on. The assignment is redundant
and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/usb/musb/mediatek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c
index 6b88c2f5d970..6af3a346d4ce 100644
--- a/drivers/usb/musb/mediatek.c
+++ b/drivers/usb/musb/mediatek.c
@@ -444,7 +444,7 @@ static int mtk_musb_probe(struct platform_device *pdev)
 	struct platform_device_info pinfo;
 	struct device *dev = &pdev->dev;
 	struct device_node *np = dev->of_node;
-	int ret = -ENOMEM;
+	int ret;
 
 	glue = devm_kzalloc(dev, sizeof(*glue), GFP_KERNEL);
 	if (!glue)
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] usb: musb: remove redundant assignment to variable ret
@ 2019-07-31 22:39 ` Colin King
  0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2019-07-31 22:39 UTC (permalink / raw)
  To: Bin Liu, Greg Kroah-Hartman, linux-usb; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Variable ret is being initialized with a value that is never read
and ret is being re-assigned a little later on. The assignment is
redundant and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/usb/musb/musb_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 9f5a4819a744..2bc55e0ceace 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1721,7 +1721,7 @@ mode_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
 	struct musb *musb = dev_to_musb(dev);
 	unsigned long flags;
-	int ret = -EINVAL;
+	int ret;
 
 	spin_lock_irqsave(&musb->lock, flags);
 	ret = sprintf(buf, "%s\n", usb_otg_state_string(musb->xceiv->otg->state));
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-02-24 21:12 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-22 13:54 [PATCH] usb: musb: remove redundant assignment to variable ret Colin King
2020-02-22 13:54 ` Colin King
2020-02-22 13:54 ` Colin King
2020-02-22 13:54 ` Colin King
2020-02-24 21:12 ` Bin Liu
2020-02-24 21:12   ` Bin Liu
2020-02-24 21:12   ` Bin Liu
2020-02-24 21:12   ` Bin Liu
  -- strict thread matches above, loose matches on Subject: below --
2019-07-31 22:39 Colin King
2019-07-31 22:39 ` Colin King

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.