* [PATCH] fpga: zynq: Remove clk_get error message for probe defer
@ 2020-02-12 14:17 ` Michal Simek
0 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2020-02-12 14:17 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Shubhrajyoti Datta, Moritz Fischer, linux-arm-kernel, linux-fpga
From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
In probe, the driver checks for devm_clk_get return and print error
message in the failing case. However for -EPROBE_DEFER this message is
confusing so avoid it.
The similar change was done also by commit 28910cee898c
("fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer")
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/fpga/zynq-fpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index ee7765049607..07fa8d9ec675 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev)
priv->clk = devm_clk_get(dev, "ref_clk");
if (IS_ERR(priv->clk)) {
- dev_err(dev, "input clock not found\n");
+ if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
+ dev_err(dev, "input clock not found\n");
return PTR_ERR(priv->clk);
}
--
2.25.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] fpga: zynq: Remove clk_get error message for probe defer
@ 2020-02-12 14:17 ` Michal Simek
0 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2020-02-12 14:17 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Moritz Fischer, linux-fpga, Shubhrajyoti Datta, linux-arm-kernel
From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
In probe, the driver checks for devm_clk_get return and print error
message in the failing case. However for -EPROBE_DEFER this message is
confusing so avoid it.
The similar change was done also by commit 28910cee898c
("fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer")
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
drivers/fpga/zynq-fpga.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index ee7765049607..07fa8d9ec675 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev)
priv->clk = devm_clk_get(dev, "ref_clk");
if (IS_ERR(priv->clk)) {
- dev_err(dev, "input clock not found\n");
+ if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
+ dev_err(dev, "input clock not found\n");
return PTR_ERR(priv->clk);
}
--
2.25.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] fpga: zynq: Remove clk_get error message for probe defer
2020-02-12 14:17 ` Michal Simek
@ 2020-02-21 10:37 ` Michal Simek
-1 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2020-02-21 10:37 UTC (permalink / raw)
To: Michal Simek, linux-kernel, monstr, git, Moritz Fischer
Cc: Shubhrajyoti Datta, linux-arm-kernel, linux-fpga
On 12. 02. 20 15:17, Michal Simek wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> In probe, the driver checks for devm_clk_get return and print error
> message in the failing case. However for -EPROBE_DEFER this message is
> confusing so avoid it.
>
> The similar change was done also by commit 28910cee898c
> ("fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer")
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/fpga/zynq-fpga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index ee7765049607..07fa8d9ec675 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev)
>
> priv->clk = devm_clk_get(dev, "ref_clk");
> if (IS_ERR(priv->clk)) {
> - dev_err(dev, "input clock not found\n");
> + if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> + dev_err(dev, "input clock not found\n");
> return PTR_ERR(priv->clk);
> }
>
>
Moritz: Any comment on this one?
Thanks,
Michal
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fpga: zynq: Remove clk_get error message for probe defer
@ 2020-02-21 10:37 ` Michal Simek
0 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2020-02-21 10:37 UTC (permalink / raw)
To: Michal Simek, linux-kernel, monstr, git, Moritz Fischer
Cc: linux-fpga, Shubhrajyoti Datta, linux-arm-kernel
On 12. 02. 20 15:17, Michal Simek wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> In probe, the driver checks for devm_clk_get return and print error
> message in the failing case. However for -EPROBE_DEFER this message is
> confusing so avoid it.
>
> The similar change was done also by commit 28910cee898c
> ("fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer")
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/fpga/zynq-fpga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index ee7765049607..07fa8d9ec675 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev)
>
> priv->clk = devm_clk_get(dev, "ref_clk");
> if (IS_ERR(priv->clk)) {
> - dev_err(dev, "input clock not found\n");
> + if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> + dev_err(dev, "input clock not found\n");
> return PTR_ERR(priv->clk);
> }
>
>
Moritz: Any comment on this one?
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fpga: zynq: Remove clk_get error message for probe defer
2020-02-12 14:17 ` Michal Simek
(?)
@ 2020-02-22 18:21 ` Moritz Fischer
-1 siblings, 0 replies; 7+ messages in thread
From: Moritz Fischer @ 2020-02-22 18:21 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, git, Shubhrajyoti Datta, Moritz Fischer,
linux-arm-kernel, linux-fpga
On Wed, Feb 12, 2020 at 03:17:08PM +0100, Michal Simek wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> In probe, the driver checks for devm_clk_get return and print error
> message in the failing case. However for -EPROBE_DEFER this message is
> confusing so avoid it.
>
> The similar change was done also by commit 28910cee898c
> ("fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer")
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/fpga/zynq-fpga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index ee7765049607..07fa8d9ec675 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev)
>
> priv->clk = devm_clk_get(dev, "ref_clk");
> if (IS_ERR(priv->clk)) {
> - dev_err(dev, "input clock not found\n");
> + if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> + dev_err(dev, "input clock not found\n");
> return PTR_ERR(priv->clk);
> }
>
> --
> 2.25.0
>
Applied to for-next.
Thanks,
Moritz
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fpga: zynq: Remove clk_get error message for probe defer
@ 2020-02-22 18:21 ` Moritz Fischer
0 siblings, 0 replies; 7+ messages in thread
From: Moritz Fischer @ 2020-02-22 18:21 UTC (permalink / raw)
To: Michal Simek
Cc: monstr, linux-fpga, Shubhrajyoti Datta, linux-kernel,
Moritz Fischer, git, linux-arm-kernel
On Wed, Feb 12, 2020 at 03:17:08PM +0100, Michal Simek wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> In probe, the driver checks for devm_clk_get return and print error
> message in the failing case. However for -EPROBE_DEFER this message is
> confusing so avoid it.
>
> The similar change was done also by commit 28910cee898c
> ("fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer")
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/fpga/zynq-fpga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index ee7765049607..07fa8d9ec675 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev)
>
> priv->clk = devm_clk_get(dev, "ref_clk");
> if (IS_ERR(priv->clk)) {
> - dev_err(dev, "input clock not found\n");
> + if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> + dev_err(dev, "input clock not found\n");
> return PTR_ERR(priv->clk);
> }
>
> --
> 2.25.0
>
Applied to for-next.
Thanks,
Moritz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] fpga: zynq: Remove clk_get error message for probe defer
@ 2020-02-22 18:21 ` Moritz Fischer
0 siblings, 0 replies; 7+ messages in thread
From: Moritz Fischer @ 2020-02-22 18:21 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, git, Shubhrajyoti Datta, Moritz Fischer,
linux-arm-kernel, linux-fpga
On Wed, Feb 12, 2020 at 03:17:08PM +0100, Michal Simek wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>
> In probe, the driver checks for devm_clk_get return and print error
> message in the failing case. However for -EPROBE_DEFER this message is
> confusing so avoid it.
>
> The similar change was done also by commit 28910cee898c
> ("fpga: xilinx-pr-decoupler: Remove clk_get error message for probe defer")
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/fpga/zynq-fpga.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index ee7765049607..07fa8d9ec675 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -583,7 +583,8 @@ static int zynq_fpga_probe(struct platform_device *pdev)
>
> priv->clk = devm_clk_get(dev, "ref_clk");
> if (IS_ERR(priv->clk)) {
> - dev_err(dev, "input clock not found\n");
> + if (PTR_ERR(priv->clk) != -EPROBE_DEFER)
> + dev_err(dev, "input clock not found\n");
> return PTR_ERR(priv->clk);
> }
>
> --
> 2.25.0
>
Applied to for-next.
Thanks,
Moritz
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-02-22 18:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 14:17 [PATCH] fpga: zynq: Remove clk_get error message for probe defer Michal Simek
2020-02-12 14:17 ` Michal Simek
2020-02-21 10:37 ` Michal Simek
2020-02-21 10:37 ` Michal Simek
2020-02-22 18:21 ` Moritz Fischer
2020-02-22 18:21 ` Moritz Fischer
2020-02-22 18:21 ` Moritz Fischer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.