[hverkuil-media:tc358840 2/4] drivers/media/i2c/tc358840.c:3410:3-8: No need to set .owner here. The core will do it.

[hverkuil-media:tc358840 2/4] drivers/media/i2c/tc358840.c:3410:3-8: No need to set .owner here. The core will do it.

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

tree:   git://linuxtv.org/hverkuil/media_tree.git tc358840
head:   54531afb55437b5dc44ce1bcf5f2e70889dc388d
commit: 217099c727b7a16fc643749d3bb9ddc3650315f4 [2/4] tc358840: add Toshiba tc358840 HDMI-to-CSI bridge.

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/media/i2c/tc358840.c:3410:3-8: No need to set .owner here. The core will do it.
--
>> drivers/media/i2c/tc358840.c:3346:5-8: Unneeded variable: "err". Return "0" on line 3362
   drivers/media/i2c/tc358840.c:3367:5-8: Unneeded variable: "err". Return "0" on line 3383

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[PATCH] tc358840: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

From: kbuild test robot <lkp@intel.com>

drivers/media/i2c/tc358840.c:3410:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 217099c727b7 ("tc358840: add Toshiba tc358840 HDMI-to-CSI bridge.")
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   git://linuxtv.org/hverkuil/media_tree.git tc358840
head:   54531afb55437b5dc44ce1bcf5f2e70889dc388d
commit: 217099c727b7a16fc643749d3bb9ddc3650315f4 [2/4] tc358840: add Toshiba tc358840 HDMI-to-CSI bridge.

 tc358840.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/media/i2c/tc358840.c
+++ b/drivers/media/i2c/tc358840.c
@@ -3407,7 +3407,6 @@ static struct i2c_driver tc358840_driver
 	.driver = {
 		.of_match_table = of_match_ptr(tc358840_of_table),
 		.name = "tc358840",
-		.owner = THIS_MODULE,
 		.pm = &tc358840_pm_ops,
 	},
 	.probe = tc358840_probe,

[PATCH] tc358840: fix returnvar.cocci warnings

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1818 bytes --]

From: kbuild test robot <lkp@intel.com>

drivers/media/i2c/tc358840.c:3346:5-8: Unneeded variable: "err". Return "0" on line 3362
drivers/media/i2c/tc358840.c:3367:5-8: Unneeded variable: "err". Return "0" on line 3383


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 217099c727b7 ("tc358840: add Toshiba tc358840 HDMI-to-CSI bridge.")
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   git://linuxtv.org/hverkuil/media_tree.git tc358840
head:   54531afb55437b5dc44ce1bcf5f2e70889dc388d
commit: 217099c727b7a16fc643749d3bb9ddc3650315f4 [2/4] tc358840: add Toshiba tc358840 HDMI-to-CSI bridge.

Please take the patch only if it's a positive warning. Thanks!

 tc358840.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/drivers/media/i2c/tc358840.c
+++ b/drivers/media/i2c/tc358840.c
@@ -3343,7 +3343,6 @@ static void enable_audio_block_and_i2s(s
 
 static int tc358840_runtime_resume(struct device *dev)
 {
-	int err = 0;
 	struct v4l2_subdev *sd = dev_get_drvdata(dev);
 	struct tc358840_state *state = to_state(sd);
 	struct i2c_client *client = state->i2c_client;
@@ -3359,12 +3358,11 @@ static int tc358840_runtime_resume(struc
 	state->suspended = false;
 unlock:
 	mutex_unlock(&state->lock);
-	return err;
+	return 0;
 }
 
 static int tc358840_runtime_suspend(struct device *dev)
 {
-	int err = 0;
 	struct v4l2_subdev *sd = dev_get_drvdata(dev);
 	struct tc358840_state *state = to_state(sd);
 	struct i2c_client *client = state->i2c_client;
@@ -3380,7 +3378,7 @@ static int tc358840_runtime_suspend(stru
 	state->suspended = true;
 unlock:
 	mutex_unlock(&state->lock);
-	return err;
+	return 0;
 }
 
 static const struct dev_pm_ops tc358840_pm_ops = {