All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: netanel@amazon.com, akiyano@amazon.com, gtzalik@amazon.com,
	saeedb@amazon.com, zorik@amazon.com, sameehj@amazon.com,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ena: ethtool: remove redundant non-zero check on rc
Date: Sun, 23 Feb 2020 16:41:54 -0800 (PST)	[thread overview]
Message-ID: <20200223.164154.1411149705613568241.davem@davemloft.net> (raw)
In-Reply-To: <20200221232653.33134-1-colin.king@canonical.com>

From: Colin King <colin.king@canonical.com>
Date: Fri, 21 Feb 2020 23:26:53 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> The non-zero check on rc is redundant as a previous non-zero
> check on rc will always return and the second check is never
> reached, hence it is redundant and can be removed.  Also
> remove a blank line.
> 
> Addresses-Coverity: ("Logically dead code")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to net-next.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: netanel@amazon.com, akiyano@amazon.com, gtzalik@amazon.com,
	saeedb@amazon.com, zorik@amazon.com, sameehj@amazon.com,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ena: ethtool: remove redundant non-zero check on rc
Date: Mon, 24 Feb 2020 00:41:54 +0000	[thread overview]
Message-ID: <20200223.164154.1411149705613568241.davem@davemloft.net> (raw)
In-Reply-To: <20200221232653.33134-1-colin.king@canonical.com>

From: Colin King <colin.king@canonical.com>
Date: Fri, 21 Feb 2020 23:26:53 +0000

> From: Colin Ian King <colin.king@canonical.com>
> 
> The non-zero check on rc is redundant as a previous non-zero
> check on rc will always return and the second check is never
> reached, hence it is redundant and can be removed.  Also
> remove a blank line.
> 
> Addresses-Coverity: ("Logically dead code")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied to net-next.

  parent reply	other threads:[~2020-02-24  0:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21 23:26 [PATCH] net: ena: ethtool: remove redundant non-zero check on rc Colin King
2020-02-21 23:26 ` Colin King
2020-02-23  8:18 ` Jubran, Samih
2020-02-23  8:18   ` Jubran, Samih
2020-02-24  0:41 ` David Miller [this message]
2020-02-24  0:41   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200223.164154.1411149705613568241.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akiyano@amazon.com \
    --cc=colin.king@canonical.com \
    --cc=gtzalik@amazon.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netanel@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedb@amazon.com \
    --cc=sameehj@amazon.com \
    --cc=zorik@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.