* [kvm-unit-tests PATCH] Makefile: fix stack-protector tests
@ 2020-02-23 23:14 Fabrice Fontaine
2020-02-24 9:50 ` Andrew Jones
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2020-02-23 23:14 UTC (permalink / raw)
To: kvm; +Cc: Fabrice Fontaine
Rename fnostack_protector into fno_stack_protector and
fnostack_protector_all into fnostack_protector_all otherwise build will
fail if -fstack-protector is passed by the toolchain
Fixes:
- http://autobuild.buildroot.org/results/ad689b08173548af21dd1fb0e827fd561de6dfef
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 767b6c6..754ed65 100644
--- a/Makefile
+++ b/Makefile
@@ -55,8 +55,8 @@ COMMON_CFLAGS += -Wignored-qualifiers -Werror
frame-pointer-flag=-f$(if $(KEEP_FRAME_POINTER),no-,)omit-frame-pointer
fomit_frame_pointer := $(call cc-option, $(frame-pointer-flag), "")
-fnostack_protector := $(call cc-option, -fno-stack-protector, "")
-fnostack_protector_all := $(call cc-option, -fno-stack-protector-all, "")
+fno_stack_protector := $(call cc-option, -fno-stack-protector, "")
+fno_stack_protector_all := $(call cc-option, -fno-stack-protector-all, "")
wno_frame_address := $(call cc-option, -Wno-frame-address, "")
fno_pic := $(call cc-option, -fno-pic, "")
no_pie := $(call cc-option, -no-pie, "")
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [kvm-unit-tests PATCH] Makefile: fix stack-protector tests
2020-02-23 23:14 [kvm-unit-tests PATCH] Makefile: fix stack-protector tests Fabrice Fontaine
@ 2020-02-24 9:50 ` Andrew Jones
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Jones @ 2020-02-24 9:50 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: kvm, pbonzini
On Mon, Feb 24, 2020 at 12:14:14AM +0100, Fabrice Fontaine wrote:
> Rename fnostack_protector into fno_stack_protector and
> fnostack_protector_all into fnostack_protector_all otherwise build will
> fail if -fstack-protector is passed by the toolchain
>
> Fixes:
> - http://autobuild.buildroot.org/results/ad689b08173548af21dd1fb0e827fd561de6dfef
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 767b6c6..754ed65 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -55,8 +55,8 @@ COMMON_CFLAGS += -Wignored-qualifiers -Werror
>
> frame-pointer-flag=-f$(if $(KEEP_FRAME_POINTER),no-,)omit-frame-pointer
> fomit_frame_pointer := $(call cc-option, $(frame-pointer-flag), "")
> -fnostack_protector := $(call cc-option, -fno-stack-protector, "")
> -fnostack_protector_all := $(call cc-option, -fno-stack-protector-all, "")
> +fno_stack_protector := $(call cc-option, -fno-stack-protector, "")
> +fno_stack_protector_all := $(call cc-option, -fno-stack-protector-all, "")
> wno_frame_address := $(call cc-option, -Wno-frame-address, "")
> fno_pic := $(call cc-option, -fno-pic, "")
> no_pie := $(call cc-option, -no-pie, "")
> --
> 2.25.0
>
Thanks Fabrice, but the same change was posted by Alexandru and is in my
last PULL request to Paolo [*].
drew
[*] https://patchwork.kernel.org/patch/11368845/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-24 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-23 23:14 [kvm-unit-tests PATCH] Makefile: fix stack-protector tests Fabrice Fontaine
2020-02-24 9:50 ` Andrew Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.