* [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM
@ 2020-02-17 16:12 ` Jianxin Pan
0 siblings, 0 replies; 19+ messages in thread
From: Jianxin Pan @ 2020-02-17 16:12 UTC (permalink / raw)
To: Kevin Hilman, linux-amlogic
Cc: Jianxin Pan, Stephen Rothwell, Rob Herring, Neil Armstrong,
Jerome Brunet, Martin Blumenstingl, linux-pm, linux-kernel,
linux-arm-kernel, devicetree, Jian Hu, Hanjie Lin, Victor Wan,
Xingyu Chen
When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure:
.../meson-secure-pwrc.o: In function `meson_secure_pwrc_on':
.../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call'
Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS.
Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org>
Reported-by: Stephen Rothwell<sfr@canb.auug.org.au>
Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
---
drivers/soc/amlogic/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig
index 6cb06e7..321c5e2 100644
--- a/drivers/soc/amlogic/Kconfig
+++ b/drivers/soc/amlogic/Kconfig
@@ -50,7 +50,7 @@ config MESON_EE_PM_DOMAINS
config MESON_SECURE_PM_DOMAINS
bool "Amlogic Meson Secure Power Domains driver"
- depends on ARCH_MESON || COMPILE_TEST
+ depends on (ARCH_MESON || COMPILE_TEST) && MESON_SM
depends on PM && OF
depends on HAVE_ARM_SMCCC
default ARCH_MESON
--
2.7.4
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-17 16:12 ` Jianxin Pan 0 siblings, 0 replies; 19+ messages in thread From: Jianxin Pan @ 2020-02-17 16:12 UTC (permalink / raw) To: Kevin Hilman, linux-amlogic Cc: Stephen Rothwell, Hanjie Lin, Victor Wan, Jianxin Pan, Neil Armstrong, Martin Blumenstingl, linux-pm, linux-kernel, devicetree, Rob Herring, Jian Hu, Xingyu Chen, linux-arm-kernel, Jerome Brunet When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") Reported-by: kbuild test robot <lkp@intel.com> Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> --- drivers/soc/amlogic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig index 6cb06e7..321c5e2 100644 --- a/drivers/soc/amlogic/Kconfig +++ b/drivers/soc/amlogic/Kconfig @@ -50,7 +50,7 @@ config MESON_EE_PM_DOMAINS config MESON_SECURE_PM_DOMAINS bool "Amlogic Meson Secure Power Domains driver" - depends on ARCH_MESON || COMPILE_TEST + depends on (ARCH_MESON || COMPILE_TEST) && MESON_SM depends on PM && OF depends on HAVE_ARM_SMCCC default ARCH_MESON -- 2.7.4 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-17 16:12 ` Jianxin Pan 0 siblings, 0 replies; 19+ messages in thread From: Jianxin Pan @ 2020-02-17 16:12 UTC (permalink / raw) To: Kevin Hilman, linux-amlogic Cc: Stephen Rothwell, Hanjie Lin, Victor Wan, Jianxin Pan, Neil Armstrong, Martin Blumenstingl, linux-pm, linux-kernel, devicetree, Rob Herring, Jian Hu, Xingyu Chen, linux-arm-kernel, Jerome Brunet When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") Reported-by: kbuild test robot <lkp@intel.com> Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> --- drivers/soc/amlogic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/amlogic/Kconfig b/drivers/soc/amlogic/Kconfig index 6cb06e7..321c5e2 100644 --- a/drivers/soc/amlogic/Kconfig +++ b/drivers/soc/amlogic/Kconfig @@ -50,7 +50,7 @@ config MESON_EE_PM_DOMAINS config MESON_SECURE_PM_DOMAINS bool "Amlogic Meson Secure Power Domains driver" - depends on ARCH_MESON || COMPILE_TEST + depends on (ARCH_MESON || COMPILE_TEST) && MESON_SM depends on PM && OF depends on HAVE_ARM_SMCCC default ARCH_MESON -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM 2020-02-17 16:12 ` Jianxin Pan (?) @ 2020-02-17 21:07 ` Stephen Rothwell -1 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-02-17 21:07 UTC (permalink / raw) To: Jianxin Pan Cc: Kevin Hilman, linux-amlogic, Rob Herring, Neil Armstrong, Jerome Brunet, Martin Blumenstingl, linux-pm, linux-kernel, linux-arm-kernel, devicetree, Jian Hu, Hanjie Lin, Victor Wan, Xingyu Chen [-- Attachment #1: Type: text/plain, Size: 904 bytes --] Hi Jianxin, On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > --- > drivers/soc/amlogic/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I will apply that patch to linux-next today. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-17 21:07 ` Stephen Rothwell 0 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-02-17 21:07 UTC (permalink / raw) To: Jianxin Pan Cc: devicetree, Hanjie Lin, Victor Wan, Neil Armstrong, Martin Blumenstingl, Kevin Hilman, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, linux-amlogic, linux-arm-kernel, Jerome Brunet [-- Attachment #1.1: Type: text/plain, Size: 904 bytes --] Hi Jianxin, On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > --- > drivers/soc/amlogic/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I will apply that patch to linux-next today. -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 167 bytes --] _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-17 21:07 ` Stephen Rothwell 0 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-02-17 21:07 UTC (permalink / raw) To: Jianxin Pan Cc: devicetree, Hanjie Lin, Victor Wan, Neil Armstrong, Martin Blumenstingl, Kevin Hilman, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, linux-amlogic, linux-arm-kernel, Jerome Brunet [-- Attachment #1.1: Type: text/plain, Size: 904 bytes --] Hi Jianxin, On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > --- > drivers/soc/amlogic/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I will apply that patch to linux-next today. -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM 2020-02-17 21:07 ` Stephen Rothwell (?) @ 2020-02-17 22:22 ` Stephen Rothwell -1 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-02-17 22:22 UTC (permalink / raw) To: Jianxin Pan Cc: Kevin Hilman, linux-amlogic, Rob Herring, Neil Armstrong, Jerome Brunet, Martin Blumenstingl, linux-pm, linux-kernel, linux-arm-kernel, devicetree, Jian Hu, Hanjie Lin, Victor Wan, Xingyu Chen [-- Attachment #1: Type: text/plain, Size: 1285 bytes --] Hi all, On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: > > > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > > > Reported-by: kbuild test robot <lkp@intel.com> > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> > > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> > > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > > --- > > drivers/soc/amlogic/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I will apply that patch to linux-next today. This fixes the build for me. Tested-by: Stephen Rothwell<sfr@canb.auug.org.au> Also, please keep the commit message tags together at the end of the commit message i.e. remove the blank line after the Fixes: tag above. (see "git interpret-trailers ") -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-17 22:22 ` Stephen Rothwell 0 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-02-17 22:22 UTC (permalink / raw) To: Jianxin Pan Cc: devicetree, Hanjie Lin, Victor Wan, Neil Armstrong, Martin Blumenstingl, Kevin Hilman, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, linux-amlogic, linux-arm-kernel, Jerome Brunet [-- Attachment #1.1: Type: text/plain, Size: 1285 bytes --] Hi all, On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: > > > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > > > Reported-by: kbuild test robot <lkp@intel.com> > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> > > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> > > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > > --- > > drivers/soc/amlogic/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I will apply that patch to linux-next today. This fixes the build for me. Tested-by: Stephen Rothwell<sfr@canb.auug.org.au> Also, please keep the commit message tags together at the end of the commit message i.e. remove the blank line after the Fixes: tag above. (see "git interpret-trailers ") -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 167 bytes --] _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-17 22:22 ` Stephen Rothwell 0 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-02-17 22:22 UTC (permalink / raw) To: Jianxin Pan Cc: devicetree, Hanjie Lin, Victor Wan, Neil Armstrong, Martin Blumenstingl, Kevin Hilman, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, linux-amlogic, linux-arm-kernel, Jerome Brunet [-- Attachment #1.1: Type: text/plain, Size: 1285 bytes --] Hi all, On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: > > > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > > > Reported-by: kbuild test robot <lkp@intel.com> > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> > > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> > > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > > --- > > drivers/soc/amlogic/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > I will apply that patch to linux-next today. This fixes the build for me. Tested-by: Stephen Rothwell<sfr@canb.auug.org.au> Also, please keep the commit message tags together at the end of the commit message i.e. remove the blank line after the Fixes: tag above. (see "git interpret-trailers ") -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM 2020-02-17 22:22 ` Stephen Rothwell (?) @ 2020-02-23 23:16 ` Stephen Rothwell -1 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-02-23 23:16 UTC (permalink / raw) To: Kevin Hilman, Carlo Caione Cc: Jianxin Pan, linux-amlogic, Rob Herring, Neil Armstrong, Jerome Brunet, Martin Blumenstingl, linux-pm, linux-kernel, linux-arm-kernel, devicetree, Jian Hu, Hanjie Lin, Victor Wan, Xingyu Chen [-- Attachment #1: Type: text/plain, Size: 1473 bytes --] Hi all, On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: > > > > > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > > > > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > > > > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > > > > > Reported-by: kbuild test robot <lkp@intel.com> > > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> > > > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> > > > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > > > --- > > > drivers/soc/amlogic/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I will apply that patch to linux-next today. > > This fixes the build for me. > > Tested-by: Stephen Rothwell<sfr@canb.auug.org.au> > > Also, please keep the commit message tags together at the end of the > commit message i.e. remove the blank line after the Fixes: tag above. > (see "git interpret-trailers ") I am still applying this patch ... -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-23 23:16 ` Stephen Rothwell 0 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-02-23 23:16 UTC (permalink / raw) To: Kevin Hilman, Carlo Caione Cc: devicetree, Hanjie Lin, Victor Wan, Jianxin Pan, Neil Armstrong, Martin Blumenstingl, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, linux-amlogic, linux-arm-kernel, Jerome Brunet [-- Attachment #1.1: Type: text/plain, Size: 1473 bytes --] Hi all, On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: > > > > > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > > > > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > > > > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > > > > > Reported-by: kbuild test robot <lkp@intel.com> > > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> > > > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> > > > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > > > --- > > > drivers/soc/amlogic/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I will apply that patch to linux-next today. > > This fixes the build for me. > > Tested-by: Stephen Rothwell<sfr@canb.auug.org.au> > > Also, please keep the commit message tags together at the end of the > commit message i.e. remove the blank line after the Fixes: tag above. > (see "git interpret-trailers ") I am still applying this patch ... -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 167 bytes --] _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-23 23:16 ` Stephen Rothwell 0 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-02-23 23:16 UTC (permalink / raw) To: Kevin Hilman, Carlo Caione Cc: devicetree, Hanjie Lin, Victor Wan, Jianxin Pan, Neil Armstrong, Martin Blumenstingl, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, linux-amlogic, linux-arm-kernel, Jerome Brunet [-- Attachment #1.1: Type: text/plain, Size: 1473 bytes --] Hi all, On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: > > > > > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > > > > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > > > > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > > > > > Reported-by: kbuild test robot <lkp@intel.com> > > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> > > > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> > > > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> > > > --- > > > drivers/soc/amlogic/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I will apply that patch to linux-next today. > > This fixes the build for me. > > Tested-by: Stephen Rothwell<sfr@canb.auug.org.au> > > Also, please keep the commit message tags together at the end of the > commit message i.e. remove the blank line after the Fixes: tag above. > (see "git interpret-trailers ") I am still applying this patch ... -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM 2020-02-23 23:16 ` Stephen Rothwell (?) @ 2020-02-29 16:55 ` Kevin Hilman -1 siblings, 0 replies; 19+ messages in thread From: Kevin Hilman @ 2020-02-29 16:55 UTC (permalink / raw) To: Stephen Rothwell, Carlo Caione Cc: Jianxin Pan, linux-amlogic, Rob Herring, Neil Armstrong, Jerome Brunet, Martin Blumenstingl, linux-pm, linux-kernel, linux-arm-kernel, devicetree, Jian Hu, Hanjie Lin, Victor Wan, Xingyu Chen Stephen Rothwell <sfr@canb.auug.org.au> writes: > Hi all, > > On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> >> On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> > >> > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: >> > > >> > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: >> > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': >> > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' >> > > >> > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. >> > > >> > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") >> > > >> > > Reported-by: kbuild test robot <lkp@intel.com> >> > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> >> > > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> >> > > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> >> > > --- >> > > drivers/soc/amlogic/Kconfig | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > I will apply that patch to linux-next today. >> >> This fixes the build for me. >> >> Tested-by: Stephen Rothwell<sfr@canb.auug.org.au> >> >> Also, please keep the commit message tags together at the end of the >> commit message i.e. remove the blank line after the Fixes: tag above. >> (see "git interpret-trailers ") > > I am still applying this patch ... I've fixed up the trailer whitespace an queued this up now, so should show up in linux next shortly. Kevin ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-29 16:55 ` Kevin Hilman 0 siblings, 0 replies; 19+ messages in thread From: Kevin Hilman @ 2020-02-29 16:55 UTC (permalink / raw) To: Stephen Rothwell, Carlo Caione Cc: devicetree, Hanjie Lin, Victor Wan, Jianxin Pan, Neil Armstrong, Martin Blumenstingl, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, linux-amlogic, linux-arm-kernel, Jerome Brunet Stephen Rothwell <sfr@canb.auug.org.au> writes: > Hi all, > > On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> >> On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> > >> > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: >> > > >> > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: >> > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': >> > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' >> > > >> > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. >> > > >> > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") >> > > >> > > Reported-by: kbuild test robot <lkp@intel.com> >> > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> >> > > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> >> > > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> >> > > --- >> > > drivers/soc/amlogic/Kconfig | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > I will apply that patch to linux-next today. >> >> This fixes the build for me. >> >> Tested-by: Stephen Rothwell<sfr@canb.auug.org.au> >> >> Also, please keep the commit message tags together at the end of the >> commit message i.e. remove the blank line after the Fixes: tag above. >> (see "git interpret-trailers ") > > I am still applying this patch ... I've fixed up the trailer whitespace an queued this up now, so should show up in linux next shortly. Kevin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-02-29 16:55 ` Kevin Hilman 0 siblings, 0 replies; 19+ messages in thread From: Kevin Hilman @ 2020-02-29 16:55 UTC (permalink / raw) To: Stephen Rothwell, Carlo Caione Cc: devicetree, Hanjie Lin, Victor Wan, Jianxin Pan, Neil Armstrong, Martin Blumenstingl, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, linux-amlogic, linux-arm-kernel, Jerome Brunet Stephen Rothwell <sfr@canb.auug.org.au> writes: > Hi all, > > On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> >> On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote: >> > >> > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@amlogic.com> wrote: >> > > >> > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: >> > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': >> > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' >> > > >> > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. >> > > >> > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") >> > > >> > > Reported-by: kbuild test robot <lkp@intel.com> >> > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@kernel.org> >> > > Reported-by: Stephen Rothwell<sfr@canb.auug.org.au> >> > > Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> >> > > --- >> > > drivers/soc/amlogic/Kconfig | 2 +- >> > > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > I will apply that patch to linux-next today. >> >> This fixes the build for me. >> >> Tested-by: Stephen Rothwell<sfr@canb.auug.org.au> >> >> Also, please keep the commit message tags together at the end of the >> commit message i.e. remove the blank line after the Fixes: tag above. >> (see "git interpret-trailers ") > > I am still applying this patch ... I've fixed up the trailer whitespace an queued this up now, so should show up in linux next shortly. Kevin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM 2020-02-29 16:55 ` Kevin Hilman (?) @ 2020-03-01 0:47 ` Stephen Rothwell -1 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-03-01 0:47 UTC (permalink / raw) To: Kevin Hilman Cc: Carlo Caione, Jianxin Pan, linux-amlogic, Rob Herring, Neil Armstrong, Jerome Brunet, Martin Blumenstingl, linux-pm, linux-kernel, linux-arm-kernel, devicetree, Jian Hu, Hanjie Lin, Victor Wan, Xingyu Chen [-- Attachment #1: Type: text/plain, Size: 247 bytes --] Hi Kevin, On Sat, 29 Feb 2020 17:55:32 +0100 Kevin Hilman <khilman@baylibre.com> wrote: > > I've fixed up the trailer whitespace an queued this up now, so should > show up in linux next shortly. Thanks. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-03-01 0:47 ` Stephen Rothwell 0 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-03-01 0:47 UTC (permalink / raw) To: Kevin Hilman Cc: devicetree, Hanjie Lin, Victor Wan, Jianxin Pan, Neil Armstrong, Martin Blumenstingl, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, Carlo Caione, linux-amlogic, linux-arm-kernel, Jerome Brunet [-- Attachment #1.1: Type: text/plain, Size: 247 bytes --] Hi Kevin, On Sat, 29 Feb 2020 17:55:32 +0100 Kevin Hilman <khilman@baylibre.com> wrote: > > I've fixed up the trailer whitespace an queued this up now, so should > show up in linux next shortly. Thanks. -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 167 bytes --] _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM @ 2020-03-01 0:47 ` Stephen Rothwell 0 siblings, 0 replies; 19+ messages in thread From: Stephen Rothwell @ 2020-03-01 0:47 UTC (permalink / raw) To: Kevin Hilman Cc: devicetree, Hanjie Lin, Victor Wan, Jianxin Pan, Neil Armstrong, Martin Blumenstingl, linux-pm, linux-kernel, Rob Herring, Jian Hu, Xingyu Chen, Carlo Caione, linux-amlogic, linux-arm-kernel, Jerome Brunet [-- Attachment #1.1: Type: text/plain, Size: 247 bytes --] Hi Kevin, On Sat, 29 Feb 2020 17:55:32 +0100 Kevin Hilman <khilman@baylibre.com> wrote: > > I've fixed up the trailer whitespace an queued this up now, so should > show up in linux next shortly. Thanks. -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM 2020-02-17 16:12 ` Jianxin Pan ` (2 preceding siblings ...) (?) @ 2020-02-29 18:21 ` patchwork-bot+linux-amlogic -1 siblings, 0 replies; 19+ messages in thread From: patchwork-bot+linux-amlogic @ 2020-02-29 18:21 UTC (permalink / raw) To: Jianxin Pan; +Cc: linux-amlogic, khilman Hello: This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next). On Tue, 18 Feb 2020 00:12:13 +0800 you wrote: > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure: > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on': > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call' > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS. > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller") > > [...] Here is a summary with links: - soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM https://git.kernel.org/khilman/linux-amlogic/c/9ef7a7920678b10431d88635f9a4a49bd23ca3a7 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.wiki.kernel.org/userdoc/pwbot _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2020-03-01 0:48 UTC | newest] Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-02-17 16:12 [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM Jianxin Pan 2020-02-17 16:12 ` Jianxin Pan 2020-02-17 16:12 ` Jianxin Pan 2020-02-17 21:07 ` Stephen Rothwell 2020-02-17 21:07 ` Stephen Rothwell 2020-02-17 21:07 ` Stephen Rothwell 2020-02-17 22:22 ` Stephen Rothwell 2020-02-17 22:22 ` Stephen Rothwell 2020-02-17 22:22 ` Stephen Rothwell 2020-02-23 23:16 ` Stephen Rothwell 2020-02-23 23:16 ` Stephen Rothwell 2020-02-23 23:16 ` Stephen Rothwell 2020-02-29 16:55 ` Kevin Hilman 2020-02-29 16:55 ` Kevin Hilman 2020-02-29 16:55 ` Kevin Hilman 2020-03-01 0:47 ` Stephen Rothwell 2020-03-01 0:47 ` Stephen Rothwell 2020-03-01 0:47 ` Stephen Rothwell 2020-02-29 18:21 ` patchwork-bot+linux-amlogic
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.