* [meta-oe][PATCH 1/2] nodejs: don't enable ares support by default
@ 2020-02-25 19:07 Martin Jansa
2020-02-25 19:07 ` [meta-oe][PATCH 2/2] libvncserver: don't enable sasl " Martin Jansa
2020-02-25 19:13 ` [meta-oe][PATCH 1/2] nodejs: don't enable ares " Khem Raj
0 siblings, 2 replies; 6+ messages in thread
From: Martin Jansa @ 2020-02-25 19:07 UTC (permalink / raw)
To: openembedded-devel
* c-ares is in meta-networking and meta-oe doesn't depend on meta-networking
* fixes:
ERROR: Nothing PROVIDES 'c-ares' (but meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb DEPENDS on or otherwise requires it)
in builds without meta-networking
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
index 6eb52c209a..9f91a3f4dd 100644
--- a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
+++ b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
@@ -51,7 +51,7 @@ ARCHFLAGS_arm = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', '-
GYP_DEFINES_append_mipsel = " mips_arch_variant='r1' "
ARCHFLAGS ?= ""
-PACKAGECONFIG ??= "ares icu libuv zlib"
+PACKAGECONFIG ??= "icu libuv zlib"
PACKAGECONFIG[ares] = "--shared-cares,,c-ares"
PACKAGECONFIG[gyp] = ",,gyp-py2-native"
PACKAGECONFIG[icu] = "--with-intl=system-icu,--without-intl,icu"
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [meta-oe][PATCH 2/2] libvncserver: don't enable sasl support by default
2020-02-25 19:07 [meta-oe][PATCH 1/2] nodejs: don't enable ares support by default Martin Jansa
@ 2020-02-25 19:07 ` Martin Jansa
2020-02-25 19:13 ` [meta-oe][PATCH 1/2] nodejs: don't enable ares " Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2020-02-25 19:07 UTC (permalink / raw)
To: openembedded-devel
* cyrus-sasl is in meta-networking and meta-oe doesn't depend on meta-networking
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.12.bb | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.12.bb b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.12.bb
index 22fc83a64f..dfdf82458c 100644
--- a/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.12.bb
+++ b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.12.bb
@@ -17,7 +17,6 @@ PACKAGECONFIG ??= " \
pthread \
${@bb.utils.contains('DISTRO_FEATURES','systemd','systemd','',d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'ipv6', 'ipv6', '',d)} \
- sasl \
sdl \
websockets \
zlib \
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH 1/2] nodejs: don't enable ares support by default
2020-02-25 19:07 [meta-oe][PATCH 1/2] nodejs: don't enable ares support by default Martin Jansa
2020-02-25 19:07 ` [meta-oe][PATCH 2/2] libvncserver: don't enable sasl " Martin Jansa
@ 2020-02-25 19:13 ` Khem Raj
2020-02-25 19:22 ` Martin Jansa
1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2020-02-25 19:13 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembeded-devel
On Tue, Feb 25, 2020 at 11:07 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> * c-ares is in meta-networking and meta-oe doesn't depend on meta-networking
> * fixes:
> ERROR: Nothing PROVIDES 'c-ares' (but meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb DEPENDS on or otherwise requires it)
> in builds without meta-networking
>
this patch makes me thing if c-ares is better suites for meta-networking
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> index 6eb52c209a..9f91a3f4dd 100644
> --- a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> +++ b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> @@ -51,7 +51,7 @@ ARCHFLAGS_arm = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', '-
> GYP_DEFINES_append_mipsel = " mips_arch_variant='r1' "
> ARCHFLAGS ?= ""
>
> -PACKAGECONFIG ??= "ares icu libuv zlib"
> +PACKAGECONFIG ??= "icu libuv zlib"
> PACKAGECONFIG[ares] = "--shared-cares,,c-ares"
> PACKAGECONFIG[gyp] = ",,gyp-py2-native"
> PACKAGECONFIG[icu] = "--with-intl=system-icu,--without-intl,icu"
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH 1/2] nodejs: don't enable ares support by default
2020-02-25 19:13 ` [meta-oe][PATCH 1/2] nodejs: don't enable ares " Khem Raj
@ 2020-02-25 19:22 ` Martin Jansa
2020-02-25 19:24 ` Martin Jansa
2020-02-25 19:31 ` Khem Raj
0 siblings, 2 replies; 6+ messages in thread
From: Martin Jansa @ 2020-02-25 19:22 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]
On Tue, Feb 25, 2020 at 11:13:42AM -0800, Khem Raj wrote:
> On Tue, Feb 25, 2020 at 11:07 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> >
> > * c-ares is in meta-networking and meta-oe doesn't depend on meta-networking
> > * fixes:
> > ERROR: Nothing PROVIDES 'c-ares' (but meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb DEPENDS on or otherwise requires it)
> > in builds without meta-networking
> >
>
> this patch makes me thing if c-ares is better suites for meta-networking
?
This patch exists, because c-ares _is_ in meta-networking, while nodejs
which depends on it is in meta-oe.
>
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> > meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> > index 6eb52c209a..9f91a3f4dd 100644
> > --- a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> > +++ b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> > @@ -51,7 +51,7 @@ ARCHFLAGS_arm = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', '-
> > GYP_DEFINES_append_mipsel = " mips_arch_variant='r1' "
> > ARCHFLAGS ?= ""
> >
> > -PACKAGECONFIG ??= "ares icu libuv zlib"
> > +PACKAGECONFIG ??= "icu libuv zlib"
> > PACKAGECONFIG[ares] = "--shared-cares,,c-ares"
> > PACKAGECONFIG[gyp] = ",,gyp-py2-native"
> > PACKAGECONFIG[icu] = "--with-intl=system-icu,--without-intl,icu"
> > --
> > 2.20.1
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH 1/2] nodejs: don't enable ares support by default
2020-02-25 19:22 ` Martin Jansa
@ 2020-02-25 19:24 ` Martin Jansa
2020-02-25 19:31 ` Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2020-02-25 19:24 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
[-- Attachment #1: Type: text/plain, Size: 2810 bytes --]
On Tue, Feb 25, 2020 at 08:22:02PM +0100, Martin Jansa wrote:
> On Tue, Feb 25, 2020 at 11:13:42AM -0800, Khem Raj wrote:
> > On Tue, Feb 25, 2020 at 11:07 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> > >
> > > * c-ares is in meta-networking and meta-oe doesn't depend on meta-networking
> > > * fixes:
> > > ERROR: Nothing PROVIDES 'c-ares' (but meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb DEPENDS on or otherwise requires it)
> > > in builds without meta-networking
> > >
> >
> > this patch makes me thing if c-ares is better suites for meta-networking
>
> ?
>
> This patch exists, because c-ares _is_ in meta-networking, while nodejs
> which depends on it is in meta-oe.
It got enabled in default PACKAGECONFIG in:
commit 76dd3dac1f1e67a5c44ad732b8e827cc36ded641
Author: André Draszik <git@andred.net>
Date: Tue Oct 29 16:42:24 2019 +0000
nodejs: allow use of system c-ares (and make default)
Use system c-ares via PACKAGECONFIG by default. So far,
nodejs had been built using its embedded copy of c-ares,
which we generally try to avoid, for the known reasons
(independent updates, cve & license checks, etc).
Notes:
* otherwise nodejs uses its bundled version of c-ares
* the PACKAGECONFIG variable is 'ares' so as to be in
line with other uses of this (wget & curl recipes in
OE core)
Signed-off-by: André Draszik <git@andred.net>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
So unless you actually meant to move c-ares from meta-networking to
meta-oe..
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > ---
> > > meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> > > index 6eb52c209a..9f91a3f4dd 100644
> > > --- a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> > > +++ b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
> > > @@ -51,7 +51,7 @@ ARCHFLAGS_arm = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', '-
> > > GYP_DEFINES_append_mipsel = " mips_arch_variant='r1' "
> > > ARCHFLAGS ?= ""
> > >
> > > -PACKAGECONFIG ??= "ares icu libuv zlib"
> > > +PACKAGECONFIG ??= "icu libuv zlib"
> > > PACKAGECONFIG[ares] = "--shared-cares,,c-ares"
> > > PACKAGECONFIG[gyp] = ",,gyp-py2-native"
> > > PACKAGECONFIG[icu] = "--with-intl=system-icu,--without-intl,icu"
> > > --
> > > 2.20.1
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH 1/2] nodejs: don't enable ares support by default
2020-02-25 19:22 ` Martin Jansa
2020-02-25 19:24 ` Martin Jansa
@ 2020-02-25 19:31 ` Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2020-02-25 19:31 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembeded-devel
[-- Attachment #1.1: Type: text/plain, Size: 1882 bytes --]
On 2/25/20 11:22 AM, Martin Jansa wrote:
> On Tue, Feb 25, 2020 at 11:13:42AM -0800, Khem Raj wrote:
>> On Tue, Feb 25, 2020 at 11:07 AM Martin Jansa <martin.jansa@gmail.com> wrote:
>>>
>>> * c-ares is in meta-networking and meta-oe doesn't depend on meta-networking
>>> * fixes:
>>> ERROR: Nothing PROVIDES 'c-ares' (but meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb DEPENDS on or otherwise requires it)
>>> in builds without meta-networking
>>>
>>
>> this patch makes me thing if c-ares is better suites for meta-networking
>
> ?
s/meta-networking/meta-oe above
>
> This patch exists, because c-ares _is_ in meta-networking, while nodejs
> which depends on it is in meta-oe.
>
>>
>>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>>> ---
>>> meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
>>> index 6eb52c209a..9f91a3f4dd 100644
>>> --- a/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
>>> +++ b/meta-oe/recipes-devtools/nodejs/nodejs_12.14.1.bb
>>> @@ -51,7 +51,7 @@ ARCHFLAGS_arm = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', '-
>>> GYP_DEFINES_append_mipsel = " mips_arch_variant='r1' "
>>> ARCHFLAGS ?= ""
>>>
>>> -PACKAGECONFIG ??= "ares icu libuv zlib"
>>> +PACKAGECONFIG ??= "icu libuv zlib"
>>> PACKAGECONFIG[ares] = "--shared-cares,,c-ares"
>>> PACKAGECONFIG[gyp] = ",,gyp-py2-native"
>>> PACKAGECONFIG[icu] = "--with-intl=system-icu,--without-intl,icu"
>>> --
>>> 2.20.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-25 19:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-25 19:07 [meta-oe][PATCH 1/2] nodejs: don't enable ares support by default Martin Jansa
2020-02-25 19:07 ` [meta-oe][PATCH 2/2] libvncserver: don't enable sasl " Martin Jansa
2020-02-25 19:13 ` [meta-oe][PATCH 1/2] nodejs: don't enable ares " Khem Raj
2020-02-25 19:22 ` Martin Jansa
2020-02-25 19:24 ` Martin Jansa
2020-02-25 19:31 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.