* [Buildroot] [PATCH/next v3, 1/1] package/font-awesome: make it compatible with fontconfig
@ 2020-02-26 9:09 Fabrice Fontaine
2021-12-30 14:20 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Fabrice Fontaine @ 2020-02-26 9:09 UTC (permalink / raw)
To: buildroot
This commit installs font-awesome in the standard fonts directory
making it available systemwide.
Thanks to baruch for his technical critique.
Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com>
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v2 -> v3 (after review of Baruch Siach):
- Create a symlink to avoid duplication
Changes v1 -> v2 (after review of Arnout Vandecappelle):
- Keep only install of otf file and don't remove install of other files
package/font-awesome/font-awesome.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/font-awesome/font-awesome.mk b/package/font-awesome/font-awesome.mk
index 666346be0e..5211ac22a5 100644
--- a/package/font-awesome/font-awesome.mk
+++ b/package/font-awesome/font-awesome.mk
@@ -13,6 +13,8 @@ define FONT_AWESOME_INSTALL_TARGET_CMDS
mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
$(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
cp -dpfr $(@D)/$(d) $(TARGET_DIR)/usr/share/font-awesome$(sep))
+ mkdir -p $(TARGET_DIR)/usr/share/fonts/
+ ln -sf ../font-awesome $(TARGET_DIR)/usr/share/fonts/font-awesome
endef
$(eval $(generic-package))
--
2.25.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH/next v3, 1/1] package/font-awesome: make it compatible with fontconfig
2020-02-26 9:09 [Buildroot] [PATCH/next v3, 1/1] package/font-awesome: make it compatible with fontconfig Fabrice Fontaine
@ 2021-12-30 14:20 ` Thomas Petazzoni
2022-01-26 12:26 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2021-12-30 14:20 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Benjamin Calderon, buildroot
On Wed, 26 Feb 2020 10:09:39 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> This commit installs font-awesome in the standard fonts directory
> making it available systemwide.
>
> Thanks to baruch for his technical critique.
> Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3 (after review of Baruch Siach):
> - Create a symlink to avoid duplication
I have applied with a reworked commit log. That being said, I am not
sure it was really the "best" solution. It probably would be nicer to
install the fonts usable by fontconfig directly in /usr/share/fonts/,
keeping the rest in /usr/share/font-awesome/.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH/next v3, 1/1] package/font-awesome: make it compatible with fontconfig
2021-12-30 14:20 ` Thomas Petazzoni
@ 2022-01-26 12:26 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-01-26 12:26 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Benjamin Calderon, Fabrice Fontaine, buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> On Wed, 26 Feb 2020 10:09:39 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>> This commit installs font-awesome in the standard fonts directory
>> making it available systemwide.
>>
>> Thanks to baruch for his technical critique.
>> Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> Changes v2 -> v3 (after review of Baruch Siach):
>> - Create a symlink to avoid duplication
> I have applied with a reworked commit log. That being said, I am not
> sure it was really the "best" solution. It probably would be nicer to
> install the fonts usable by fontconfig directly in /usr/share/fonts/,
> keeping the rest in /usr/share/font-awesome/.
Committed to 2021.02.x and 2021.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-26 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 9:09 [Buildroot] [PATCH/next v3, 1/1] package/font-awesome: make it compatible with fontconfig Fabrice Fontaine
2021-12-30 14:20 ` Thomas Petazzoni
2022-01-26 12:26 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.