* [PATCH] Fix build failure due to missing select REGMAP_I2C
@ 2020-02-26 14:34 Ian Kumlien
2020-02-26 15:29 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Ian Kumlien @ 2020-02-26 14:34 UTC (permalink / raw)
To: linux-media; +Cc: sakari.ailus, Ian Kumlien
While upgrading from 5.5.2 -> 5.5.6 I was surprised by:
ld: drivers/media/i2c/tvp5150.o: in function `tvp5150_probe':
tvp5150.c:(.text+0x11ac): undefined reference to
`__devm_regmap_init_i2c'
make: *** [Makefile:1078: vmlinux] Error 1
The fix was quick enough, make VIDEO_TVP5150 select REGMAP_I2C
And a quick grep showed that it was needed by more targets.
Signed-off-by: Ian Kumlien <ian.kumlien@gmail.com>
---
drivers/media/i2c/Kconfig | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index c68e002d26ea..1d1170de8c98 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -238,6 +238,7 @@ config VIDEO_ADV7604
tristate "Analog Devices ADV7604 decoder"
depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
depends on GPIOLIB || COMPILE_TEST
+ select REGMAP_I2C
select HDMI
select V4L2_FWNODE
help
@@ -379,6 +380,7 @@ config VIDEO_TVP5150
tristate "Texas Instruments TVP5150 video decoder"
depends on VIDEO_V4L2 && I2C
select V4L2_FWNODE
+ select REGMAP_I2C
help
Support for the Texas Instruments TVP5150 video decoder.
@@ -584,6 +586,7 @@ config VIDEO_IMX214
tristate "Sony IMX214 sensor support"
depends on GPIOLIB && I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
depends on V4L2_FWNODE
+ select REGMAP_I2C
help
This is a Video4Linux2 sensor driver for the Sony
IMX214 camera.
@@ -612,6 +615,7 @@ config VIDEO_IMX274
config VIDEO_IMX290
tristate "Sony IMX290 sensor support"
depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
+ select REGMAP_I2C
select V4L2_FWNODE
help
This is a Video4Linux2 sensor driver for the Sony
@@ -804,6 +808,7 @@ config VIDEO_OV7670
config VIDEO_OV7740
tristate "OmniVision OV7740 sensor support"
depends on I2C && VIDEO_V4L2
+ select REGMAP_I2C
help
This is a Video4Linux2 sensor driver for the OmniVision
OV7740 VGA camera sensor.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix build failure due to missing select REGMAP_I2C
2020-02-26 14:34 [PATCH] Fix build failure due to missing select REGMAP_I2C Ian Kumlien
@ 2020-02-26 15:29 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2020-02-26 15:29 UTC (permalink / raw)
To: Ian Kumlien; +Cc: linux-media
On Wed, Feb 26, 2020 at 03:34:05PM +0100, Ian Kumlien wrote:
> While upgrading from 5.5.2 -> 5.5.6 I was surprised by:
> ld: drivers/media/i2c/tvp5150.o: in function `tvp5150_probe':
> tvp5150.c:(.text+0x11ac): undefined reference to
> `__devm_regmap_init_i2c'
> make: *** [Makefile:1078: vmlinux] Error 1
>
> The fix was quick enough, make VIDEO_TVP5150 select REGMAP_I2C
> And a quick grep showed that it was needed by more targets.
>
> Signed-off-by: Ian Kumlien <ian.kumlien@gmail.com>
Thanks, Ian!
--
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-26 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-26 14:34 [PATCH] Fix build failure due to missing select REGMAP_I2C Ian Kumlien
2020-02-26 15:29 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.