All of lore.kernel.org
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: <ralf@linux-mips.org>, <paulburton@kernel.org>,
	<tglx@linutronix.de>, <sboyd@kernel.org>,
	<geert+renesas@glider.be>, <f4bug@amsat.org>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: YueHaibing <yuehaibing@huawei.com>, <linux-mips@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] MIPS: pic32mzda: Drop pointless static qualifier
Date: Thu, 27 Feb 2020 07:05:02 +0000	[thread overview]
Message-ID: <20200227070502.106762-1-yuehaibing@huawei.com> (raw)

There is no need to have the 'struct device_node *node' variable static
since new value always be assigned before use it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/mips/pic32/pic32mzda/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/pic32/pic32mzda/time.c b/arch/mips/pic32/pic32mzda/time.c
index 754924f26089..7174e9abbb1b 100644
--- a/arch/mips/pic32/pic32mzda/time.c
+++ b/arch/mips/pic32/pic32mzda/time.c
@@ -23,7 +23,7 @@ static const struct of_device_id pic32_infra_match[] = {
 
 static unsigned int pic32_xlate_core_timer_irq(void)
 {
-	static struct device_node *node;
+	struct device_node *node;
 	unsigned int irq;
 
 	node = of_find_matching_node(NULL, pic32_infra_match);




WARNING: multiple messages have this Message-ID (diff)
From: YueHaibing <yuehaibing@huawei.com>
To: ralf@linux-mips.org, paulburton@kernel.org, tglx@linutronix.de,
	sboyd@kernel.org, geert+renesas@glider.be, f4bug@amsat.org,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: YueHaibing <yuehaibing@huawei.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [PATCH -next] MIPS: pic32mzda: Drop pointless static qualifier
Date: Thu, 27 Feb 2020 07:05:02 +0000	[thread overview]
Message-ID: <20200227070502.106762-1-yuehaibing@huawei.com> (raw)

There is no need to have the 'struct device_node *node' variable static
since new value always be assigned before use it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 arch/mips/pic32/pic32mzda/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/pic32/pic32mzda/time.c b/arch/mips/pic32/pic32mzda/time.c
index 754924f26089..7174e9abbb1b 100644
--- a/arch/mips/pic32/pic32mzda/time.c
+++ b/arch/mips/pic32/pic32mzda/time.c
@@ -23,7 +23,7 @@ static const struct of_device_id pic32_infra_match[] = {
 
 static unsigned int pic32_xlate_core_timer_irq(void)
 {
-	static struct device_node *node;
+	struct device_node *node;
 	unsigned int irq;
 
 	node = of_find_matching_node(NULL, pic32_infra_match);

             reply	other threads:[~2020-02-27  7:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27  7:05 YueHaibing [this message]
2020-02-27  7:05 ` [PATCH -next] MIPS: pic32mzda: Drop pointless static qualifier YueHaibing
2020-02-28 11:45 ` Thomas Bogendoerfer
2020-02-28 11:45   ` Thomas Bogendoerfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200227070502.106762-1-yuehaibing@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=f4bug@amsat.org \
    --cc=geert+renesas@glider.be \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=paulburton@kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.