All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vigneshr@ti.com>, <miquel.raynal@bootlin.com>, <han.xu@nxp.com>,
	<richard@nod.at>, <mripard@kernel.org>, <wens@csie.org>,
	<mcoquelin.stm32@gmail.com>, <alexandre.torgue@st.com>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <vkoul@kernel.org>
Subject: [PATCH 3/7] mtd: rawnand: marvell: Use dma_request_chan() instead dma_request_slave_channel()
Date: Thu, 27 Feb 2020 14:37:45 +0200	[thread overview]
Message-ID: <20200227123749.24064-4-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20200227123749.24064-1-peter.ujfalusi@ti.com>

dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.

Use using dma_request_chan() directly to return the real error code.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/mtd/nand/raw/marvell_nand.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index b6c7e1903396..911430cca7c8 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -2743,11 +2743,14 @@ static int marvell_nfc_init_dma(struct marvell_nfc *nfc)
 	if (ret)
 		return ret;
 
-	nfc->dma_chan =	dma_request_slave_channel(nfc->dev, "data");
-	if (!nfc->dma_chan) {
-		dev_err(nfc->dev,
-			"Unable to request data DMA channel\n");
-		return -ENODEV;
+	nfc->dma_chan =	dma_request_chan(nfc->dev, "data");
+	if (IS_ERR(nfc->dma_chan)) {
+		ret = PTR_ERR(nfc->dma_chan);
+		nfc->dma_chan = NULL;
+		if (ret != -EPROBE_DEFER)
+			dev_err(nfc->dev, "DMA channel request failed: %d\n",
+				ret);
+		return ret;
 	}
 
 	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vigneshr@ti.com>, <miquel.raynal@bootlin.com>, <han.xu@nxp.com>,
	<richard@nod.at>, <mripard@kernel.org>, <wens@csie.org>,
	<mcoquelin.stm32@gmail.com>, <alexandre.torgue@st.com>
Cc: vkoul@kernel.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] mtd: rawnand: marvell: Use dma_request_chan() instead dma_request_slave_channel()
Date: Thu, 27 Feb 2020 14:37:45 +0200	[thread overview]
Message-ID: <20200227123749.24064-4-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20200227123749.24064-1-peter.ujfalusi@ti.com>

dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.

Use using dma_request_chan() directly to return the real error code.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/mtd/nand/raw/marvell_nand.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index b6c7e1903396..911430cca7c8 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -2743,11 +2743,14 @@ static int marvell_nfc_init_dma(struct marvell_nfc *nfc)
 	if (ret)
 		return ret;
 
-	nfc->dma_chan =	dma_request_slave_channel(nfc->dev, "data");
-	if (!nfc->dma_chan) {
-		dev_err(nfc->dev,
-			"Unable to request data DMA channel\n");
-		return -ENODEV;
+	nfc->dma_chan =	dma_request_chan(nfc->dev, "data");
+	if (IS_ERR(nfc->dma_chan)) {
+		ret = PTR_ERR(nfc->dma_chan);
+		nfc->dma_chan = NULL;
+		if (ret != -EPROBE_DEFER)
+			dev_err(nfc->dev, "DMA channel request failed: %d\n",
+				ret);
+		return ret;
 	}
 
 	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vigneshr@ti.com>, <miquel.raynal@bootlin.com>, <han.xu@nxp.com>,
	<richard@nod.at>, <mripard@kernel.org>, <wens@csie.org>,
	<mcoquelin.stm32@gmail.com>, <alexandre.torgue@st.com>
Cc: vkoul@kernel.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] mtd: rawnand: marvell: Use dma_request_chan() instead dma_request_slave_channel()
Date: Thu, 27 Feb 2020 14:37:45 +0200	[thread overview]
Message-ID: <20200227123749.24064-4-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20200227123749.24064-1-peter.ujfalusi@ti.com>

dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.

Use using dma_request_chan() directly to return the real error code.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/mtd/nand/raw/marvell_nand.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index b6c7e1903396..911430cca7c8 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -2743,11 +2743,14 @@ static int marvell_nfc_init_dma(struct marvell_nfc *nfc)
 	if (ret)
 		return ret;
 
-	nfc->dma_chan =	dma_request_slave_channel(nfc->dev, "data");
-	if (!nfc->dma_chan) {
-		dev_err(nfc->dev,
-			"Unable to request data DMA channel\n");
-		return -ENODEV;
+	nfc->dma_chan =	dma_request_chan(nfc->dev, "data");
+	if (IS_ERR(nfc->dma_chan)) {
+		ret = PTR_ERR(nfc->dma_chan);
+		nfc->dma_chan = NULL;
+		if (ret != -EPROBE_DEFER)
+			dev_err(nfc->dev, "DMA channel request failed: %d\n",
+				ret);
+		return ret;
 	}
 
 	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-02-27 12:38 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 12:37 [PATCH 0/7] mtd: rawnand: Convert drivers to use dma_request_chan() Peter Ujfalusi
2020-02-27 12:37 ` Peter Ujfalusi
2020-02-27 12:37 ` Peter Ujfalusi
2020-02-27 12:37 ` [PATCH 1/7] mtd: rawnand: gpmi: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-03-10 18:31   ` Miquel Raynal
2020-03-10 18:31     ` Miquel Raynal
2020-03-10 18:31     ` Miquel Raynal
2020-02-27 12:37 ` [PATCH 2/7] mtd: rawnand: marvell: Release DMA channel on error Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-03-10 18:30   ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-02-27 12:37 ` Peter Ujfalusi [this message]
2020-02-27 12:37   ` [PATCH 3/7] mtd: rawnand: marvell: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-03-10 18:30   ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-02-27 12:37 ` [PATCH 4/7] mtd: rawnand: sunxi: " Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-03-09  9:58   ` Maxime Ripard
2020-03-09  9:58     ` Maxime Ripard
2020-03-09  9:58     ` Maxime Ripard
2020-03-10 18:30   ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-02-27 12:37 ` [PATCH 5/7] mtd: rawnand: qcom: Release resources on failure within qcom_nandc_alloc() Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-03-10 18:30   ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-02-27 12:37 ` [PATCH 6/7] mtd: rawnand: qcom: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-03-10 18:30   ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-02-27 12:37 ` [PATCH 7/7] mtd: rawnand: stm32_fmc2: " Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-02-27 12:37   ` Peter Ujfalusi
2020-03-10 18:30   ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal
2020-03-10 18:30     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200227123749.24064-4-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alexandre.torgue@st.com \
    --cc=han.xu@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mripard@kernel.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=vkoul@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.