All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: miss to remove pp_sclk file
@ 2020-02-27 14:11 Yintian Tao
  2020-02-27 14:17 ` Christian König
  2020-02-27 14:39 ` Alex Deucher
  0 siblings, 2 replies; 4+ messages in thread
From: Yintian Tao @ 2020-02-27 14:11 UTC (permalink / raw)
  To: christian.koenig, Alexander.Deucher; +Cc: amd-gfx, Yintian Tao

Miss to remove pp_sclk file

Signed-off-by: Yintian Tao <yttao@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
index 9deff8cc9723..a43fc1c8ffd0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
@@ -3471,6 +3471,7 @@ void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev)
 	device_remove_file(adev->dev, &dev_attr_pp_cur_state);
 	device_remove_file(adev->dev, &dev_attr_pp_force_state);
 	device_remove_file(adev->dev, &dev_attr_pp_table);
+	device_remove_file(adev->dev, &dev_attr_pp_sclk);
 
 	device_remove_file(adev->dev, &dev_attr_pp_dpm_sclk);
 	device_remove_file(adev->dev, &dev_attr_pp_dpm_mclk);
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: miss to remove pp_sclk file
  2020-02-27 14:11 [PATCH] drm/amdgpu: miss to remove pp_sclk file Yintian Tao
@ 2020-02-27 14:17 ` Christian König
  2020-02-27 14:19   ` Tao, Yintian
  2020-02-27 14:39 ` Alex Deucher
  1 sibling, 1 reply; 4+ messages in thread
From: Christian König @ 2020-02-27 14:17 UTC (permalink / raw)
  To: Yintian Tao, Alexander.Deucher; +Cc: amd-gfx

Am 27.02.20 um 15:11 schrieb Yintian Tao:
> Miss to remove pp_sclk file
>
> Signed-off-by: Yintian Tao <yttao@amd.com>

Looks reasonable to me, but Alex can probably better judge.

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> index 9deff8cc9723..a43fc1c8ffd0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> @@ -3471,6 +3471,7 @@ void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev)
>   	device_remove_file(adev->dev, &dev_attr_pp_cur_state);
>   	device_remove_file(adev->dev, &dev_attr_pp_force_state);
>   	device_remove_file(adev->dev, &dev_attr_pp_table);
> +	device_remove_file(adev->dev, &dev_attr_pp_sclk);
>   
>   	device_remove_file(adev->dev, &dev_attr_pp_dpm_sclk);
>   	device_remove_file(adev->dev, &dev_attr_pp_dpm_mclk);

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu: miss to remove pp_sclk file
  2020-02-27 14:17 ` Christian König
@ 2020-02-27 14:19   ` Tao, Yintian
  0 siblings, 0 replies; 4+ messages in thread
From: Tao, Yintian @ 2020-02-27 14:19 UTC (permalink / raw)
  To: Koenig, Christian, Deucher, Alexander; +Cc: amd-gfx

Hi  Christian

Thanks a lot for your review


Hi  Alex


Can you help to review it? Thanks in advance.


Best Regards
Yintian Tao
-----Original Message-----
From: Koenig, Christian <Christian.Koenig@amd.com> 
Sent: 2020年2月27日 22:18
To: Tao, Yintian <Yintian.Tao@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: miss to remove pp_sclk file

Am 27.02.20 um 15:11 schrieb Yintian Tao:
> Miss to remove pp_sclk file
>
> Signed-off-by: Yintian Tao <yttao@amd.com>

Looks reasonable to me, but Alex can probably better judge.

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> index 9deff8cc9723..a43fc1c8ffd0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> @@ -3471,6 +3471,7 @@ void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev)
>   	device_remove_file(adev->dev, &dev_attr_pp_cur_state);
>   	device_remove_file(adev->dev, &dev_attr_pp_force_state);
>   	device_remove_file(adev->dev, &dev_attr_pp_table);
> +	device_remove_file(adev->dev, &dev_attr_pp_sclk);
>   
>   	device_remove_file(adev->dev, &dev_attr_pp_dpm_sclk);
>   	device_remove_file(adev->dev, &dev_attr_pp_dpm_mclk);

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: miss to remove pp_sclk file
  2020-02-27 14:11 [PATCH] drm/amdgpu: miss to remove pp_sclk file Yintian Tao
  2020-02-27 14:17 ` Christian König
@ 2020-02-27 14:39 ` Alex Deucher
  1 sibling, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2020-02-27 14:39 UTC (permalink / raw)
  To: Yintian Tao; +Cc: Deucher, Alexander, Christian Koenig, amd-gfx list

On Thu, Feb 27, 2020 at 9:11 AM Yintian Tao <yttao@amd.com> wrote:
>
> Miss to remove pp_sclk file
>
> Signed-off-by: Yintian Tao <yttao@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> index 9deff8cc9723..a43fc1c8ffd0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> @@ -3471,6 +3471,7 @@ void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev)
>         device_remove_file(adev->dev, &dev_attr_pp_cur_state);
>         device_remove_file(adev->dev, &dev_attr_pp_force_state);
>         device_remove_file(adev->dev, &dev_attr_pp_table);
> +       device_remove_file(adev->dev, &dev_attr_pp_sclk);
>
>         device_remove_file(adev->dev, &dev_attr_pp_dpm_sclk);
>         device_remove_file(adev->dev, &dev_attr_pp_dpm_mclk);
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-27 14:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-27 14:11 [PATCH] drm/amdgpu: miss to remove pp_sclk file Yintian Tao
2020-02-27 14:17 ` Christian König
2020-02-27 14:19   ` Tao, Yintian
2020-02-27 14:39 ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.