[PATCH v2 0/2] Fix spelling/formatting in fuzzing patches

[PATCH v2 0/2] Fix spelling/formatting in fuzzing patches

[Alexander Bulekov]

These patches fix some spelling and line-length violations introduced by
the device-fuzzing changes:
https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg05965.html

v2: fixes comment style in the fork_fuzz.ld linker script

Alexander Bulekov (2):
  fuzz: fix style/typos in linker-script comments
  qtest: fix fuzzer-related 80-char limit violations

 qtest.c                       |  3 ++-
 tests/qtest/fuzz/fork_fuzz.ld | 16 ++++++++++------
 tests/qtest/fuzz/qos_fuzz.c   |  5 ++++-
 3 files changed, 16 insertions(+), 8 deletions(-)

-- 
2.25.0

[PATCH v2 1/2] fuzz: fix style/typos in linker-script comments

[Alexander Bulekov]

Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 tests/qtest/fuzz/fork_fuzz.ld | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/tests/qtest/fuzz/fork_fuzz.ld b/tests/qtest/fuzz/fork_fuzz.ld
index b23a59f194..e086bba873 100644
--- a/tests/qtest/fuzz/fork_fuzz.ld
+++ b/tests/qtest/fuzz/fork_fuzz.ld
@@ -1,7 +1,8 @@
-/* We adjust linker script modification to place all of the stuff that needs to
- * persist across fuzzing runs into a contiguous seciton of memory. Then, it is
+/*
+ * We adjust linker script modification to place all of the stuff that needs to
+ * persist across fuzzing runs into a contiguous section of memory. Then, it is
  * easy to re-map the counter-related memory as shared.
-*/
+ */
 
 SECTIONS
 {
@@ -17,7 +18,8 @@ SECTIONS
   }
   .data.fuzz_ordered :
   {
-      /* Coverage counters. They're not necessary for fuzzing, but are useful
+      /*
+       * Coverage counters. They're not necessary for fuzzing, but are useful
        * for analyzing the fuzzing performance
        */
       __start___llvm_prf_cnts = .;
@@ -32,6 +34,8 @@ SECTIONS
       __FUZZ_COUNTERS_END = .;
   }
 }
-/* Dont overwrite the SECTIONS in the default linker script. Instead insert the
- * above into the default script */
+/*
+ * Don't overwrite the SECTIONS in the default linker script. Instead insert the
+ * above into the default script
+ */
 INSERT AFTER .data;
-- 
2.25.0

[PATCH v2 2/2] qtest: fix fuzzer-related 80-char limit violations

[Alexander Bulekov]

Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 qtest.c                     | 3 ++-
 tests/qtest/fuzz/qos_fuzz.c | 5 ++++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/qtest.c b/qtest.c
index 1af4e1b08d..5672b75c35 100644
--- a/qtest.c
+++ b/qtest.c
@@ -794,7 +794,8 @@ void qtest_server_init(const char *qtest_chrdev, const char *qtest_log, Error **
     }
 }
 
-void qtest_server_set_send_handler(void (*send)(void*, const char*), void *opaque)
+void qtest_server_set_send_handler(void (*send)(void*, const char*),
+                                   void *opaque)
 {
     qtest_server_send = send;
     qtest_server_send_opaque = opaque;
diff --git a/tests/qtest/fuzz/qos_fuzz.c b/tests/qtest/fuzz/qos_fuzz.c
index bbb17470ff..1a99277d60 100644
--- a/tests/qtest/fuzz/qos_fuzz.c
+++ b/tests/qtest/fuzz/qos_fuzz.c
@@ -120,7 +120,10 @@ static void walk_path(QOSGraphNode *orig_path, int len)
     QOSGraphNode *path;
     QOSGraphEdge *edge;
 
-    /* etype set to QEDGE_CONSUMED_BY so that machine can add to the command line */
+    /*
+     * etype set to QEDGE_CONSUMED_BY so that machine can add to the command
+     * line
+     */
     QOSEdgeType etype = QEDGE_CONSUMED_BY;
 
     /* twice QOS_PATH_MAX_ELEMENT_SIZE since each edge can have its arg */
-- 
2.25.0

Re: [PATCH v2 0/2] Fix spelling/formatting in fuzzing patches

[Darren Kenny]

For the series:

Reviewed-by: Darren Kenny <darren.kenny@oracle.com>

Thanks,

Darren.

On Wed, Feb 26, 2020 at 10:14:37PM -0500, Alexander Bulekov wrote:
>These patches fix some spelling and line-length violations introduced by
>the device-fuzzing changes:
>https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg05965.html
>
>v2: fixes comment style in the fork_fuzz.ld linker script
>
>Alexander Bulekov (2):
>  fuzz: fix style/typos in linker-script comments
>  qtest: fix fuzzer-related 80-char limit violations
>
> qtest.c                       |  3 ++-
> tests/qtest/fuzz/fork_fuzz.ld | 16 ++++++++++------
> tests/qtest/fuzz/qos_fuzz.c   |  5 ++++-
> 3 files changed, 16 insertions(+), 8 deletions(-)
>
>-- 
>2.25.0
>
>

Re: [PATCH v2 0/2] Fix spelling/formatting in fuzzing patches

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

On Wed, Feb 26, 2020 at 10:14:37PM -0500, Alexander Bulekov wrote:
> These patches fix some spelling and line-length violations introduced by
> the device-fuzzing changes:
> https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg05965.html
> 
> v2: fixes comment style in the fork_fuzz.ld linker script
> 
> Alexander Bulekov (2):
>   fuzz: fix style/typos in linker-script comments
>   qtest: fix fuzzer-related 80-char limit violations
> 
>  qtest.c                       |  3 ++-
>  tests/qtest/fuzz/fork_fuzz.ld | 16 ++++++++++------
>  tests/qtest/fuzz/qos_fuzz.c   |  5 ++++-
>  3 files changed, 16 insertions(+), 8 deletions(-)
> 
> -- 
> 2.25.0
> 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]