* Re: [PATCH] thermal: exynos: Silence warning during deferred probe
2020-02-28 9:23 ` [PATCH] thermal: exynos: Silence warning during deferred probe Marek Szyprowski
@ 2020-02-28 10:06 ` Amit Kucheria
2020-02-28 10:29 ` Bartlomiej Zolnierkiewicz
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Amit Kucheria @ 2020-02-28 10:06 UTC (permalink / raw)
To: Marek Szyprowski
Cc: Linux PM list, linux-samsung-soc, Bartlomiej Zolnierkiewicz,
Daniel Lezcano, Zhang Rui, Krzysztof Kozlowski
On Fri, Feb 28, 2020 at 2:53 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Don't confuse user with meaningless warning about the failure of
> registering sensors in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index fd4a17812f33..e9a90bc23b11 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1094,7 +1094,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)
> &exynos_sensor_ops);
> if (IS_ERR(data->tzd)) {
> ret = PTR_ERR(data->tzd);
> - dev_err(&pdev->dev, "Failed to register sensor: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Failed to register sensor: %d\n",
> + ret);
> goto err_sclk;
> }
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] thermal: exynos: Silence warning during deferred probe
2020-02-28 9:23 ` [PATCH] thermal: exynos: Silence warning during deferred probe Marek Szyprowski
2020-02-28 10:06 ` Amit Kucheria
@ 2020-02-28 10:29 ` Bartlomiej Zolnierkiewicz
2020-02-28 11:30 ` Krzysztof Kozlowski
2020-03-12 10:57 ` Daniel Lezcano
3 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-02-28 10:29 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-pm, linux-samsung-soc, Daniel Lezcano, Zhang Rui,
Amit Kucheria, Krzysztof Kozlowski
On 2/28/20 10:23 AM, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about the failure of
> registering sensors in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/thermal/samsung/exynos_tmu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index fd4a17812f33..e9a90bc23b11 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1094,7 +1094,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)
> &exynos_sensor_ops);
> if (IS_ERR(data->tzd)) {
> ret = PTR_ERR(data->tzd);
> - dev_err(&pdev->dev, "Failed to register sensor: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Failed to register sensor: %d\n",
> + ret);
> goto err_sclk;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] thermal: exynos: Silence warning during deferred probe
2020-02-28 9:23 ` [PATCH] thermal: exynos: Silence warning during deferred probe Marek Szyprowski
2020-02-28 10:06 ` Amit Kucheria
2020-02-28 10:29 ` Bartlomiej Zolnierkiewicz
@ 2020-02-28 11:30 ` Krzysztof Kozlowski
2020-03-12 10:57 ` Daniel Lezcano
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2020-02-28 11:30 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-pm, linux-samsung-soc, Bartlomiej Zolnierkiewicz,
Daniel Lezcano, Zhang Rui, Amit Kucheria
On Fri, Feb 28, 2020 at 10:23:31AM +0100, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about the failure of
> registering sensors in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] thermal: exynos: Silence warning during deferred probe
2020-02-28 9:23 ` [PATCH] thermal: exynos: Silence warning during deferred probe Marek Szyprowski
` (2 preceding siblings ...)
2020-02-28 11:30 ` Krzysztof Kozlowski
@ 2020-03-12 10:57 ` Daniel Lezcano
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2020-03-12 10:57 UTC (permalink / raw)
To: Marek Szyprowski, linux-pm, linux-samsung-soc
Cc: Bartlomiej Zolnierkiewicz, Zhang Rui, Amit Kucheria, Krzysztof Kozlowski
On 28/02/2020 10:23, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about the failure of
> registering sensors in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Applied, thanks
> ---
> drivers/thermal/samsung/exynos_tmu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index fd4a17812f33..e9a90bc23b11 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1094,7 +1094,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)
> &exynos_sensor_ops);
> if (IS_ERR(data->tzd)) {
> ret = PTR_ERR(data->tzd);
> - dev_err(&pdev->dev, "Failed to register sensor: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Failed to register sensor: %d\n",
> + ret);
> goto err_sclk;
> }
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread