* [PATCH] usb: dwc2: Silence warning about supplies during deferred probe
[not found] <CGME20200228092607eucas1p20faf7fdabdf52586f18e8781e371f04d@eucas1p2.samsung.com>
@ 2020-02-28 9:25 ` Marek Szyprowski
2020-02-28 11:32 ` Krzysztof Kozlowski
2020-03-05 6:47 ` Minas Harutyunyan
0 siblings, 2 replies; 3+ messages in thread
From: Marek Szyprowski @ 2020-02-28 9:25 UTC (permalink / raw)
To: linux-usb, linux-samsung-soc
Cc: Marek Szyprowski, Minas Harutyunyan, Greg Kroah-Hartman,
Krzysztof Kozlowski
Don't confuse user with meaningless warning about the failure in getting
supplies in case of deferred probe.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/usb/dwc2/platform.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
index 3c6ce09a6db5..eb110d368623 100644
--- a/drivers/usb/dwc2/platform.c
+++ b/drivers/usb/dwc2/platform.c
@@ -285,7 +285,9 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg *hsotg)
ret = devm_regulator_bulk_get(hsotg->dev, ARRAY_SIZE(hsotg->supplies),
hsotg->supplies);
if (ret) {
- dev_err(hsotg->dev, "failed to request supplies: %d\n", ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(hsotg->dev, "failed to request supplies: %d\n",
+ ret);
return ret;
}
return 0;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: dwc2: Silence warning about supplies during deferred probe
2020-02-28 9:25 ` [PATCH] usb: dwc2: Silence warning about supplies during deferred probe Marek Szyprowski
@ 2020-02-28 11:32 ` Krzysztof Kozlowski
2020-03-05 6:47 ` Minas Harutyunyan
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2020-02-28 11:32 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-usb, linux-samsung-soc, Minas Harutyunyan, Greg Kroah-Hartman
On Fri, Feb 28, 2020 at 10:25:57AM +0100, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about the failure in getting
> supplies in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/usb/dwc2/platform.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: dwc2: Silence warning about supplies during deferred probe
2020-02-28 9:25 ` [PATCH] usb: dwc2: Silence warning about supplies during deferred probe Marek Szyprowski
2020-02-28 11:32 ` Krzysztof Kozlowski
@ 2020-03-05 6:47 ` Minas Harutyunyan
1 sibling, 0 replies; 3+ messages in thread
From: Minas Harutyunyan @ 2020-03-05 6:47 UTC (permalink / raw)
To: Marek Szyprowski, linux-usb, linux-samsung-soc
Cc: Greg Kroah-Hartman, Krzysztof Kozlowski
On 2/28/2020 1:25 PM, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about the failure in getting
> supplies in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
> ---
> drivers/usb/dwc2/platform.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
> index 3c6ce09a6db5..eb110d368623 100644
> --- a/drivers/usb/dwc2/platform.c
> +++ b/drivers/usb/dwc2/platform.c
> @@ -285,7 +285,9 @@ static int dwc2_lowlevel_hw_init(struct dwc2_hsotg *hsotg)
> ret = devm_regulator_bulk_get(hsotg->dev, ARRAY_SIZE(hsotg->supplies),
> hsotg->supplies);
> if (ret) {
> - dev_err(hsotg->dev, "failed to request supplies: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(hsotg->dev, "failed to request supplies: %d\n",
> + ret);
> return ret;
> }
> return 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-05 6:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200228092607eucas1p20faf7fdabdf52586f18e8781e371f04d@eucas1p2.samsung.com>
2020-02-28 9:25 ` [PATCH] usb: dwc2: Silence warning about supplies during deferred probe Marek Szyprowski
2020-02-28 11:32 ` Krzysztof Kozlowski
2020-03-05 6:47 ` Minas Harutyunyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.