All of lore.kernel.org
 help / color / mirror / Atom feed
* [MPTCP] [mptcp:t/mptcp-Implement-path-manager-interface-commands 23/25] net//mptcp/pm.c:46:8: error: implicit declaration of function 'mptcp_subflow_connect'
@ 2020-02-29  2:09 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-02-29  2:09 UTC (permalink / raw)
  To: mptcp

[-- Attachment #1: Type: text/plain, Size: 7962 bytes --]

tree:   https://github.com/multipath-tcp/mptcp_net-next.git t/mptcp-Implement-path-manager-interface-commands
head:   a28e79bf6de027fea5d0522a32a686aacf5658a7
commit: eba1df51e6151d1cc04a559911cf905992581b22 [23/25] tgupdate: merge t/mptcp-Implement-path-manager-interface-commands base into t/mptcp-Implement-path-manager-interface-commands
config: mips-randconfig-a001-20200228 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 5.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout eba1df51e6151d1cc04a559911cf905992581b22
        # save the attached .config to linux build tree
        GCC_VERSION=5.5.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>

Note: the mptcp/t/mptcp-Implement-path-manager-interface-commands HEAD a28e79bf6de027fea5d0522a32a686aacf5658a7 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   net//mptcp/pm.c: In function 'mptcp_pm_announce_addr':
   net//mptcp/pm.c:18:21: error: 'msk' redeclared as different kind of symbol
     struct mptcp_sock *msk = mptcp_token_get_sock(token);
                        ^
   net//mptcp/pm.c:15:47: note: previous definition of 'msk' was here
    int mptcp_pm_announce_addr(struct mptcp_sock *msk,
                                                  ^
   net//mptcp/pm.c:18:48: error: 'token' undeclared (first use in this function)
     struct mptcp_sock *msk = mptcp_token_get_sock(token);
                                                   ^
   net//mptcp/pm.c:18:48: note: each undeclared identifier is reported only once for each function it appears in
   net//mptcp/pm.c:30:14: error: 'struct mptcp_pm_data' has no member named 'remote_valid'
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                 ^
   net//mptcp/pm.c:30:31: error: 'remote_id' undeclared (first use in this function)
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                                  ^
   net//mptcp/pm.c:30:51: error: 'struct mptcp_pm_data' has no member named 'remote_id'
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                                                      ^
   net//mptcp/pm.c:38:18: error: incompatible types when assigning to type 'struct in_addr' from type 'const struct mptcp_addr_info'
      local.sin_addr = *addr;
                     ^
   net//mptcp/pm.c:42:29: error: 'struct mptcp_pm_data' has no member named 'remote_family'
     remote.sin_family = msk->pm.remote_family;
                                ^
   net//mptcp/pm.c:44:27: error: 'struct mptcp_pm_data' has no member named 'remote_addr'
     remote.sin_addr = msk->pm.remote_addr;
                              ^
>> net//mptcp/pm.c:46:8: error: implicit declaration of function 'mptcp_subflow_connect' [-Werror=implicit-function-declaration]
     err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
           ^
   net//mptcp/pm.c: In function 'mptcp_pm_remove_addr':
   net//mptcp/pm.c:56:21: error: 'msk' redeclared as different kind of symbol
     struct mptcp_sock *msk = mptcp_token_get_sock(token);
                        ^
   net//mptcp/pm.c:54:45: note: previous definition of 'msk' was here
    int mptcp_pm_remove_addr(struct mptcp_sock *msk, u8 local_id)
                                                ^
   net//mptcp/pm.c:56:48: error: 'token' undeclared (first use in this function)
     struct mptcp_sock *msk = mptcp_token_get_sock(token);
                                                   ^
   net//mptcp/pm.c:68:14: error: 'struct mptcp_pm_data' has no member named 'remote_valid'
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                 ^
   net//mptcp/pm.c:68:31: error: 'remote_id' undeclared (first use in this function)
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                                  ^
   net//mptcp/pm.c:68:51: error: 'struct mptcp_pm_data' has no member named 'remote_id'
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                                                      ^
   net//mptcp/pm.c:75:6: error: 'addr' undeclared (first use in this function)
     if (addr)
         ^
   net//mptcp/pm.c:80:30: error: 'struct mptcp_pm_data' has no member named 'remote_family'
     remote.sin6_family = msk->pm.remote_family;
                                 ^
   net//mptcp/pm.c:82:28: error: 'struct mptcp_pm_data' has no member named 'remote_addr6'
     remote.sin6_addr = msk->pm.remote_addr6;
                               ^
   cc1: some warnings being treated as errors

vim +/mptcp_subflow_connect +46 net//mptcp/pm.c

532e0037f0c3af Peter Krystad 2020-02-26  14  
cb6c1764eb317d Paolo Abeni   2020-02-24  15  int mptcp_pm_announce_addr(struct mptcp_sock *msk,
cb6c1764eb317d Paolo Abeni   2020-02-24  16  			   const struct mptcp_addr_info *addr)
532e0037f0c3af Peter Krystad 2020-02-26  17  {
4b738110d9bfa5 Peter Krystad 2020-02-26  18  	struct mptcp_sock *msk = mptcp_token_get_sock(token);
4b738110d9bfa5 Peter Krystad 2020-02-26  19  	struct sockaddr_in remote;
4b738110d9bfa5 Peter Krystad 2020-02-26  20  	struct sockaddr_in local;
4b738110d9bfa5 Peter Krystad 2020-02-26  21  	struct sock *sk;
4b738110d9bfa5 Peter Krystad 2020-02-26  22  	int err;
4b738110d9bfa5 Peter Krystad 2020-02-26  23  
4b738110d9bfa5 Peter Krystad 2020-02-26  24  	if (!msk)
4b738110d9bfa5 Peter Krystad 2020-02-26  25  		return -EINVAL;
4b738110d9bfa5 Peter Krystad 2020-02-26  26  
4b738110d9bfa5 Peter Krystad 2020-02-26  27  	pr_debug("msk=%p", msk);
4b738110d9bfa5 Peter Krystad 2020-02-26  28  
4b738110d9bfa5 Peter Krystad 2020-02-26  29  	sk = (struct sock *)msk;
4b738110d9bfa5 Peter Krystad 2020-02-26  30  	if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
4b738110d9bfa5 Peter Krystad 2020-02-26  31  		err = -EBADR;
4b738110d9bfa5 Peter Krystad 2020-02-26  32  		goto create_put;
4b738110d9bfa5 Peter Krystad 2020-02-26  33  	}
4b738110d9bfa5 Peter Krystad 2020-02-26  34  
4b738110d9bfa5 Peter Krystad 2020-02-26  35  	local.sin_family = AF_INET;
4b738110d9bfa5 Peter Krystad 2020-02-26  36  	local.sin_port = 0;
4b738110d9bfa5 Peter Krystad 2020-02-26  37  	if (addr)
4b738110d9bfa5 Peter Krystad 2020-02-26 @38  		local.sin_addr = *addr;
4b738110d9bfa5 Peter Krystad 2020-02-26  39  	else
4b738110d9bfa5 Peter Krystad 2020-02-26  40  		local.sin_addr.s_addr = htonl(INADDR_ANY);
4b738110d9bfa5 Peter Krystad 2020-02-26  41  
4b738110d9bfa5 Peter Krystad 2020-02-26  42  	remote.sin_family = msk->pm.remote_family;
4b738110d9bfa5 Peter Krystad 2020-02-26  43  	remote.sin_port = inet_sk(sk)->inet_dport;
4b738110d9bfa5 Peter Krystad 2020-02-26  44  	remote.sin_addr = msk->pm.remote_addr;
4b738110d9bfa5 Peter Krystad 2020-02-26  45  
4b738110d9bfa5 Peter Krystad 2020-02-26 @46  	err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
4b738110d9bfa5 Peter Krystad 2020-02-26  47  				    (struct sockaddr *)&remote, remote_id);
4b738110d9bfa5 Peter Krystad 2020-02-26  48  
4b738110d9bfa5 Peter Krystad 2020-02-26  49  create_put:
4b738110d9bfa5 Peter Krystad 2020-02-26  50  	sock_put(sk);
4b738110d9bfa5 Peter Krystad 2020-02-26  51  	return err;
532e0037f0c3af Peter Krystad 2020-02-26  52  }
532e0037f0c3af Peter Krystad 2020-02-26  53  

:::::: The code at line 46 was first introduced by commit
:::::: 4b738110d9bfa5e1a763123e0ef6d0d2f5852782 mptcp: Implement path manager interface commands

:::::: TO: Peter Krystad <peter.krystad(a)linux.intel.com>
:::::: CC: Matthieu Baerts <matthieu.baerts(a)tessares.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28948 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [mptcp:t/mptcp-Implement-path-manager-interface-commands 23/25] net//mptcp/pm.c:46:8: error: implicit declaration of function 'mptcp_subflow_connect'
@ 2020-02-29  2:09 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-02-29  2:09 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 7956 bytes --]

tree:   https://github.com/multipath-tcp/mptcp_net-next.git t/mptcp-Implement-path-manager-interface-commands
head:   a28e79bf6de027fea5d0522a32a686aacf5658a7
commit: eba1df51e6151d1cc04a559911cf905992581b22 [23/25] tgupdate: merge t/mptcp-Implement-path-manager-interface-commands base into t/mptcp-Implement-path-manager-interface-commands
config: mips-randconfig-a001-20200228 (attached as .config)
compiler: mipsel-linux-gcc (GCC) 5.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout eba1df51e6151d1cc04a559911cf905992581b22
        # save the attached .config to linux build tree
        GCC_VERSION=5.5.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

Note: the mptcp/t/mptcp-Implement-path-manager-interface-commands HEAD a28e79bf6de027fea5d0522a32a686aacf5658a7 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   net//mptcp/pm.c: In function 'mptcp_pm_announce_addr':
   net//mptcp/pm.c:18:21: error: 'msk' redeclared as different kind of symbol
     struct mptcp_sock *msk = mptcp_token_get_sock(token);
                        ^
   net//mptcp/pm.c:15:47: note: previous definition of 'msk' was here
    int mptcp_pm_announce_addr(struct mptcp_sock *msk,
                                                  ^
   net//mptcp/pm.c:18:48: error: 'token' undeclared (first use in this function)
     struct mptcp_sock *msk = mptcp_token_get_sock(token);
                                                   ^
   net//mptcp/pm.c:18:48: note: each undeclared identifier is reported only once for each function it appears in
   net//mptcp/pm.c:30:14: error: 'struct mptcp_pm_data' has no member named 'remote_valid'
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                 ^
   net//mptcp/pm.c:30:31: error: 'remote_id' undeclared (first use in this function)
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                                  ^
   net//mptcp/pm.c:30:51: error: 'struct mptcp_pm_data' has no member named 'remote_id'
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                                                      ^
   net//mptcp/pm.c:38:18: error: incompatible types when assigning to type 'struct in_addr' from type 'const struct mptcp_addr_info'
      local.sin_addr = *addr;
                     ^
   net//mptcp/pm.c:42:29: error: 'struct mptcp_pm_data' has no member named 'remote_family'
     remote.sin_family = msk->pm.remote_family;
                                ^
   net//mptcp/pm.c:44:27: error: 'struct mptcp_pm_data' has no member named 'remote_addr'
     remote.sin_addr = msk->pm.remote_addr;
                              ^
>> net//mptcp/pm.c:46:8: error: implicit declaration of function 'mptcp_subflow_connect' [-Werror=implicit-function-declaration]
     err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
           ^
   net//mptcp/pm.c: In function 'mptcp_pm_remove_addr':
   net//mptcp/pm.c:56:21: error: 'msk' redeclared as different kind of symbol
     struct mptcp_sock *msk = mptcp_token_get_sock(token);
                        ^
   net//mptcp/pm.c:54:45: note: previous definition of 'msk' was here
    int mptcp_pm_remove_addr(struct mptcp_sock *msk, u8 local_id)
                                                ^
   net//mptcp/pm.c:56:48: error: 'token' undeclared (first use in this function)
     struct mptcp_sock *msk = mptcp_token_get_sock(token);
                                                   ^
   net//mptcp/pm.c:68:14: error: 'struct mptcp_pm_data' has no member named 'remote_valid'
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                 ^
   net//mptcp/pm.c:68:31: error: 'remote_id' undeclared (first use in this function)
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                                  ^
   net//mptcp/pm.c:68:51: error: 'struct mptcp_pm_data' has no member named 'remote_id'
     if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
                                                      ^
   net//mptcp/pm.c:75:6: error: 'addr' undeclared (first use in this function)
     if (addr)
         ^
   net//mptcp/pm.c:80:30: error: 'struct mptcp_pm_data' has no member named 'remote_family'
     remote.sin6_family = msk->pm.remote_family;
                                 ^
   net//mptcp/pm.c:82:28: error: 'struct mptcp_pm_data' has no member named 'remote_addr6'
     remote.sin6_addr = msk->pm.remote_addr6;
                               ^
   cc1: some warnings being treated as errors

vim +/mptcp_subflow_connect +46 net//mptcp/pm.c

532e0037f0c3af Peter Krystad 2020-02-26  14  
cb6c1764eb317d Paolo Abeni   2020-02-24  15  int mptcp_pm_announce_addr(struct mptcp_sock *msk,
cb6c1764eb317d Paolo Abeni   2020-02-24  16  			   const struct mptcp_addr_info *addr)
532e0037f0c3af Peter Krystad 2020-02-26  17  {
4b738110d9bfa5 Peter Krystad 2020-02-26  18  	struct mptcp_sock *msk = mptcp_token_get_sock(token);
4b738110d9bfa5 Peter Krystad 2020-02-26  19  	struct sockaddr_in remote;
4b738110d9bfa5 Peter Krystad 2020-02-26  20  	struct sockaddr_in local;
4b738110d9bfa5 Peter Krystad 2020-02-26  21  	struct sock *sk;
4b738110d9bfa5 Peter Krystad 2020-02-26  22  	int err;
4b738110d9bfa5 Peter Krystad 2020-02-26  23  
4b738110d9bfa5 Peter Krystad 2020-02-26  24  	if (!msk)
4b738110d9bfa5 Peter Krystad 2020-02-26  25  		return -EINVAL;
4b738110d9bfa5 Peter Krystad 2020-02-26  26  
4b738110d9bfa5 Peter Krystad 2020-02-26  27  	pr_debug("msk=%p", msk);
4b738110d9bfa5 Peter Krystad 2020-02-26  28  
4b738110d9bfa5 Peter Krystad 2020-02-26  29  	sk = (struct sock *)msk;
4b738110d9bfa5 Peter Krystad 2020-02-26  30  	if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
4b738110d9bfa5 Peter Krystad 2020-02-26  31  		err = -EBADR;
4b738110d9bfa5 Peter Krystad 2020-02-26  32  		goto create_put;
4b738110d9bfa5 Peter Krystad 2020-02-26  33  	}
4b738110d9bfa5 Peter Krystad 2020-02-26  34  
4b738110d9bfa5 Peter Krystad 2020-02-26  35  	local.sin_family = AF_INET;
4b738110d9bfa5 Peter Krystad 2020-02-26  36  	local.sin_port = 0;
4b738110d9bfa5 Peter Krystad 2020-02-26  37  	if (addr)
4b738110d9bfa5 Peter Krystad 2020-02-26 @38  		local.sin_addr = *addr;
4b738110d9bfa5 Peter Krystad 2020-02-26  39  	else
4b738110d9bfa5 Peter Krystad 2020-02-26  40  		local.sin_addr.s_addr = htonl(INADDR_ANY);
4b738110d9bfa5 Peter Krystad 2020-02-26  41  
4b738110d9bfa5 Peter Krystad 2020-02-26  42  	remote.sin_family = msk->pm.remote_family;
4b738110d9bfa5 Peter Krystad 2020-02-26  43  	remote.sin_port = inet_sk(sk)->inet_dport;
4b738110d9bfa5 Peter Krystad 2020-02-26  44  	remote.sin_addr = msk->pm.remote_addr;
4b738110d9bfa5 Peter Krystad 2020-02-26  45  
4b738110d9bfa5 Peter Krystad 2020-02-26 @46  	err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
4b738110d9bfa5 Peter Krystad 2020-02-26  47  				    (struct sockaddr *)&remote, remote_id);
4b738110d9bfa5 Peter Krystad 2020-02-26  48  
4b738110d9bfa5 Peter Krystad 2020-02-26  49  create_put:
4b738110d9bfa5 Peter Krystad 2020-02-26  50  	sock_put(sk);
4b738110d9bfa5 Peter Krystad 2020-02-26  51  	return err;
532e0037f0c3af Peter Krystad 2020-02-26  52  }
532e0037f0c3af Peter Krystad 2020-02-26  53  

:::::: The code at line 46 was first introduced by commit
:::::: 4b738110d9bfa5e1a763123e0ef6d0d2f5852782 mptcp: Implement path manager interface commands

:::::: TO: Peter Krystad <peter.krystad@linux.intel.com>
:::::: CC: Matthieu Baerts <matthieu.baerts@tessares.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28948 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-29  2:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-29  2:09 [MPTCP] [mptcp:t/mptcp-Implement-path-manager-interface-commands 23/25] net//mptcp/pm.c:46:8: error: implicit declaration of function 'mptcp_subflow_connect' kbuild test robot
2020-02-29  2:09 ` kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.