All of lore.kernel.org
 help / color / mirror / Atom feed
* [djwong-xfs:repair-quota 41/42] fs/xfs/scrub/dir_repair.c:448:1: sparse: sparse: symbol 'xrep_dir_reset_fork' was not declared. Should it be static?
@ 2020-02-29 10:11 kbuild test robot
  2020-02-29 10:11 ` [RFC PATCH djwong-xfs] xfs: xrep_dir_reset_fork can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-02-29 10:11 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git repair-quota
head:   7c012203cb168efe69d992ce8f58574c6aceeb3d
commit: 8f3baae88a748903f3b767a8ed3e3ae1b37b8b21 [41/42] xfs: online repair of directories
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.1-173-ge0787745-dirty
        git checkout 8f3baae88a748903f3b767a8ed3e3ae1b37b8b21
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)

>> fs/xfs/scrub/dir_repair.c:448:1: sparse: sparse: symbol 'xrep_dir_reset_fork' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH djwong-xfs] xfs: xrep_dir_reset_fork can be static
  2020-02-29 10:11 [djwong-xfs:repair-quota 41/42] fs/xfs/scrub/dir_repair.c:448:1: sparse: sparse: symbol 'xrep_dir_reset_fork' was not declared. Should it be static? kbuild test robot
@ 2020-02-29 10:11 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-02-29 10:11 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]


Fixes: 8f3baae88a74 ("xfs: online repair of directories")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 dir_repair.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/scrub/dir_repair.c b/fs/xfs/scrub/dir_repair.c
index 1fdc99fa6c812..348a356198100 100644
--- a/fs/xfs/scrub/dir_repair.c
+++ b/fs/xfs/scrub/dir_repair.c
@@ -444,7 +444,7 @@ xrep_dir_reset_nonlocal(
 }
 
 /* Free all the directory blocks and delete the fork. */
-int
+static int
 xrep_dir_reset_fork(
 	struct xrep_dir		*rd)
 {

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-29 10:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-29 10:11 [djwong-xfs:repair-quota 41/42] fs/xfs/scrub/dir_repair.c:448:1: sparse: sparse: symbol 'xrep_dir_reset_fork' was not declared. Should it be static? kbuild test robot
2020-02-29 10:11 ` [RFC PATCH djwong-xfs] xfs: xrep_dir_reset_fork can be static kbuild test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.