* [PATCH] netfilter: clean up some indenting
@ 2020-02-25 6:42 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-02-25 6:42 UTC (permalink / raw)
To: Pablo Neira Ayuso, Manoj Basapathi
Cc: Jozsef Kadlecsik, Florian Westphal, Jakub Kicinski,
netfilter-devel, coreteam, kernel-janitors
These lines were indented wrong so Smatch complained.
net/netfilter/xt_IDLETIMER.c:81 idletimer_tg_show() warn: inconsistent indenting
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
net/netfilter/xt_IDLETIMER.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/net/netfilter/xt_IDLETIMER.c b/net/netfilter/xt_IDLETIMER.c
index d620bbf13b30..75bd0e5dd312 100644
--- a/net/netfilter/xt_IDLETIMER.c
+++ b/net/netfilter/xt_IDLETIMER.c
@@ -77,9 +77,8 @@ static ssize_t idletimer_tg_show(struct device *dev,
ktimespec = ktime_to_timespec64(expires_alarm);
time_diff = ktimespec.tv_sec;
} else {
- expires = timer->timer.expires;
- time_diff = jiffies_to_msecs(
- expires - jiffies) / 1000;
+ expires = timer->timer.expires;
+ time_diff = jiffies_to_msecs(expires - jiffies) / 1000;
}
}
@@ -216,7 +215,7 @@ static int idletimer_tg_create_v1(struct idletimer_tg_info_v1 *info)
kobject_uevent(idletimer_tg_kobj,KOBJ_ADD);
list_add(&info->timer->entry, &idletimer_tg_list);
- pr_debug("timer type value is %u", info->timer_type);
+ pr_debug("timer type value is %u", info->timer_type);
info->timer->timer_type = info->timer_type;
info->timer->refcnt = 1;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] netfilter: clean up some indenting
@ 2020-02-25 6:42 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-02-25 6:42 UTC (permalink / raw)
To: Pablo Neira Ayuso, Manoj Basapathi
Cc: Jozsef Kadlecsik, Florian Westphal, Jakub Kicinski,
netfilter-devel, coreteam, kernel-janitors
These lines were indented wrong so Smatch complained.
net/netfilter/xt_IDLETIMER.c:81 idletimer_tg_show() warn: inconsistent indenting
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
net/netfilter/xt_IDLETIMER.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/net/netfilter/xt_IDLETIMER.c b/net/netfilter/xt_IDLETIMER.c
index d620bbf13b30..75bd0e5dd312 100644
--- a/net/netfilter/xt_IDLETIMER.c
+++ b/net/netfilter/xt_IDLETIMER.c
@@ -77,9 +77,8 @@ static ssize_t idletimer_tg_show(struct device *dev,
ktimespec = ktime_to_timespec64(expires_alarm);
time_diff = ktimespec.tv_sec;
} else {
- expires = timer->timer.expires;
- time_diff = jiffies_to_msecs(
- expires - jiffies) / 1000;
+ expires = timer->timer.expires;
+ time_diff = jiffies_to_msecs(expires - jiffies) / 1000;
}
}
@@ -216,7 +215,7 @@ static int idletimer_tg_create_v1(struct idletimer_tg_info_v1 *info)
kobject_uevent(idletimer_tg_kobj,KOBJ_ADD);
list_add(&info->timer->entry, &idletimer_tg_list);
- pr_debug("timer type value is %u", info->timer_type);
+ pr_debug("timer type value is %u", info->timer_type);
info->timer->timer_type = info->timer_type;
info->timer->refcnt = 1;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter: clean up some indenting
2020-02-25 6:42 ` Dan Carpenter
@ 2020-03-02 12:24 ` Pablo Neira Ayuso
-1 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2020-03-02 12:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Manoj Basapathi, Jozsef Kadlecsik, Florian Westphal,
Jakub Kicinski, netfilter-devel, coreteam, kernel-janitors
On Tue, Feb 25, 2020 at 09:42:22AM +0300, Dan Carpenter wrote:
> These lines were indented wrong so Smatch complained.
> net/netfilter/xt_IDLETIMER.c:81 idletimer_tg_show() warn: inconsistent indenting
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] netfilter: clean up some indenting
@ 2020-03-02 12:24 ` Pablo Neira Ayuso
0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2020-03-02 12:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Manoj Basapathi, Jozsef Kadlecsik, Florian Westphal,
Jakub Kicinski, netfilter-devel, coreteam, kernel-janitors
On Tue, Feb 25, 2020 at 09:42:22AM +0300, Dan Carpenter wrote:
> These lines were indented wrong so Smatch complained.
> net/netfilter/xt_IDLETIMER.c:81 idletimer_tg_show() warn: inconsistent indenting
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-02 12:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-25 6:42 [PATCH] netfilter: clean up some indenting Dan Carpenter
2020-02-25 6:42 ` Dan Carpenter
2020-03-02 12:24 ` Pablo Neira Ayuso
2020-03-02 12:24 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.