* [LTP] [PATCH 1/1] nfs: Add fsid=PID to exportfs
@ 2020-03-02 15:58 Petr Vorel
2020-03-03 11:59 ` Alexey Kodanev
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2020-03-02 15:58 UTC (permalink / raw)
To: ltp
Following 0ccbcfc38 ("syscalls/statx07: add fsid= to exports"):
Not all filesystems are stored on devices, and not all filesystems
have UUIDs. tmpfs is one of them, which lead to test failing:
/tmp/XRzHSG/server requires fsid= for NFS export
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi Alexey,
simple fix, but better to check.
I'm working on more NFS related fixes.
Kind regards,
Petr
testcases/network/nfs/nfs_stress/nfs_lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
index e4a0c7e27..66f2fb038 100644
--- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
+++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
@@ -48,7 +48,7 @@ get_socket_type()
nfs_setup_server()
{
- local export_cmd="exportfs -i -o no_root_squash,rw *:$remote_dir"
+ local export_cmd="exportfs -i -o fsid=$$,no_root_squash,rw *:$remote_dir"
if [ -n "$LTP_NETNS" ]; then
if [ ! -d $remote_dir ]; then
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH 1/1] nfs: Add fsid=PID to exportfs
2020-03-03 11:59 ` Alexey Kodanev
@ 2020-03-03 11:52 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2020-03-03 11:52 UTC (permalink / raw)
To: ltp
Hi Alexey,
> Agree, thanks Petr!
Thanks for your ack, merged.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH 1/1] nfs: Add fsid=PID to exportfs
2020-03-02 15:58 [LTP] [PATCH 1/1] nfs: Add fsid=PID to exportfs Petr Vorel
@ 2020-03-03 11:59 ` Alexey Kodanev
2020-03-03 11:52 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Kodanev @ 2020-03-03 11:59 UTC (permalink / raw)
To: ltp
On 02.03.2020 18:58, Petr Vorel wrote:
> Following 0ccbcfc38 ("syscalls/statx07: add fsid= to exports"):
>
> Not all filesystems are stored on devices, and not all filesystems
> have UUIDs. tmpfs is one of them, which lead to test failing:
> /tmp/XRzHSG/server requires fsid= for NFS export
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi Alexey,
>
> simple fix, but better to check.
> I'm working on more NFS related fixes.
>
Agree, thanks Petr!
> Kind regards,
> Petr
>
> testcases/network/nfs/nfs_stress/nfs_lib.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/network/nfs/nfs_stress/nfs_lib.sh b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> index e4a0c7e27..66f2fb038 100644
> --- a/testcases/network/nfs/nfs_stress/nfs_lib.sh
> +++ b/testcases/network/nfs/nfs_stress/nfs_lib.sh
> @@ -48,7 +48,7 @@ get_socket_type()
>
> nfs_setup_server()
> {
> - local export_cmd="exportfs -i -o no_root_squash,rw *:$remote_dir"
> + local export_cmd="exportfs -i -o fsid=$$,no_root_squash,rw *:$remote_dir"
>
> if [ -n "$LTP_NETNS" ]; then
> if [ ! -d $remote_dir ]; then
>
Acked-by: Alexey Kodanev <alexey.kodanev@oracle.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-03 11:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-02 15:58 [LTP] [PATCH 1/1] nfs: Add fsid=PID to exportfs Petr Vorel
2020-03-03 11:59 ` Alexey Kodanev
2020-03-03 11:52 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.