All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gcc-cross-canadian: Enable wildcard expansion support
@ 2020-03-02 17:39 Mark Hatle
  2020-03-02 18:15 ` [yocto] " akuster
  2020-03-02 18:42 ` Khem Raj
  0 siblings, 2 replies; 9+ messages in thread
From: Mark Hatle @ 2020-03-02 17:39 UTC (permalink / raw)
  To: yocto, jpewhacker

In gcc 8, the behavior of GCC changed and expansion of wild cards to calls
of gcc were disabled by default.  This behavior may be required by some
(poorly written) makefiles.

This will allow someone to do:

gcc *.c -o myoutput

Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
---
 recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
index 9c0d828..e0463c6 100644
--- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
+++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
@@ -1,5 +1,5 @@
 INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
-EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
+EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
 LDFLAGS_append_sdkmingw32 = " -Wl,-static"
 EXEEXT_sdkmingw32 = ".exe"
 ELFUTILS_sdkmingw32 = ""
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [yocto] [PATCH] gcc-cross-canadian: Enable wildcard expansion support
  2020-03-02 17:39 [PATCH] gcc-cross-canadian: Enable wildcard expansion support Mark Hatle
@ 2020-03-02 18:15 ` akuster
  2020-03-02 18:22   ` Mark Hatle
  2020-03-02 18:42 ` Khem Raj
  1 sibling, 1 reply; 9+ messages in thread
From: akuster @ 2020-03-02 18:15 UTC (permalink / raw)
  To: Mark Hatle, yocto, jpewhacker

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]



On 3/2/20 9:39 AM, Mark Hatle wrote:
> In gcc 8, the behavior of GCC changed and expansion of wild cards to calls
> of gcc were disabled by default.  This behavior may be required by some
> (poorly written) makefiles.
>
> This will allow someone to do:
>
> gcc *.c -o myoutput

with backports to zeus & warrior?

-armin
>
> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
> ---
>  recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> index 9c0d828..e0463c6 100644
> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> @@ -1,5 +1,5 @@
>  INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
>  LDFLAGS_append_sdkmingw32 = " -Wl,-static"
>  EXEEXT_sdkmingw32 = ".exe"
>  ELFUTILS_sdkmingw32 = ""
>
> 


[-- Attachment #2: Type: text/html, Size: 1859 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [yocto] [PATCH] gcc-cross-canadian: Enable wildcard expansion support
  2020-03-02 18:15 ` [yocto] " akuster
@ 2020-03-02 18:22   ` Mark Hatle
  0 siblings, 0 replies; 9+ messages in thread
From: Mark Hatle @ 2020-03-02 18:22 UTC (permalink / raw)
  To: akuster808, yocto, jpewhacker

Ya, it backports to Zeus fine.  That is as far back as I've looked.

--Mark

On 3/2/20 12:15 PM, akuster808 wrote:
> 
> 
> On 3/2/20 9:39 AM, Mark Hatle wrote:
>> In gcc 8, the behavior of GCC changed and expansion of wild cards to calls
>> of gcc were disabled by default.  This behavior may be required by some
>> (poorly written) makefiles.
>>
>> This will allow someone to do:
>>
>> gcc *.c -o myoutput
> 
> with backports to zeus & warrior?
> 
> -armin
>> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
>> ---
>>  recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>> index 9c0d828..e0463c6 100644
>> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>> @@ -1,5 +1,5 @@
>>  INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
>> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
>> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
>>  LDFLAGS_append_sdkmingw32 = " -Wl,-static"
>>  EXEEXT_sdkmingw32 = ".exe"
>>  ELFUTILS_sdkmingw32 = ""
>>
>> 
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [yocto] [PATCH] gcc-cross-canadian: Enable wildcard expansion support
  2020-03-02 17:39 [PATCH] gcc-cross-canadian: Enable wildcard expansion support Mark Hatle
  2020-03-02 18:15 ` [yocto] " akuster
@ 2020-03-02 18:42 ` Khem Raj
  2020-03-02 22:27   ` Mark Hatle
  1 sibling, 1 reply; 9+ messages in thread
From: Khem Raj @ 2020-03-02 18:42 UTC (permalink / raw)
  To: yocto



On 3/2/20 9:39 AM, Mark Hatle wrote:
> In gcc 8, the behavior of GCC changed and expansion of wild cards to calls
> of gcc were disabled by default.  This behavior may be required by some
> (poorly written) makefiles.
> 
> This will allow someone to do:
> 
> gcc *.c -o myoutput
> 
> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
> ---
>   recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> index 9c0d828..e0463c6 100644
> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> @@ -1,5 +1,5 @@
>   INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"

this change is fine. is this the only place we need it ?

>   LDFLAGS_append_sdkmingw32 = " -Wl,-static"
>   EXEEXT_sdkmingw32 = ".exe"
>   ELFUTILS_sdkmingw32 = ""
> 
> 
> 
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [yocto] [PATCH] gcc-cross-canadian: Enable wildcard expansion support
  2020-03-02 18:42 ` Khem Raj
@ 2020-03-02 22:27   ` Mark Hatle
  2020-03-02 22:30     ` Denys Dmytriyenko
  0 siblings, 1 reply; 9+ messages in thread
From: Mark Hatle @ 2020-03-02 22:27 UTC (permalink / raw)
  To: Khem Raj, yocto



On 3/2/20 12:42 PM, Khem Raj wrote:
> 
> 
> On 3/2/20 9:39 AM, Mark Hatle wrote:
>> In gcc 8, the behavior of GCC changed and expansion of wild cards to calls
>> of gcc were disabled by default.  This behavior may be required by some
>> (poorly written) makefiles.
>>
>> This will allow someone to do:
>>
>> gcc *.c -o myoutput
>>
>> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
>> ---
>>   recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>> index 9c0d828..e0463c6 100644
>> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>> @@ -1,5 +1,5 @@
>>   INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
>> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
>> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
> 
> this change is fine. is this the only place we need it ?

Yes, it doesn't do anything if the generated toolchain isn't mingw.. and AFAIK,
we're only build cross-canadian there.

(binutils and others don't appear to have this option, unless I just missed it.)

--Mark

>>   LDFLAGS_append_sdkmingw32 = " -Wl,-static"
>>   EXEEXT_sdkmingw32 = ".exe"
>>   ELFUTILS_sdkmingw32 = ""
>>
>>
>>
>>
>>
>> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [yocto] [PATCH] gcc-cross-canadian: Enable wildcard expansion support
  2020-03-02 22:27   ` Mark Hatle
@ 2020-03-02 22:30     ` Denys Dmytriyenko
  2020-03-02 23:03       ` Khem Raj
  0 siblings, 1 reply; 9+ messages in thread
From: Denys Dmytriyenko @ 2020-03-02 22:30 UTC (permalink / raw)
  To: Mark Hatle; +Cc: Khem Raj, yocto

On Mon, Mar 02, 2020 at 04:27:05PM -0600, Mark Hatle wrote:
> 
> 
> On 3/2/20 12:42 PM, Khem Raj wrote:
> > 
> > 
> > On 3/2/20 9:39 AM, Mark Hatle wrote:
> >> In gcc 8, the behavior of GCC changed and expansion of wild cards to calls
> >> of gcc were disabled by default.  This behavior may be required by some
> >> (poorly written) makefiles.
> >>
> >> This will allow someone to do:
> >>
> >> gcc *.c -o myoutput
> >>
> >> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
> >> ---
> >>   recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> >> index 9c0d828..e0463c6 100644
> >> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> >> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> >> @@ -1,5 +1,5 @@
> >>   INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
> >> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
> >> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
> > 
> > this change is fine. is this the only place we need it ?
> 
> Yes, it doesn't do anything if the generated toolchain isn't mingw.. and AFAIK,

Where does this bbappend go? Should this patch be designated to mingw layer?


> we're only build cross-canadian there.
> 
> (binutils and others don't appear to have this option, unless I just missed it.)
> 
> --Mark
> 
> >>   LDFLAGS_append_sdkmingw32 = " -Wl,-static"
> >>   EXEEXT_sdkmingw32 = ".exe"
> >>   ELFUTILS_sdkmingw32 = ""
> >>
> >>
> >>
> >>
> >>
> >> 

> 


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [yocto] [PATCH] gcc-cross-canadian: Enable wildcard expansion support
  2020-03-02 22:30     ` Denys Dmytriyenko
@ 2020-03-02 23:03       ` Khem Raj
  2020-03-02 23:38         ` Joshua Watt
  0 siblings, 1 reply; 9+ messages in thread
From: Khem Raj @ 2020-03-02 23:03 UTC (permalink / raw)
  To: Denys Dmytriyenko, Mark Hatle; +Cc: yocto



On 3/2/20 2:30 PM, Denys Dmytriyenko wrote:
> On Mon, Mar 02, 2020 at 04:27:05PM -0600, Mark Hatle wrote:
>>
>>
>> On 3/2/20 12:42 PM, Khem Raj wrote:
>>>
>>>
>>> On 3/2/20 9:39 AM, Mark Hatle wrote:
>>>> In gcc 8, the behavior of GCC changed and expansion of wild cards to calls
>>>> of gcc were disabled by default.  This behavior may be required by some
>>>> (poorly written) makefiles.
>>>>
>>>> This will allow someone to do:
>>>>
>>>> gcc *.c -o myoutput
>>>>
>>>> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
>>>> ---
>>>>    recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>>>> index 9c0d828..e0463c6 100644
>>>> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>>>> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>>>> @@ -1,5 +1,5 @@
>>>>    INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
>>>> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
>>>> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls --enable-mingw-wildcard"
>>>
>>> this change is fine. is this the only place we need it ?
>>
>> Yes, it doesn't do anything if the generated toolchain isn't mingw.. and AFAIK,
> 
> Where does this bbappend go? Should this patch be designated to mingw layer?
> 

its using an override, so it wont be effective elsewhere, perhaps 
oe-core is better place for it.

> 
>> we're only build cross-canadian there.
>>
>> (binutils and others don't appear to have this option, unless I just missed it.)
>>
>> --Mark
>>
>>>>    LDFLAGS_append_sdkmingw32 = " -Wl,-static"
>>>>    EXEEXT_sdkmingw32 = ".exe"
>>>>    ELFUTILS_sdkmingw32 = ""
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
> 
>> 
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [yocto] [PATCH] gcc-cross-canadian: Enable wildcard expansion support
  2020-03-02 23:03       ` Khem Raj
@ 2020-03-02 23:38         ` Joshua Watt
  2020-03-02 23:56           ` Khem Raj
  0 siblings, 1 reply; 9+ messages in thread
From: Joshua Watt @ 2020-03-02 23:38 UTC (permalink / raw)
  To: Khem Raj; +Cc: Denys Dmytriyenko, Mark Hatle, yocto

[-- Attachment #1: Type: text/plain, Size: 2141 bytes --]

On Mon, Mar 2, 2020, 5:03 PM Khem Raj <raj.khem@gmail.com> wrote:

>
>
> On 3/2/20 2:30 PM, Denys Dmytriyenko wrote:
> > On Mon, Mar 02, 2020 at 04:27:05PM -0600, Mark Hatle wrote:
> >>
> >>
> >> On 3/2/20 12:42 PM, Khem Raj wrote:
> >>>
> >>>
> >>> On 3/2/20 9:39 AM, Mark Hatle wrote:
> >>>> In gcc 8, the behavior of GCC changed and expansion of wild cards to
> calls
> >>>> of gcc were disabled by default.  This behavior may be required by
> some
> >>>> (poorly written) makefiles.
> >>>>
> >>>> This will allow someone to do:
> >>>>
> >>>> gcc *.c -o myoutput
> >>>>
> >>>> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
> >>>> ---
> >>>>    recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
> >>>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> >>>> index 9c0d828..e0463c6 100644
> >>>> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> >>>> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
> >>>> @@ -1,5 +1,5 @@
> >>>>    INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
> >>>> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
> >>>> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls
> --enable-mingw-wildcard"
> >>>
> >>> this change is fine. is this the only place we need it ?
> >>
> >> Yes, it doesn't do anything if the generated toolchain isn't mingw..
> and AFAIK,
> >
> > Where does this bbappend go? Should this patch be designated to mingw
> layer?
> >
>
> its using an override, so it wont be effective elsewhere, perhaps
> oe-core is better place for it.
>

Heh, I already applied it to master-next in meta-mingw :)


> >
> >> we're only build cross-canadian there.
> >>
> >> (binutils and others don't appear to have this option, unless I just
> missed it.)
> >>
> >> --Mark
> >>
> >>>>    LDFLAGS_append_sdkmingw32 = " -Wl,-static"
> >>>>    EXEEXT_sdkmingw32 = ".exe"
> >>>>    ELFUTILS_sdkmingw32 = ""
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >
> >>
> >
> 
>

[-- Attachment #2: Type: text/html, Size: 3439 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [yocto] [PATCH] gcc-cross-canadian: Enable wildcard expansion support
  2020-03-02 23:38         ` Joshua Watt
@ 2020-03-02 23:56           ` Khem Raj
  0 siblings, 0 replies; 9+ messages in thread
From: Khem Raj @ 2020-03-02 23:56 UTC (permalink / raw)
  To: Joshua Watt; +Cc: Denys Dmytriyenko, Mark Hatle, yocto



On 3/2/20 3:38 PM, Joshua Watt wrote:
> 
> 
> On Mon, Mar 2, 2020, 5:03 PM Khem Raj <raj.khem@gmail.com 
> <mailto:raj.khem@gmail.com>> wrote:
> 
> 
> 
>     On 3/2/20 2:30 PM, Denys Dmytriyenko wrote:
>      > On Mon, Mar 02, 2020 at 04:27:05PM -0600, Mark Hatle wrote:
>      >>
>      >>
>      >> On 3/2/20 12:42 PM, Khem Raj wrote:
>      >>>
>      >>>
>      >>> On 3/2/20 9:39 AM, Mark Hatle wrote:
>      >>>> In gcc 8, the behavior of GCC changed and expansion of wild
>     cards to calls
>      >>>> of gcc were disabled by default.  This behavior may be
>     required by some
>      >>>> (poorly written) makefiles.
>      >>>>
>      >>>> This will allow someone to do:
>      >>>>
>      >>>> gcc *.c -o myoutput
>      >>>>
>      >>>> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org
>     <mailto:mark.hatle@kernel.crashing.org>>
>      >>>> ---
>      >>>>    recipes-devtools/gcc/gcc-cross-canadian_%.bbappend | 2 +-
>      >>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>      >>>>
>      >>>> diff --git
>     a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>     b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>      >>>> index 9c0d828..e0463c6 100644
>      >>>> --- a/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>      >>>> +++ b/recipes-devtools/gcc/gcc-cross-canadian_%.bbappend
>      >>>> @@ -1,5 +1,5 @@
>      >>>>    INSANE_SKIP_${PN}_append_sdkmingw32 = " staticdev"
>      >>>> -EXTRA_OECONF_append_sdkmingw32 = " --disable-nls"
>      >>>> +EXTRA_OECONF_append_sdkmingw32 = " --disable-nls
>     --enable-mingw-wildcard"
>      >>>
>      >>> this change is fine. is this the only place we need it ?
>      >>
>      >> Yes, it doesn't do anything if the generated toolchain isn't
>     mingw.. and AFAIK,
>      >
>      > Where does this bbappend go? Should this patch be designated to
>     mingw layer?
>      >
> 
>     its using an override, so it wont be effective elsewhere, perhaps
>     oe-core is better place for it.
> 
> 
> Heh, I already applied it to master-next in meta-mingw :)

thats fine.

> 
> 
>      >
>      >> we're only build cross-canadian there.
>      >>
>      >> (binutils and others don't appear to have this option, unless I
>     just missed it.)
>      >>
>      >> --Mark
>      >>
>      >>>>    LDFLAGS_append_sdkmingw32 = " -Wl,-static"
>      >>>>    EXEEXT_sdkmingw32 = ".exe"
>      >>>>    ELFUTILS_sdkmingw32 = ""
>      >>>>
>      >>>>
>      >>>>
>      >>>>
>      >>>>
>      >>>>
>      >
>      >>
>      >
>     
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-03-02 23:56 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-02 17:39 [PATCH] gcc-cross-canadian: Enable wildcard expansion support Mark Hatle
2020-03-02 18:15 ` [yocto] " akuster
2020-03-02 18:22   ` Mark Hatle
2020-03-02 18:42 ` Khem Raj
2020-03-02 22:27   ` Mark Hatle
2020-03-02 22:30     ` Denys Dmytriyenko
2020-03-02 23:03       ` Khem Raj
2020-03-02 23:38         ` Joshua Watt
2020-03-02 23:56           ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.