* [Buildroot] [PATCH 1/1] linux-tools: perf: Add dependencies for binutils and openssl
@ 2020-03-02 22:49 Robert Hancock
2020-03-19 17:28 ` Yann E. MORIN
2020-03-27 22:33 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Robert Hancock @ 2020-03-02 22:49 UTC (permalink / raw)
To: buildroot
perf auto-detects and uses the libbfd (from binutils) and openssl
libraries if they are detected and happen to be built before perf is,
but if they're not, or if per-package directories are enabled, it won't
detect these libraries. Explicitly add dependencies on these packages if
they are enabled, and disable the feature if not, so that the behavior
is deterministic.
Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
---
package/linux-tools/linux-tool-perf.mk.in | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/package/linux-tools/linux-tool-perf.mk.in b/package/linux-tools/linux-tool-perf.mk.in
index 80e00c3c56..7106b622cb 100644
--- a/package/linux-tools/linux-tool-perf.mk.in
+++ b/package/linux-tools/linux-tool-perf.mk.in
@@ -82,6 +82,18 @@ else
PERF_MAKE_FLAGS += NO_LIBELF=1 NO_DWARF=1
endif
+ifeq ($(BR2_PACKAGE_BINUTILS),y)
+PERF_DEPENDENCIES += binutils
+else
+PERF_MAKE_FLAGS += NO_DEMANGLE=1
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+PERF_DEPENDENCIES += openssl
+else
+PERF_MAKE_FLAGS += NO_LIBCRYPTO=1
+endif
+
ifeq ($(BR2_PACKAGE_ZLIB),y)
PERF_DEPENDENCIES += zlib
else
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] linux-tools: perf: Add dependencies for binutils and openssl
2020-03-02 22:49 [Buildroot] [PATCH 1/1] linux-tools: perf: Add dependencies for binutils and openssl Robert Hancock
@ 2020-03-19 17:28 ` Yann E. MORIN
2020-03-27 22:33 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2020-03-19 17:28 UTC (permalink / raw)
To: buildroot
Robert, All,
On 2020-03-02 16:49 -0600, Robert Hancock spake thusly:
> perf auto-detects and uses the libbfd (from binutils) and openssl
> libraries if they are detected and happen to be built before perf is,
> but if they're not, or if per-package directories are enabled, it won't
> detect these libraries. Explicitly add dependencies on these packages if
> they are enabled, and disable the feature if not, so that the behavior
> is deterministic.
>
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/linux-tools/linux-tool-perf.mk.in | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/package/linux-tools/linux-tool-perf.mk.in b/package/linux-tools/linux-tool-perf.mk.in
> index 80e00c3c56..7106b622cb 100644
> --- a/package/linux-tools/linux-tool-perf.mk.in
> +++ b/package/linux-tools/linux-tool-perf.mk.in
> @@ -82,6 +82,18 @@ else
> PERF_MAKE_FLAGS += NO_LIBELF=1 NO_DWARF=1
> endif
>
> +ifeq ($(BR2_PACKAGE_BINUTILS),y)
> +PERF_DEPENDENCIES += binutils
> +else
> +PERF_MAKE_FLAGS += NO_DEMANGLE=1
> +endif
> +
> +ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +PERF_DEPENDENCIES += openssl
> +else
> +PERF_MAKE_FLAGS += NO_LIBCRYPTO=1
> +endif
> +
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> PERF_DEPENDENCIES += zlib
> else
> --
> 2.24.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] linux-tools: perf: Add dependencies for binutils and openssl
2020-03-02 22:49 [Buildroot] [PATCH 1/1] linux-tools: perf: Add dependencies for binutils and openssl Robert Hancock
2020-03-19 17:28 ` Yann E. MORIN
@ 2020-03-27 22:33 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2020-03-27 22:33 UTC (permalink / raw)
To: buildroot
>>>>> "Robert" == Robert Hancock <hancock@sedsystems.ca> writes:
> perf auto-detects and uses the libbfd (from binutils) and openssl
> libraries if they are detected and happen to be built before perf is,
> but if they're not, or if per-package directories are enabled, it won't
> detect these libraries. Explicitly add dependencies on these packages if
> they are enabled, and disable the feature if not, so that the behavior
> is deterministic.
> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
Committed to 2019.02.x, 2019.11.x and 2020.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-27 22:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-02 22:49 [Buildroot] [PATCH 1/1] linux-tools: perf: Add dependencies for binutils and openssl Robert Hancock
2020-03-19 17:28 ` Yann E. MORIN
2020-03-27 22:33 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.