From: Mark Brown <broonie@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Jerome Brunet <jbrunet@baylibre.com>,
Ondrej Jirman <megous@megous.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 3/3] ASoC: simple-card: Add support for codec2codec DAI links
Date: Tue, 3 Mar 2020 13:51:50 +0000 [thread overview]
Message-ID: <20200303135150.GH3866@sirena.org.uk> (raw)
In-Reply-To: <9cdcfcb6-63c2-5b76-9de1-46719e4e7139@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Tue, Mar 03, 2020 at 07:49:33AM -0600, Samuel Holland wrote:
> On 2/22/20 9:45 PM, Samuel Holland wrote:
> > +{
> > + struct snd_soc_dai_link *dai_link = rtd->dai_link;
> > + struct snd_soc_component *component;
> > + struct snd_soc_rtdcom_list *rtdcom;
> This variable is unused in v3. I can send a v4.
Please.
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Ondrej Jirman <megous@megous.com>,
alsa-devel@alsa-project.org, Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v3 3/3] ASoC: simple-card: Add support for codec2codec DAI links
Date: Tue, 3 Mar 2020 13:51:50 +0000 [thread overview]
Message-ID: <20200303135150.GH3866@sirena.org.uk> (raw)
In-Reply-To: <9cdcfcb6-63c2-5b76-9de1-46719e4e7139@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Tue, Mar 03, 2020 at 07:49:33AM -0600, Samuel Holland wrote:
> On 2/22/20 9:45 PM, Samuel Holland wrote:
> > +{
> > + struct snd_soc_dai_link *dai_link = rtd->dai_link;
> > + struct snd_soc_component *component;
> > + struct snd_soc_rtdcom_list *rtdcom;
> This variable is unused in v3. I can send a v4.
Please.
Please delete unneeded context from mails when replying. Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-03-03 13:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-23 3:45 [PATCH v3 0/3] simple-audio-card codec2codec support Samuel Holland
2020-02-23 3:45 ` Samuel Holland
2020-02-23 3:45 ` [PATCH v3 1/3] ALSA: pcm: Add a standalone version of snd_pcm_limit_hw_rates Samuel Holland
2020-02-23 3:45 ` Samuel Holland
2020-03-03 13:21 ` Mark Brown
2020-03-03 13:21 ` Mark Brown
2020-02-23 3:45 ` [PATCH v3 2/3] ASoC: pcm: Export parameter intersection logic Samuel Holland
2020-02-23 3:45 ` Samuel Holland
2020-02-23 3:45 ` [PATCH v3 3/3] ASoC: simple-card: Add support for codec2codec DAI links Samuel Holland
2020-02-23 3:45 ` Samuel Holland
2020-03-03 13:49 ` Samuel Holland
2020-03-03 13:51 ` Mark Brown [this message]
2020-03-03 13:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303135150.GH3866@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=corbet@lwn.net \
--cc=jbrunet@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=megous@megous.com \
--cc=perex@perex.cz \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.