All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Aleksandar Markovic" <aleksandar.markovic@rt-rk.com>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [EXTERNAL]Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer
Date: Tue, 3 Mar 2020 09:29:50 -0500	[thread overview]
Message-ID: <20200303142950.GA24302@localhost.localdomain> (raw)
In-Reply-To: <CAP+75-WyFM7jKmBxiti5PMSJskmztQ7RLrTK72aW9LiLAWh+cw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]

On Tue, Mar 03, 2020 at 01:55:35PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Cleber,
>

Hi Phil!

>  On Tue, Mar 3, 2020 at 12:40 AM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
> > On 3/2/20 9:58 PM, Aleksandar Markovic wrote:
> > >> From: Peter Maydell <peter.maydell@linaro.org>
> > >> Sent: Monday, March 2, 2020 9:26 PM
> > >> To: Aleksandar Markovic
> > >> Cc: QEMU Developers; Aleksandar Markovic; Philippe Mathieu-Daudé
> > >> Subject: [EXTERNAL]Re: [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer
> > >>
> > >> On Thu, 27 Feb 2020 at 13:28, Aleksandar Markovic
> > >> <aleksandar.markovic@rt-rk.com> wrote:
> > >>>
> > >>> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > >>>
> > >>> Add a test that verifies that each core properly displays the Tux
> > >>> logo on the framebuffer device.
> > >>>
> > >>> We simply follow the OpenCV "Template Matching with Multiple Objects"
> > >>> tutorial, replacing Lionel Messi by Tux:
> > >>> https://docs.opencv.org/4.2.0/d4/dc6/tutorial_py_template_matching.html
> > >>
> > >> Hi -- this doesn't seem to work on my system:
> > >>
> > >
> > > Thank you for bringing this to our attention.
> > >
> > > It looks like an honest mistake to me. Too bad
> > > none of us tested the case of environment like
> > > yours, even though it looked reasonable to test it.
> >
> > I'm sorry I missed that, I'm pretty sure I tested it as we noticed this
> > "bug" in Avocado more than 1 year ago already (bug = class decorator not
> > working).
> 
> I see in commit 2fe6f4d9ba you moved the @skip decorators to the setUp() method.
> Is this a kind of kludge to not use it on all the test_*() methods?
> (since we can not use it on an AvocadoTest class)
>

Yes, that was a workaround for a previous Avocado limitation.  As I said
on another thread, on Avocado >= 76.0 it's possible to just decorate the
entire class.

- Cleber.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-03-03 14:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 13:27 [PULL 0/5] MIPS queue for February 27th, 2020 Aleksandar Markovic
2020-02-27 13:27 ` [PULL 1/5] MAINTAINERS: Orphan MIPS KVM CPUs Aleksandar Markovic
2020-02-27 13:27 ` [PULL 2/5] MAINTAINERS: Reactivate " Aleksandar Markovic
2020-02-27 13:27 ` [PULL 3/5] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu() Aleksandar Markovic
2020-02-27 13:27 ` [PULL 4/5] hw/mips: Use memory_region_init_rom() with read-only regions Aleksandar Markovic
2020-02-27 13:27 ` [PULL 5/5] tests/acceptance: Count multiple Tux logos displayed on framebuffer Aleksandar Markovic
2020-03-02 20:26   ` Peter Maydell
2020-03-02 20:58     ` [EXTERNAL]Re: " Aleksandar Markovic
2020-03-02 21:20       ` Aleksandar Markovic
2020-03-02 23:40       ` Philippe Mathieu-Daudé
2020-03-03 12:55         ` Philippe Mathieu-Daudé
2020-03-03 14:29           ` Cleber Rosa [this message]
2020-02-28 14:02 ` [PULL 0/5] MIPS queue for February 27th, 2020 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303142950.GA24302@localhost.localdomain \
    --to=crosa@redhat.com \
    --cc=aleksandar.markovic@rt-rk.com \
    --cc=alex.bennee@linaro.org \
    --cc=amarkovic@wavecomp.com \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.