Re: [RFC 2/8] dt-bindings: video: Add jz4780-hdmi binding

[Rob Herring <robh@kernel.org>]

On Wed, Feb 26, 2020 at 08:12:54PM +0100, H. Nikolaus Schaller wrote:
> From: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> 
> Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC.
> 
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>
> ---
>  .../bindings/display/ingenic-jz4780-hdmi.txt  | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.txt b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.txt
> new file mode 100644
> index 000000000000..f02e59fbdd5a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.txt
> @@ -0,0 +1,41 @@
> +Device-Tree bindings for Ingenic JZ4780 HDMI Transmitter
> +
> +The HDMI Transmitter in the Ingenic JZ4780 is a Synopsys DesignWare HDMI 1.4
> +TX controller IP with accompanying PHY IP.
> +
> +Required properties:
> + - #address-cells : should be <1>
> + - #size-cells : should be <0>

These aren't in the example.

> + - compatible : should be "ingenic,jz4780-hdmi"
> + - reg-io-width: must be <4>

If it can only be 4, then you can just assume that from the compatible.

> + - clocks: phandle to isrf and iahb clocks
> + - clock-names : must be "isrf" and "iahb"
> + - ports: Port nodes with endpoint definitions as defined in
> +   Documentation/devicetree/bindings/media/video-interfaces.txt,
> +
> +Optional properties:
> + - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing

This goes in a connector node. It's not part of the HDMI block.

That also means you need an out port to the connector.

> +
> +example:
> +
> +hdmi: hdmi@10180000 {
> +	compatible = "ingenic,jz4780-hdmi";
> +	reg = <0x10180000 0x8000>;
> +	reg-io-width = <4>;
> +	ddc-i2c-bus = <&i2c4>;
> +	interrupt-parent = <&intc>;
> +	interrupts = <3>;
> +	clocks = <&cgu JZ4780_CLK_HDMI>, <&cgu JZ4780_CLK_AHB0>;
> +	clock-names = "isfr", "iahb";
> +
> +	ports {
> +		hdmi_in: port {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			hdmi_in_lcd: endpoint@0 {
> +				reg = <0>;
> +				remote-endpoint = <&jz4780_out_hdmi>;
> +			};
> +		};
> +	};
> +};
> -- 
> 2.23.0
>