* [Buildroot] [PATCH 1/1] package/nodejs: bump version to v12.16.1
@ 2020-03-03 19:11 aduskett at gmail.com
2020-03-03 21:43 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: aduskett at gmail.com @ 2020-03-03 19:11 UTC (permalink / raw)
To: buildroot
From: Adam Duskett <Aduskett@gmail.com>
Tested on Debian 9 and Ubuntu 18.04
Fixes:
http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5
Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
package/nodejs/nodejs.hash | 4 ++--
package/nodejs/nodejs.mk | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
index 8a56c04713..992040d391 100644
--- a/package/nodejs/nodejs.hash
+++ b/package/nodejs/nodejs.hash
@@ -1,5 +1,5 @@
-# From https://nodejs.org/dist/v12.16.0/SHASUMS256.txt
-sha256 b8c90637473fce4444a0b4fdae2c1560a1cf9f5959fdf9670541fc52868cf925 node-v12.16.0.tar.xz
+# From https://nodejs.org/dist/v12.16.1/SHASUMS256.txt
+sha256 0a95845ba02c46102b5671d0c5732460073f2d397488337e18d1fc30146d412d node-v12.16.1.tar.xz
# Hash for license file
sha256 3f5749f7a58edaadd77843057a90063a18067f472d8b26c0a76905cafa1063e3 LICENSE
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 0de3495df9..7f875058b3 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -4,7 +4,7 @@
#
################################################################################
-NODEJS_VERSION = 12.16.0
+NODEJS_VERSION = 12.16.1
NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.xz
NODEJS_SITE = http://nodejs.org/dist/v$(NODEJS_VERSION)
NODEJS_DEPENDENCIES = host-python host-nodejs c-ares \
--
2.21.1 (Apple Git-122.3)
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/nodejs: bump version to v12.16.1
2020-03-03 19:11 [Buildroot] [PATCH 1/1] package/nodejs: bump version to v12.16.1 aduskett at gmail.com
@ 2020-03-03 21:43 ` Thomas Petazzoni
2020-03-03 22:31 ` Peter Korsgaard
2020-03-05 17:07 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2020-03-03 21:43 UTC (permalink / raw)
To: buildroot
Hello Adam,
On Tue, 3 Mar 2020 11:11:33 -0800
aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Tested on Debian 9 and Ubuntu 18.04
>
> Fixes:
> http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
> http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5
Are you positive that this bump fixes the ICU issues? I.e did you
reproduce the ICU issues before this version bump, and confirm they
disappeared solely because of the version bump?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/nodejs: bump version to v12.16.1
2020-03-03 21:43 ` Thomas Petazzoni
@ 2020-03-03 22:31 ` Peter Korsgaard
2020-03-04 8:06 ` Thomas Petazzoni
2020-03-05 17:07 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2020-03-03 22:31 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello Adam,
> On Tue, 3 Mar 2020 11:11:33 -0800
> aduskett at gmail.com wrote:
>> From: Adam Duskett <Aduskett@gmail.com>
>>
>> Tested on Debian 9 and Ubuntu 18.04
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
>> http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5
> Are you positive that this bump fixes the ICU issues? I.e did you
> reproduce the ICU issues before this version bump, and confirm they
> disappeared solely because of the version bump?
It sounds unlikely, given the very few commits between 12.16.0 and
12.16.1, and nothing mentioned in the changelog about icu:
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#12.16.1
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/nodejs: bump version to v12.16.1
2020-03-03 22:31 ` Peter Korsgaard
@ 2020-03-04 8:06 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2020-03-04 8:06 UTC (permalink / raw)
To: buildroot
On Tue, 03 Mar 2020 23:31:55 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:
> >> Fixes:
> >> http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
> >> http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5
>
> > Are you positive that this bump fixes the ICU issues? I.e did you
> > reproduce the ICU issues before this version bump, and confirm they
> > disappeared solely because of the version bump?
>
> It sounds unlikely, given the very few commits between 12.16.0 and
> 12.16.1, and nothing mentioned in the changelog about icu:
>
> https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#12.16.1
Right, so I'm quite doubtful about the "Fixes" tag. I suppose Adam did
not reproduce the issue after the bump, but also did not have the issue
before the bump.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/nodejs: bump version to v12.16.1
2020-03-03 21:43 ` Thomas Petazzoni
2020-03-03 22:31 ` Peter Korsgaard
@ 2020-03-05 17:07 ` Peter Korsgaard
2020-03-13 16:19 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2020-03-05 17:07 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello Adam,
> On Tue, 3 Mar 2020 11:11:33 -0800
> aduskett at gmail.com wrote:
>> From: Adam Duskett <Aduskett@gmail.com>
>>
>> Tested on Debian 9 and Ubuntu 18.04
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
>> http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5
> Are you positive that this bump fixes the ICU issues? I.e did you
> reproduce the ICU issues before this version bump, and confirm they
> disappeared solely because of the version bump?
Committed to master after dropping the fixes as discussed on IRC and
extending the commit message info about the regressions fixed in
12.16.1, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/nodejs: bump version to v12.16.1
2020-03-05 17:07 ` Peter Korsgaard
@ 2020-03-13 16:19 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-03-13 16:19 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
>> Hello Adam,
>> On Tue, 3 Mar 2020 11:11:33 -0800
>> aduskett at gmail.com wrote:
>>> From: Adam Duskett <Aduskett@gmail.com>
>>>
>>> Tested on Debian 9 and Ubuntu 18.04
>>>
>>> Fixes:
>>> http://autobuild.buildroot.net/results/9d3545a76c4f5c06debf319687498d662a53fafb
>>> http://autobuild.buildroot.net/results/4da6c695b8ceca0a6eee2481a1b873a46676d0f5
>> Are you positive that this bump fixes the ICU issues? I.e did you
>> reproduce the ICU issues before this version bump, and confirm they
>> disappeared solely because of the version bump?
> Committed to master after dropping the fixes as discussed on IRC and
> extending the commit message info about the regressions fixed in
> 12.16.1, thanks.
Committed to 2019.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-13 16:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-03 19:11 [Buildroot] [PATCH 1/1] package/nodejs: bump version to v12.16.1 aduskett at gmail.com
2020-03-03 21:43 ` Thomas Petazzoni
2020-03-03 22:31 ` Peter Korsgaard
2020-03-04 8:06 ` Thomas Petazzoni
2020-03-05 17:07 ` Peter Korsgaard
2020-03-13 16:19 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.