All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	keyrings@vger.kernel.org
Subject: Re: [PATCH v6 4/6] security: keys: trusted: use ASN.1 TPM2 key format for the blobs
Date: Tue, 03 Mar 2020 21:20:53 +0000	[thread overview]
Message-ID: <20200303212053.GB110353@linux.intel.com> (raw)
In-Reply-To: <1583268141.3638.10.camel@HansenPartnership.com>

On Tue, Mar 03, 2020 at 03:42:21PM -0500, James Bottomley wrote:
> On Tue, 2020-03-03 at 22:06 +0200, Jarkko Sakkinen wrote:
> > On Mon, Mar 02, 2020 at 07:27:57AM -0500, James Bottomley wrote:
> > > Modify the TPM2 key format blob output to export and import in the
> > > ASN.1 form for TPM2 sealed object keys.  For compatibility with
> > > prior
> > > trusted keys, the importer will also accept two TPM2B quantities
> > > representing the public and private parts of the key.  However, the
> > > export via keyctl pipe will only output the ASN.1 format.
> > > 
> > > The benefit of the ASN.1 format is that it's a standard and thus
> > > the
> > > exported key can be used by userspace tools (openssl_tpm2_engine,
> > > openconnect and tpm2-tss-engine).  The format includes policy
> > > specifications, thus it gets us out of having to construct policy
> > > handles in userspace and the format includes the parent meaning you
> > > don't have to keep passing it in each time.
> > > 
> > > This patch only implements basic handling for the ASN.1 format, so
> > > keys with passwords but no policy.
> > > 
> > > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.c
> > > om>
> > 
> > tpm_key (like you have tpm2_key prefix).
> 
> OK, I should probably do tpm2_key as the prefix since TPM 1.2 cannot do
>  policy, that's a TPM 2 only thing.

Agreed that would be even better.

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	keyrings@vger.kernel.org
Subject: Re: [PATCH v6 4/6] security: keys: trusted: use ASN.1 TPM2 key format for the blobs
Date: Tue, 3 Mar 2020 23:20:53 +0200	[thread overview]
Message-ID: <20200303212053.GB110353@linux.intel.com> (raw)
In-Reply-To: <1583268141.3638.10.camel@HansenPartnership.com>

On Tue, Mar 03, 2020 at 03:42:21PM -0500, James Bottomley wrote:
> On Tue, 2020-03-03 at 22:06 +0200, Jarkko Sakkinen wrote:
> > On Mon, Mar 02, 2020 at 07:27:57AM -0500, James Bottomley wrote:
> > > Modify the TPM2 key format blob output to export and import in the
> > > ASN.1 form for TPM2 sealed object keys.  For compatibility with
> > > prior
> > > trusted keys, the importer will also accept two TPM2B quantities
> > > representing the public and private parts of the key.  However, the
> > > export via keyctl pipe will only output the ASN.1 format.
> > > 
> > > The benefit of the ASN.1 format is that it's a standard and thus
> > > the
> > > exported key can be used by userspace tools (openssl_tpm2_engine,
> > > openconnect and tpm2-tss-engine).  The format includes policy
> > > specifications, thus it gets us out of having to construct policy
> > > handles in userspace and the format includes the parent meaning you
> > > don't have to keep passing it in each time.
> > > 
> > > This patch only implements basic handling for the ASN.1 format, so
> > > keys with passwords but no policy.
> > > 
> > > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.c
> > > om>
> > 
> > tpm_key (like you have tpm2_key prefix).
> 
> OK, I should probably do tpm2_key as the prefix since TPM 1.2 cannot do
>  policy, that's a TPM 2 only thing.

Agreed that would be even better.

/Jarkko

  reply	other threads:[~2020-03-03 21:20 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 12:27 [PATCH v6 0/6] TPM 2.0 trusted keys with attached policy James Bottomley
2020-03-02 12:27 ` James Bottomley
2020-03-02 12:27 ` [PATCH v6 1/6] lib: add ASN.1 encoder James Bottomley
2020-03-02 12:27   ` James Bottomley
2020-03-03 19:22   ` Jarkko Sakkinen
2020-03-03 19:22     ` Jarkko Sakkinen
2020-03-03 20:49     ` James Bottomley
2020-03-03 20:49       ` James Bottomley
2020-03-03 21:31       ` Jarkko Sakkinen
2020-03-03 21:31         ` Jarkko Sakkinen
2020-03-02 12:27 ` [PATCH v6 2/6] oid_registry: Add TCG defined OIDS for TPM keys James Bottomley
2020-03-02 12:27   ` James Bottomley
2020-03-03 19:24   ` Jarkko Sakkinen
2020-03-03 19:24     ` Jarkko Sakkinen
2020-03-02 12:27 ` [PATCH v6 3/6] security: keys: trusted: fix TPM2 authorizations James Bottomley
2020-03-02 12:27   ` James Bottomley
2020-03-03 19:33   ` Jarkko Sakkinen
2020-03-03 19:33     ` Jarkko Sakkinen
2020-03-03 20:39     ` James Bottomley
2020-03-03 20:39       ` James Bottomley
2020-03-03 21:32       ` Jarkko Sakkinen
2020-03-03 21:32         ` Jarkko Sakkinen
2020-03-02 12:27 ` [PATCH v6 4/6] security: keys: trusted: use ASN.1 TPM2 key format for the blobs James Bottomley
2020-03-02 12:27   ` James Bottomley
2020-03-03 20:06   ` Jarkko Sakkinen
2020-03-03 20:06     ` Jarkko Sakkinen
2020-03-03 20:42     ` James Bottomley
2020-03-03 20:42       ` James Bottomley
2020-03-03 21:20       ` Jarkko Sakkinen [this message]
2020-03-03 21:20         ` Jarkko Sakkinen
2020-03-02 12:27 ` [PATCH v6 5/6] security: keys: trusted: add ability to specify arbitrary policy James Bottomley
2020-03-02 12:27   ` James Bottomley
2020-03-02 12:27 ` [PATCH v6 6/6] security: keys: trusted: implement counter/timer policy James Bottomley
2020-03-02 12:27   ` James Bottomley
2020-03-03 20:08   ` Jarkko Sakkinen
2020-03-03 20:08     ` Jarkko Sakkinen
2020-03-03 20:40     ` James Bottomley
2020-03-03 20:40       ` James Bottomley
2020-03-03 21:20       ` Jarkko Sakkinen
2020-03-03 21:20         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200303212053.GB110353@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=dwmw2@infradead.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.