All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] random: Fix unused function warning
@ 2020-03-04  2:07 YueHaibing
  0 siblings, 0 replies; only message in thread
From: YueHaibing @ 2020-03-04  2:07 UTC (permalink / raw)
  To: tytso, arnd, gregkh, mark.rutland; +Cc: linux-kernel, yuehaibing

From: yuehaibing <yuehaibing@huawei.com>

drivers/char/random.c:820:13: warning:
 crng_initialize_secondary defined but not used [-Wunused-function]

crng_initialize_secondary now only used in do_numa_crng_init,
which wrapped by CONFIG_NUMA, so move it to fix the warning.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: yuehaibing <yuehaibing@huawei.com>
---
 drivers/char/random.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/char/random.c b/drivers/char/random.c
index f43f65c..3646ad7 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -817,14 +817,6 @@ static bool __init crng_init_try_arch_early(struct crng_state *crng)
 	return arch_init;
 }
 
-static void crng_initialize_secondary(struct crng_state *crng)
-{
-	memcpy(&crng->state[0], "expand 32-byte k", 16);
-	_get_random_bytes(&crng->state[4], sizeof(__u32) * 12);
-	crng_init_try_arch(crng);
-	crng->init_time = jiffies - CRNG_RESEED_INTERVAL - 1;
-}
-
 static void __init crng_initialize_primary(struct crng_state *crng)
 {
 	memcpy(&crng->state[0], "expand 32-byte k", 16);
@@ -839,6 +831,14 @@ static void __init crng_initialize_primary(struct crng_state *crng)
 }
 
 #ifdef CONFIG_NUMA
+static void crng_initialize_secondary(struct crng_state *crng)
+{
+	memcpy(&crng->state[0], "expand 32-byte k", 16);
+	_get_random_bytes(&crng->state[4], sizeof(__u32) * 12);
+	crng_init_try_arch(crng);
+	crng->init_time = jiffies - CRNG_RESEED_INTERVAL - 1;
+}
+
 static void do_numa_crng_init(struct work_struct *work)
 {
 	int i;
-- 
2.7.4



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-03-04  2:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04  2:07 [PATCH -next] random: Fix unused function warning YueHaibing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.